[Due for payment 2026-03-30] Assign new cards - Assign new cards tab with infinite spinner isn't close

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.40--0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #84313
Email or phone of affected tester (no customers): -
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: MacOS Monterey 12.7.4 / Chrome
App Component: Other

Action Performed:

Precondition: workspace with a direct card feed (e.g. Wells fargo)

1. Go to Company cards > Settings
2. Click on "Assign new cards" and complete re-auth

Expected Result:

Modal dismisses after re-auth. Assign new cards RHP closes

Actual Result:

Modal dismisses after re-auth. Assign new cards RHP with infinite spinner isn't close

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7106300_1773843491003.Screen_Recording_2026-03-18_at_16.07.08.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #84313

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After clicking "Assign new cards" in Company cards > Settings for a direct card feed and completing bank re-auth, the auth modal/popup dismisses but the "Assign new cards" RHP is stuck showing an infinite spinner and never closes.

What is the root cause of that problem?

The isRefreshComplete memo in useBankConnection.ts:72-77 requires a transition from expired to non-expired state:

return !!prevIsFeedExpired && !isFeedExpired && !isFeedConnectionBroken;

This fails for non-expired feeds (the typical case for "Assign new cards"):

1. isFeedExpired starts as false (feed is not expired)
2. prevIsFeedExpired is initialized to false by usePrevious (which initializes its ref with the current value)
3. !!prevIsFeedExpired is always false, so isRefreshComplete can never become true

Meanwhile, the main effect at line 148 explicitly skips calling handleSuccess() when isRefreshConnectionFlow is true:

if (!isRefreshConnectionFlow) {
    handleSuccess();
}
return;

And RefreshCardFeedConnectionPage does not pass an onSuccess callback to BankConnection (unlike BrokenCardFeedConnectionPage which passes both onSuccess and onFailure). So there is no fallback navigation path — the user is stuck on the spinner forever.

A secondary issue: isFeedConnectionBroken is a global flag (from all.isFeedConnectionBroken in useUpdateFeedBrokenConnection), meaning a broken connection on any unrelated feed would also block isRefreshComplete for the current feed.

What changes do you think we should make in order to solve the problem?

The fix should ensure the "Assign new cards" refresh flow can complete and dismiss the RHP even when the feed starts in a non-expired state. Specifically:

1. In useBankConnection.ts: Modify the main effect (around line 148) so that when isRefreshConnectionFlow is true and the feed is not expired and not broken, it calls handleSuccess() instead of silently returning. This way, after re-auth completes and the feed state is confirmed healthy, the flow navigates away.

2. In RefreshCardFeedConnectionPage.tsx: Pass an onSuccess callback to BankConnection that navigates back to the feed settings page (similar to how BrokenCardFeedConnectionPage handles success), providing a proper completion path.

What alternative solutions did you explore? (Optional)

An alternative would be to rework the isRefreshComplete detection to not rely on the expired-to-non-expired transition at all (e.g., detect when the bank connection popup completes via a connectionCompleted state), but this would be a larger change. The recommended approach is simpler and aligns with the existing pattern used by BrokenCardFeedConnectionPage.

---

Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.