[Due for payment 2026-03-30] [$250] Assigned Expensify card disappears from member profile RHP when direct feed is deleted

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.34-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-8199/folder/13176890/41237386/1238923514
Email or phone of affected tester (no customers): applausetester+i29230@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Mac 26.2 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

• Workspace is set up with Expensify Card.
• Assign yourself a virtual card.
• Add direct feed on Company Card page.

1. Go to staging.new.expensify.com
2. Go to workspace settings > Members.
3. Click on your profile.
   → Assign cards section is shown on member profile RHP.
4. Go to workspace settings > Company cards.
5. Click Settings > Remove card feed.
6. Click Delete.
7. Go to workspace settings > Members.
8. Click on your profile.

Expected Result:

The assigned Expensify card will appear on member profile RHP when direct feed is deleted.

Actual Result:

The assigned Expensify card disappears from member profile RHP when direct feed is deleted.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7098932_1773147839183.14.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @mallenexpensify

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022031456875589355951
• Upwork Job ID: 2031456875589355951
• Last Price Increase: 2026-03-10

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Assigned Expensify card disappears from member profile RHP when direct feed is deleted

What is the root cause of that problem?

Member profile RHP gets “Assign cards” from getAllCardsForWorkspace(workspaceAccountID, cardList, cardFeeds, expensifyCardSettings) in WorkspaceMemberDetailsPage. That function only keeps cards whose Onyx key is in one of these groups:
Workspace account cards – key.includes(workspaceAccountID)
Company domain cards – key matches a feed in companyCardsDomainFeeds (from cardFeeds)
Expensify domain cards – key matches expensifyCardSettings
companyCardsDomainFeeds is built only from current cardFeeds. When a direct feed is removed (Remove card feed → Delete), that feed is no longer in cardFeeds, so it’s no longer in companyCardsDomainFeeds. The Onyx key for that feed (e.g. cards__) is still in allCardList and still has assigned cards, but it no longer matches any entry in companyCardsDomainFeeds. So the condition isCompanyDomainCards is false and that key is skipped. Assigned cards for the deleted feed are never merged into cards, so they disappear from the member profile RHP.
So: deleting a direct feed removes it from cardFeeds; getAllCardsForWorkspace only includes company cards whose feed is in cardFeeds, so assigned cards for that feed are dropped even though the data is still in Onyx.

What changes do you think we should make in order to solve the problem?

We should include “orphaned” company-card keys: keys in allCardList that look like company card feeds (e.g. cards_*) but are not workspace-account, not Expensify-domain, and not in the current companyCardsDomainFeeds. Those are feeds that no longer exist in cardFeeds (e.g. deleted direct feed) but still have assigned cards in Onyx. By treating them as company card keys and merging their assigned cards into the result, assigned cards from deleted feeds keep showing on the member profile RHP.

 function getAllCardsForWorkspace(
     workspaceAccountID: number,
     allCardList: OnyxCollection<WorkspaceCardsList>,
     cardFeeds?: CombinedCardFeeds,
     expensifyCardSettings?: OnyxCollection<ExpensifyCardSettings>,
 ): CardList {
     const cards: CardList = {};
     const companyCardsDomainFeeds = Object.entries(cardFeeds ?? {}).map(([feedName, feedData]) => ({domainID: feedData.domainID, feedName}));
     const expensifyCardsDomainIDs = Object.keys(expensifyCardSettings ?? {})
         .map((key) => key.split('_').at(-1))
         .filter((id): id is string => !!id);

     for (const [key, values] of Object.entries(allCardList ?? {})) {
         const isWorkspaceAccountCards = workspaceAccountID !== CONST.DEFAULT_NUMBER_ID && key.includes(workspaceAccountID.toString());
         const isCompanyDomainCards = companyCardsDomainFeeds?.some((domainFeed) => domainFeed.domainID && key.includes(domainFeed.domainID.toString()) && key.includes(domainFeed.feedName));
         const isExpensifyDomainCards = expensifyCardsDomainIDs.some((domainID) => key.includes(domainID.toString()) && key.includes(CONST.EXPENSIFY_CARD.BANK));
-        if ((isWorkspaceAccountCards || isCompanyDomainCards || isExpensifyDomainCards) && values) {
+        const isOrphanedCompanyCardKey =
+            key.startsWith(ONYXKEYS.COLLECTION.WORKSPACE_CARDS_LIST) &&
+            !isWorkspaceAccountCards &&
+            !isExpensifyDomainCards &&
+            !isCompanyDomainCards;
+        if ((isWorkspaceAccountCards || isCompanyDomainCards || isExpensifyDomainCards || isOrphanedCompanyCardKey) && values) {
             const {cardList: assignableCards, ...assignedCards} = values ?? {};
             const filteredCards = filterInactiveCards(assignedCards);
             Object.assign(cards, filteredCards);
         }
     }
     return cards;
 }

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[MelvinBot]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a workspace has both an Expensify Card and a direct card feed (company card), deleting the direct feed via Company Cards > Settings > Remove card feed causes the assigned Expensify Card to disappear from the member profile RHP. The Expensify Card should remain visible since it was not affected by the feed deletion.

What is the root cause of that problem?

The root cause is in WorkspaceMemberDetailsPage.tsx:280 — the shouldShowCardsSection condition that gates visibility of the entire cards section:

const shouldShowCardsSection = Object.values(expensifyCardSettings ?? {}).some(
    (cardSettings) => isExpensifyCardFullySetUp(policy, cardSettings)
) || hasMultipleFeeds;

This condition requires either:

1. At least one Expensify Card feed is "fully set up" (policy.areExpensifyCardsEnabled && cardSettings.paymentBankAccountID), OR
2. hasMultipleFeeds is true — meaning non-Expensify company card feeds exist

hasMultipleFeeds (line 109) is computed via getCompanyFeeds(cardFeeds, false, true), which explicitly excludes Expensify Card feeds and filters out feeds with pendingAction: DELETE.

When the direct feed is deleted:

1. The optimistic update marks the feed with pendingAction: DELETE
2. getCompanyFeeds filters it out (due to shouldFilterOutPendingFeeds=true)
3. hasMultipleFeeds becomes false since no company card feeds remain
4. If isExpensifyCardFullySetUp also returns false (e.g., paymentBankAccountID is missing or areExpensifyCardsEnabled is false), then shouldShowCardsSection becomes false
5. The entire cards section is hidden, including any Expensify Cards that are still assigned to the member

The condition conflates "should we show the card management UI" with "does this member have assigned cards." Even when assigned Expensify Cards exist, the section can be hidden if neither gate condition is met after a company card feed deletion.

What changes do you think we should make in order to solve the problem?

In src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx, update the shouldShowCardsSection condition to also check whether the member has any assigned cards:

const shouldShowCardsSection =
    Object.values(expensifyCardSettings ?? {}).some((cardSettings) => isExpensifyCardFullySetUp(policy, cardSettings))
    || hasMultipleFeeds
    || memberCards.length > 0;

This ensures the cards section remains visible as long as the member has assigned cards, regardless of whether the Expensify Card is "fully set up" or whether company card feeds exist.

Note: memberCards is already computed at line 128, before shouldShowCardsSection is evaluated at line 280, so this is a safe change with no ordering issues.

What alternative solutions did you explore? (Optional)

An alternative would be to modify hasMultipleFeeds to not filter out pending-delete feeds during the deletion transition. However, this would be a less targeted fix — the real issue is that the condition doesn't account for the member's actual card assignments. The proposed fix is more direct and handles all edge cases (e.g., Expensify Card assigned but card program not fully set up).

---

Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022031456875589355951

[twilight2294]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a workspace has both an Expensify Card and a direct card feed (company card), deleting the direct feed via Company Cards > Settings > Remove card feed causes the assigned Expensify Card to disappear from the member profile RHP. The Expensify Card should remain visible since it was not affected by the feed deletion.

What is the root cause of that problem?

The root cause is in the shouldShowCardsSection condition at line 280 of WorkspaceMemberDetailsPage. This condition determines whether the entire cards section is visible:

const shouldShowCardsSection = Object.values(expensifyCardSettings ?? {}).some(
    (cardSettings) => isExpensifyCardFullySetUp(policy, cardSettings)
) || hasMultipleFeeds;

The condition requires either at least one Expensify Card feed to be "fully set up" (meaning policy.areExpensifyCardsEnabled && cardSettings.paymentBankAccountID both return truthy values) OR hasMultipleFeeds to be true (meaning non-Expensify company card feeds exist).

The problem occurs when a direct feed is deleted. The hasMultipleFeeds variable (line 109) is calculated via getCompanyFeeds(cardFeeds, false, true), which excludes Expensify Card feeds and filters out feeds with pending deletions. When the direct feed is marked for deletion, hasMultipleFeeds becomes false. If the Expensify Card is assigned but not "fully set up" (for example, if paymentBankAccountID is missing or areExpensifyCardsEnabled is false), then isExpensifyCardFullySetUp() also returns false. This causes shouldShowCardsSection to become false, hiding the entire cards section even though the member still has an assigned Expensify Card.

The condition incorrectly conflates "should we show the card management UI" with "does this member have assigned cards." Even when assigned Expensify Cards exist in memberCards, the section can be hidden if neither gate condition is satisfied.

What changes do you think we should make in order to solve the problem?

In WorkspaceMemberDetailsPage, update the shouldShowCardsSection condition to also check whether the member has any assigned cards:

const shouldShowCardsSection =
    Object.values(expensifyCardSettings ?? {}).some((cardSettings) => isExpensifyCardFullySetUp(policy, cardSettings))
    || hasMultipleFeeds
    || memberCards.length > 0;

This ensures the cards section remains visible as long as the member has assigned cards, regardless of whether the Expensify Card program is fully set up or whether company card feeds exist. The memberCards variable is already computed at line 128, before shouldShowCardsSection is evaluated, so this change is safe.

What alternative solutions did you explore? (Optional)

The existing proposal from samranahm focuses on modifying getAllCardsForWorkspace() in CardUtils to include "orphaned" company card keys from deleted feeds. However, that approach solves a different issue (keeping deleted feed cards visible during deletion) rather than the core problem described in this bug report, which is that an Expensify Card disappears when an unrelated direct feed is deleted. The solution proposed here directly addresses the visibility gate logic and is more targeted to the actual user-facing issue without affecting how cards are collected from Onyx.

[redstoneai]

Proposal

Hi,

Please re-state the problem that we are trying to solve in this issue.

When workspace has Expensify Card and direct feed, deleting the direct feed causes assigned Expensify Card to disappear from member profile RHP.

What is the root cause of that problem?

The issue is in shouldShowCardsSection condition at line 280 of WorkspaceMemberDetailsPage.tsx:

const shouldShowCardsSection = Object.values(expensifyCardSettings ?? {}).some(
    (cardSettings) => isExpensifyCardFullySetUp(policy, cardSettings)
) || hasMultipleFeeds;

This condition checks if card program is set up, not if member has assigned cards. The isExpensifyCardFullySetUp function returns:

return !!(policy?.areExpensifyCardsEnabled && cardSettings?.paymentBankAccountID);

So if paymentBankAccountID is missing or policy has areExpensifyCardsEnabled=false, the check fails even when card IS assigned to member.

The hasMultipleFeeds (line 109) uses getCompanyFeeds(cardFeeds, false, true) with shouldFilterOutPendingFeeds=true. When direct feed is deleted (marked with pendingAction: DELETE), it get filtered out, so hasMultipleFeeds becomes false.

When both conditions false, section hides even though member still has Expensify Card.

What changes do you think we should make in order to solve the problem?

The visibility condition should be user-centric: "does this member have any cards?" not system-centric: "is the program set up?".

Specifically check if member has Expensify cards assigned:

const memberHasExpensifyCard = memberCards.some(card => card.bank === CONST.EXPENSIFY_CARD.BANK);

const shouldShowCardsSection =
    Object.values(expensifyCardSettings ?? {}).some((cardSettings) => isExpensifyCardFullySetUp(policy, cardSettings))
    || hasMultipleFeeds
    || memberHasExpensifyCard;

This is better than just checking memberCards.length > 0 because:

1. Specifically targets Expensify cards which is what issue is about
2. Doesnt accidentally show section for orphaned company cards from deleted feeds
3. More precise fix that match the bug description

What alternative solutions did you explore?

1. Check all cards with memberCards.length > 0 - this would also show section for orphaned company cards from deleted feeds which may not be desired behavior
2. Modify getAllCardsForWorkspace to include orphaned keys - this is more invasive change and solve different problem

Thanks