[$250] [Ready for Payment] IOU - Rate field disabled if destination is self DM and no workspace during manual track distance

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.3.20-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-5427/folder/18717689/49855697/1193287714
Email or phone of affected tester (no customers): applausetester+ck2162610@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Windows 11/Chrome, iPhone 16/iOS 18.7.1, Pixel 8a/Android 16
App Component: Money Requests

Action Performed:

Precondition:

1. Use new Expensifail account
2. The user does not have workspace
3. User have Self-DM
   Steps:
4. Navigate to staging.new.expensify.com
5. Click the + global create button, select "Track Distance", and go to the "Manual" tab
6. Enter a valid distance and click "Next"
7. Select the user’s email address(Personal) as the recipient
8. On confirm page, observe Rate row is not clickable

Expected Result:

"Rate" option row in confirm page should be clickable & clicking on it should display the Upgrade pge

Actual Result:

Rate field not clickable if destination is self DM and no workspace during manual track distance flow

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7079676_1771268812163.60.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @lorretheboy

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022036911844599092850
• Upwork Job ID: 2036911844599092850
• Last Price Increase: 2026-03-25

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

[lorretheboy]

🚨 Edited by proposal-police: This proposal was edited at 2026-02-16 19:55:43 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOU - Rate field disabled if destination is self DM and no workspace during manual track distance

What is the root cause of that problem?

The Rate field has a condition !isUnreported in both the shouldShowRightIcon and interactive props, which prevented the field from being clickable when the transaction was unreported (i.e., going to self-DM).

App/src/components/MoneyRequestConfirmationListFooter.tsx

Line 554 in 35a55d7

shouldShowRightIcon={!!rate && !isReadOnly && iouType !== CONST.IOU.TYPE.SPLIT && !isUnreported}

What changes do you think we should make in order to solve the problem?

Update to

                    shouldShowRightIcon={!!rate && !isReadOnly && iouType !== CONST.IOU.TYPE.SPLIT && (!isUnreported || isTrackExpense)}

                    interactive={!!rate && !isReadOnly && iouType !== CONST.IOU.TYPE.SPLIT && (!isUnreported || isTrackExpense)}

So that it allows the Rate field to be clickable when tracking expenses (even if unreported)

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOU - Rate field disabled if destination is self DM and no workspace during manual track distance

What is the root cause of that problem?

The Rate row on the confirm step is only interactive when !!rate is true in MoneyRequestConfirmationListFooter.tsx. With self DM and no workspace there is no policy, so DistanceRequestUtils.getRate() can return a mileage rate with no rate (e.g. no default, or rate not set yet). Then !!rate is false and the row is non-interactive even though the onPress handler is correct: for non–policy chats it should open the Upgrade page. So the bug is the condition that gates interactivity, not the navigation logic.

What changes do you think we should make in order to solve the problem?

We should allow the Rate row to be interactive when there’s no workspace (self DM)
In MoneyRequestConfirmationListFooter.tsx, the Rate row is only interactive when !!rate is true. When the destination is self DM and there’s no workspace, there is no policy and rate can be missing, so the row is not clickable. Change the condition so the row is interactive when there is a rate or when it’s not a policy expense chat (self DM).
Update interactive for the Rate row

interactive={(!!rate || !isPolicyExpenseChat) && !isReadOnly && iouType !== CONST.IOU.TYPE.SPLIT && !isUnreported}
shouldShowRightIcon={(!!rate || !isPolicyExpenseChat) && !isReadOnly && iouType !== CONST.IOU.TYPE.SPLIT && !isUnreported}

here

App/src/components/MoneyRequestConfirmationListFooter.tsx

Line 554 in 3be7fc6

shouldShowRightIcon={!!rate && !isReadOnly && iouType !== CONST.IOU.TYPE.SPLIT && !isUnreported}

App/src/components/MoneyRequestConfirmationListFooter.tsx

Line 582 in 3be7fc6

interactive={!!rate && !isReadOnly && iouType !== CONST.IOU.TYPE.SPLIT && !isUnreported}

so the row is clickable for self DM even when rate is falsy.
Update shouldShowRightIcon for the Rate row
Use the same condition for the right caret:
so the caret only shows when the row is tappable.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[annaweber830]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a user without any workspace tracks distance manually and selects their self-DM as the destination, the Rate row is disabled on the confirmation page. It should stay clickable so the user can open the upgrade flow for distance rates.

What is the root cause of that problem?

App/src/components/MoneyRequestConfirmationListFooter.tsx

Lines 552 to 583 in 1d699f9

	<MenuItemWithTopDescription
	key={translate('common.rate')}
	shouldShowRightIcon={!!rate && !isReadOnly && iouType !== CONST.IOU.TYPE.SPLIT && !isUnreported}
	title={DistanceRequestUtils.getRateForDisplay(unit, rate, currency, translate, toLocaleDigit, getCurrencySymbol, isOffline)}
	description={translate('common.rate')}
	style={[styles.moneyRequestMenuItem]}
	titleStyle={styles.flex1}
	onPress={() => {
	if (!transactionID) {
	return;
	}
	if (!isPolicyExpenseChat) {
	Navigation.navigate(
	ROUTES.MONEY_REQUEST_UPGRADE.getRoute({
	action,
	iouType,
	transactionID,
	reportID,
	upgradePath: CONST.UPGRADE_PATHS.DISTANCE_RATES,
	backTo: Navigation.getActiveRoute(),
	shouldSubmitExpense: true,
	}),
	);
	return;
	}
	Navigation.navigate(ROUTES.MONEY_REQUEST_STEP_DISTANCE_RATE.getRoute(action, iouType, transactionID, reportID, Navigation.getActiveRoute(), reportActionID));
	}}
	brickRoadIndicator={shouldDisplayDistanceRateError ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : undefined}
	disabled={didConfirm}
	interactive={!!rate && !isReadOnly && iouType !== CONST.IOU.TYPE.SPLIT && !isUnreported}
	sentryLabel={CONST.SENTRY_LABEL.REQUEST_CONFIRMATION_LIST.RATE_FIELD}

<MenuItemWithTopDescription
    key={translate('common.rate')}
    shouldShowRightIcon={!!rate && !isReadOnly && iouType !== CONST.IOU.TYPE.SPLIT && !isUnreported}
    // ...
    interactive={!!rate && !isReadOnly && iouType !== CONST.IOU.TYPE.SPLIT && !isUnreported}
/>

For self-DM manual track-distance flows, the transaction remains on the unreported report (isUnreported === true). This causes both shouldShowRightIcon and interactive to evaluate to false because they are hard-gated by !isUnreported, so the row cannot be tapped and the upgrade route is never reached.

What changes do you think we should make in order to solve the problem?

App/src/components/MoneyRequestConfirmationListFooter.tsx

Lines 552 to 583 in 1d699f9

	<MenuItemWithTopDescription
	key={translate('common.rate')}
	shouldShowRightIcon={!!rate && !isReadOnly && iouType !== CONST.IOU.TYPE.SPLIT && !isUnreported}
	title={DistanceRequestUtils.getRateForDisplay(unit, rate, currency, translate, toLocaleDigit, getCurrencySymbol, isOffline)}
	description={translate('common.rate')}
	style={[styles.moneyRequestMenuItem]}
	titleStyle={styles.flex1}
	onPress={() => {
	if (!transactionID) {
	return;
	}
	if (!isPolicyExpenseChat) {
	Navigation.navigate(
	ROUTES.MONEY_REQUEST_UPGRADE.getRoute({
	action,
	iouType,
	transactionID,
	reportID,
	upgradePath: CONST.UPGRADE_PATHS.DISTANCE_RATES,
	backTo: Navigation.getActiveRoute(),
	shouldSubmitExpense: true,
	}),
	);
	return;
	}
	Navigation.navigate(ROUTES.MONEY_REQUEST_STEP_DISTANCE_RATE.getRoute(action, iouType, transactionID, reportID, Navigation.getActiveRoute(), reportActionID));
	}}
	brickRoadIndicator={shouldDisplayDistanceRateError ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : undefined}
	disabled={didConfirm}
	interactive={!!rate && !isReadOnly && iouType !== CONST.IOU.TYPE.SPLIT && !isUnreported}
	sentryLabel={CONST.SENTRY_LABEL.REQUEST_CONFIRMATION_LIST.RATE_FIELD}

Current code:

<MenuItemWithTopDescription
    key={translate('common.rate')}
    shouldShowRightIcon={!!rate && !isReadOnly && iouType !== CONST.IOU.TYPE.SPLIT && !isUnreported}
    title={DistanceRequestUtils.getRateForDisplay(unit, rate, currency, translate, toLocaleDigit, getCurrencySymbol, isOffline)}
    description={translate('common.rate')}
    // ...
    interactive={!!rate && !isReadOnly && iouType !== CONST.IOU.TYPE.SPLIT && !isUnreported}
    sentryLabel={CONST.SENTRY_LABEL.REQUEST_CONFIRMATION_LIST.RATE_FIELD}
/>

Updated code:

<MenuItemWithTopDescription
    key={translate('common.rate')}
    shouldShowRightIcon={!!rate && !isReadOnly && iouType !== CONST.IOU.TYPE.SPLIT && (!isUnreported || isTrackExpense)}
    title={DistanceRequestUtils.getRateForDisplay(unit, rate, currency, translate, toLocaleDigit, getCurrencySymbol, isOffline)}
    description={translate('common.rate')}
    // ...
    interactive={!!rate && !isReadOnly && iouType !== CONST.IOU.TYPE.SPLIT && (!isUnreported || isTrackExpense)}
    sentryLabel={CONST.SENTRY_LABEL.REQUEST_CONFIRMATION_LIST.RATE_FIELD}
/>

This keeps the existing restriction for non-track unreported contexts, but allows manual distance tracking (iouType === TRACK) to keep the Rate row interactive so users can access the upgrade page. It also updates both icon visibility and interactivity together to keep behavior consistent.

What alternative solutions did you explore? (Optional)

• Remove the !isUnreported check entirely. I did not choose this because it broadens behavior beyond track-distance and may unintentionally enable rate editing in other unreported flows.
• Existing proposals suggested the same conditional direction, but they lacked required evidence formatting (missing root-cause code snippet and missing Current code/Updated code blocks), so they are not optimized/validator-compliant.

[twilight2294]

🚫 Duplicated proposal withdrawn by 🤖 ProposalPolice.

[github-actions]

⚠️ @twilight2294 Your proposal is a duplicate of an already existing proposal and has been automatically withdrawn to prevent spam. Please review the existing proposals before submitting a new one.