Per diem - Destination list is not scrolled to the top when opened from confirm page

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.10-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #80335
Email or phone of affected tester (no customers): sodijnsodijsodijsoi@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.1 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Workspace has per diem rates.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Click + > Create expense > Per diem.
4. Select details and reach confirm page.
5. On confirm page, click Destination field.

Expected Result:

Destination list will scroll to the top.

Actual Result:

Destination list is not scrolled to the top.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #80335

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

🔍 Investigation Summary

Classification: Frontend bug
Causing PR: #80335 - "Make DestinationPicker use new SelectionListWitSections" by @zfurtak (High confidence)
Related Issues: #65658

Recommendation: REVERT

The PR introduced a new prop disableMaintainingScrollPosition to the DestinationPicker component which prevents the list from maintaining scroll position. This causes the destination list to not scroll to the top when reopened from the confirm page, which is the reported bug.

Labels: No changes needed - DeployBlockerCash is correctly applied (frontend bug blocking App deploy)

📋 Detailed Analysis

Evidence

• The issue explicitly mentions PR Make DestinationPicker use new SelectionListWitSections #80335 in the bug report
• The bug is reproducible in staging (v9.3.10-0) where PR Make DestinationPicker use new SelectionListWitSections #80335 is deployed
• The bug is NOT reproducible in production where PR Make DestinationPicker use new SelectionListWitSections #80335 is not yet deployed
• Melvin-bot automatically assigned the PR author to this deploy blocker

Verification

The PR modified src/components/DestinationPicker.tsx and added the following key change on line 88:

disableMaintainingScrollPosition

This prop is passed to the SelectionListWithSections component and controls the scroll behavior. When set to true, it disables the scroll position maintenance feature, which prevents the list from scrolling to the expected position when reopened.

Root Cause

The disableMaintainingScrollPosition prop was added to prevent the list from automatically adjusting scroll position during data updates. However, this also prevents the list from scrolling to the top when the component is remounted or reopened from another page (like the confirm page).

When a user navigates from the confirm page back to the destination picker, the component key changes (key={selectedDestination} on line 79), which should cause a remount. However, the disableMaintainingScrollPosition prop interferes with the expected scroll-to-top behavior that should occur on mount/remount.

The fix would require either:

1. Removing the disableMaintainingScrollPosition prop from DestinationPicker
2. Adding logic to reset scroll position when the component is opened from another page
3. Using a different approach to handle the scroll position

[zfurtak]

Yeah, this is most probably my PR, I'm looking into it right now 👍

[grgia]

@zfurtak are you able to push a fix today? Or do we need to revert to have more time