Attendee - Multiple attendee violation only applicable for the owner of the WS

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.3.3-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #79050
Email or phone of affected tester (no customers): testpayment935@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Windows 11 pro /Chrome
App Component: Money Requests

Action Performed:

Preconditions:
Rules are enabled.
Enable Attendee tracking in Rules.

1. Navigate to staging.new.expensify.com
2. Go to workspace chat.
3. Create expenses with Equipment category and change the WS attendee to other user (remove WS owner)
4. Go to Workspace Settings > Categories.
5. Open Equipment settings.
6. Click Require fields.
7. Enable Require attendees.
8. Navigate straight to Reports > Expenses without opening the report first.

Expected Result:

"Multiple attendees required for this category" violation is shown on the expense row.

Actual Result:

"Multiple attendees required for this category" violation is not shown on the expense row if the attendee is other than yourself

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @JS00001

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #79050

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[OSBotify]

Investigation Summary

Classification: Frontend bug
Causing PR: #79050 - feat: add ability to require attendees based on category selection (rework) by @ikevin127 (High confidence)

Recommendation: REVERT

PR #79050 introduced a bug in the attendee violation logic for the Reports > Expenses view. The violation check uses the current logged-in user's details instead of the expense creator's details, causing incorrect validation when viewing expenses created by other users.

Labels: Will KEEP DeployBlockerCash (App PR caused the issue). DeployBlocker label is not present on this issue.

Evidence

The bug reproduces when:

1. A user (not the workspace owner) creates an expense
2. They select a category requiring attendees but only add one attendee (not themselves)
3. The workspace owner views Reports > Expenses
4. Expected: Multiple attendees required for this category violation shows
5. Actual: No violation shows

This matches the issue description: Multiple attendee violation only applicable for the owner of the WS

Root Cause

The violation logic in src/libs/AttendeeUtils.ts checks if there are attendees besides the expense creator. However, the code in src/components/SelectionListWithSections/Search/TransactionListItem.tsx line 164 passes the current viewers details instead of the creators details.

Affected file: src/components/SelectionListWithSections/Search/TransactionListItem.tsx line 164
Fix needed: Pass transactionItem.from instead of currentUserDetails to syncMissingAttendeesViolation

[ikevin127]

Going to CP a fix here to disable the feature: #79620

@JS00001 This should be fixed by the ☝️ CP.
🗒️ Noted for follow-up PR.