[HOLD for payment 2022-03-22] Send button is active when message has spaces, but does not send it - reported by @ahmdshrif

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to any chat
2. Type spaces
3. Hit send

Expected Result:

The send button should not be active since the message is just spaces

Actual Result:

The send message button is active but does not work

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.41-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20220214-171423_New.Expensify.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ahmdshrif
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1644851918442949

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @MariaHCD (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[sobitneupane]

Proposal:
Trimming comment before checking isCommentEmpty solves the issue. For this, we need to make following change.

App/src/pages/home/report/ReportActionCompose.js

Lines 307 to 312 in d6e64b3

	updateComment(newComment) {
	this.textInput.setNativeProps({text: newComment});
	this.setState({
	isCommentEmpty: newComment.length === 0,
	});

    updateComment(newComment) {
        this.textInput.setNativeProps({text: newComment});
        this.setState({
            isCommentEmpty: newComment.trim().length === 0,
        });

App/src/pages/home/report/ReportActionCompose.js

Line 349 in d6e64b3

if (e.key === 'ArrowUp' && this.state.isCommentEmpty) {

        if (e.key === 'ArrowUp' && this.textInput.value.length === 0) {

[MelvinBot]

Triggered auto assignment to @bfitzexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[bfitzexpensify]

Upwork post here