[$250] Login - "All caught up" and skeleton loading in Inbox after logging with magic link and 2FA

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.99-5
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176924/test-cases/41237550
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: MacBook Air 15.7.3 Chrome
App Component: Other

Action Performed:

Preconditions: use an account with 2FA enabled

1. Navigate to ND, on Sign in page enter an account from the preconditions, click continue
2. Verify you're asked for the magic code
3. Navigate to email and locate the magic link
4. Change the link to staging, paste the link in the new tab
5. Navigate to the link - the 2FA code is asked
6. On the main page enter the correct 2FA code in the code field
7. Navigate from Home to Inbox

Expected Result:

Inbox page loads successfully

Actual Result:

"All caught up" is displayed in LHN, skeleton loading is shown in the Inbox

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022011668237611239662
• Upwork Job ID: 2011668237611239662
• Last Price Increase: 2026-04-15

Issue Owner

Current Issue Owner: @ahmedGaber93

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022011668237611239662

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ShridharGoel (External)

[cosmicvulpes]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After 2FA login, LHN shows "All caught up" despite reports existing in Onyx. Refreshing fixes it.

What is the root cause of that problem?

reportAttributes.compute() returns {reports: {}} when areAllConnectionsSet is false.

The NVP_PREFERRED_LOCALE dependency uses ARE_TRANSLATIONS_LOADING with initWithStoredValues: false. In multi-tab scenarios, translations may already be loaded before OnyxDerived.init() runs. Since initWithStoredValues: false only fires on changes, the callback never fires, the locale dependency never initializes, and areAllConnectionsSet stays false forever.

What changes do you think we should make in order to solve the problem?

In src/libs/actions/OnyxDerived/index.ts, dynamically set initWithStoredValues based on whether translations are already loaded:

const areTranslationsAlreadyLoaded = !!IntlStore.getCurrentLocale();
Onyx.connectWithoutView({
    key: ONYXKEYS.ARE_TRANSLATIONS_LOADING,
    initWithStoredValues: areTranslationsAlreadyLoaded,
    callback: (value) => { ... }
});

If translations are already loaded, initWithStoredValues: true ensures the callback fires immediately with the stored false value, initializing the dependency.

What alternative solutions did you explore? (Optional)

N/A

[ShridharGoel]

Able to repro even after trying the above proposal

[cosmicvulpes]

@ShridharGoel Updated the proposal. The fix is working fine now, verified on my dev instance. Please take a look again.