[Due for payment 2026-02-04] [$250] Expense - Split label is not removed from Amount field when split is submitted to 1:1 DM

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.94-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-2676/folder/13176670/41237133/1108361502
Email or phone of affected tester (no customers): sdjoisjnodisjoijdosi@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.1 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Create an expense.
4. Open expense report.
5. Click More > Split > Save.
6. Open any split.
7. Click Report field > Remove from report.
8. Go to self DM.
9. Open the unreported split.
10. Click on report header > Submit it to someone.
11. Select a user and submit it to them.
12. Open the expense.

Expected Result:

Split label should be removed from Amount field.

Actual Result:

Split label is not removed from Amount field when split is submitted to 1:1 DM.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7042200_1767708463679.3.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022009470090561349745
• Upwork Job ID: 2009470090561349745
• Last Price Increase: 2026-01-09
• Automatic offers:
• samranahm | Contributor | 110151912

Issue Owner

Current Issue Owner: @RachCHopkins

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MobileMage]

Please re-state the problem that we are trying to solve in this issue.

When a split expense child transaction is removed from a report and then submitted to a 1:1 DM, the "Split" label still appears on the Amount field even though the expense is no longer part of a split.

What is the root cause of that problem?

The issue is in src/libs/actions/Transaction.ts in the changeTransactionsReport function (line 857-868).

When a split is created, child transactions are marked with:

• comment.originalTransactionID - pointing to the parent transaction
• comment.source === 'split'

The getOriginalTransactionWithSplitInfo function in TransactionUtils/index.ts:2333 uses these fields to determine if a transaction is part of a split:

if (!originalTransactionID || source !== CONST.IOU.TYPE.SPLIT) {
    return {isBillSplit: false, ...};
}
return {isBillSplit: !!originalTransaction?.comment?.splits, ...};

When changeTransactionsReport moves a transaction to a new report, it only clears comment.hold:

optimisticData.push({
    onyxMethod: Onyx.METHOD.MERGE,
    key: `${ONYXKEYS.COLLECTION.TRANSACTION}${transaction.transactionID}`,
    value: {
        reportID,
        comment: {
            hold: null,  // Only clears hold
        },
    },
});

It does NOT clear originalTransactionID or source, so the transaction still appears as a split child even after being submitted to a 1:1 DM.

What changes do you think we should make in order to solve the problem?

In src/libs/actions/Transaction.ts, modify changeTransactionsReport to clear split-related fields when moving a split child transaction:

+ const isSplitChild = transaction.comment?.source === CONST.IOU.TYPE.SPLIT;

optimisticData.push({
    onyxMethod: Onyx.METHOD.MERGE,
    key: `${ONYXKEYS.COLLECTION.TRANSACTION}${transaction.transactionID}`,
    value: {
        reportID,
        comment: {
            hold: null,
+           ...(isSplitChild ? {
+               originalTransactionID: undefined,
+               source: undefined,
+           } : {}),
        },
        ...(oldIOUAction ? {linkedTrackedExpenseReportAction: newIOUAction} : {}),
    },
});

Also update the failureData to restore the original values on failure:

failureData.push({
    onyxMethod: Onyx.METHOD.MERGE,
    key: `${ONYXKEYS.COLLECTION.TRANSACTION}${transaction.transactionID}`,
    value: {
        reportID: transaction.reportID,
        comment: {
            hold: transaction.comment?.hold,
+           ...(isSplitChild ? {
+               originalTransactionID: transaction.comment?.originalTransactionID,
+               source: transaction.comment?.source,
+           } : {}),
        },
    },
});

What alternative solutions did you explore?

N/A

[duckemiah]

Please re-state the problem that we are trying to solve in this issue.

When a split expense child transaction is removed from a report and then submitted to a 1:1 DM, the "Split" label still appears on the Amount field even though the expense is no longer part of a split.

What is the root cause of that problem?

The issue is in src/components/ReportActionItem/TransactionPreview/index.tsx where isBillSplit is passed inconsistently to TransactionPreviewContent.

Split child transactions have comment.originalTransactionID pointing to their parent. When rendering the preview, there are two code paths:

Line 119 (when onPreviewPressed exists):

isBillSplit={isBillSplit && !transaction?.comment?.originalTransactionID}

Line 143 (else branch):

isBillSplit={isBillSplit}

Line 119 correctly filters out split children (transactions with originalTransactionID), but line 143 does not. When the expense is viewed in the 1:1 DM context, it goes through the else branch without the filter, causing the "Split" label to incorrectly appear.

What changes do you think we should make in order to solve the problem?

Make line 143 consistent with line 119 by adding the same filter:

src/components/ReportActionItem/TransactionPreview/index.tsx:

    return (
        <TransactionPreviewContent
            /* eslint-disable-next-line react/jsx-props-no-spreading */
            {...props}
            action={iouAction}
-           isBillSplit={isBillSplit}
+           isBillSplit={isBillSplit && !transaction?.comment?.originalTransactionID}
            chatReport={chatReport}
            personalDetails={personalDetails}
            transaction={originalTransaction ?? transaction}
            ...
        />
    );

This ensures split child transactions (which have originalTransactionID) never show the "Split" label, regardless of which code path is taken.

What alternative solutions did you explore?

1. Clear split data when moving transaction: Could modify changeTransactionsReport in Transaction.ts to clear comment.originalTransactionID and comment.source when moving a split child. This is more thorough but higher risk as it modifies transaction data permanently.

2. Check report type in getOriginalTransactionWithSplitInfo: Could add logic to return isBillSplit: false if transaction is in a 1:1 DM. However, this adds complexity to a utility function for a display concern.

The proposed UI fix is minimal, consistent with existing patterns (line 119), and carries low risk since it only affects display logic without modifying underlying data.

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Split label is not removed from Amount field when split is submitted to 1:1 DM

What is the root cause of that problem?

When a split expense was submitted to a 1:1 DM or any other report, it was still being marked as a split expense even though it had been converted to a regular expense in an expense report. in isExpenseSplit

App/src/libs/TransactionUtils/index.ts

Lines 2317 to 2326 in 36c9a87

	function isExpenseSplit(transaction: OnyxEntry<Transaction>, originalTransaction?: OnyxEntry<Transaction>): boolean {
	if (!originalTransaction) {
	return !!transaction?.comment?.originalTransactionID && transaction?.comment?.source === 'split';
	}
	const {originalTransactionID, source, splits} = transaction?.comment ?? {};
	// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
	if ((splits && splits.length > 0) || !originalTransactionID || source !== CONST.IOU.TYPE.SPLIT) {
	return false;

What changes do you think we should make in order to solve the problem?

If the transaction has been assigned to an actual report (not the split report or unreported), it should no longer considered a split expense

const isAddedToReport = !!transaction?.reportID && transaction.reportID !== CONST.REPORT.SPLIT_REPORT_ID && transaction.reportID !== CONST.REPORT.UNREPORTED_REPORT_ID;
    if (isAddedToReport) {
        return false;
    }

here

App/src/libs/TransactionUtils/index.ts

Lines 2317 to 2326 in 36c9a87

	function isExpenseSplit(transaction: OnyxEntry<Transaction>, originalTransaction?: OnyxEntry<Transaction>): boolean {
	if (!originalTransaction) {
	return !!transaction?.comment?.originalTransactionID && transaction?.comment?.source === 'split';
	}
	const {originalTransactionID, source, splits} = transaction?.comment ?? {};
	// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
	if ((splits && splits.length > 0) || !originalTransactionID || source !== CONST.IOU.TYPE.SPLIT) {
	return false;

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[lorretheboy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Split label is not removed from Amount field when split is submitted to 1:1 DM.

What is the root cause of that problem?

The issue was in the isExpenseSplit, ot didn't check whether the transaction had been submitted to a report (i.e., moved from unreported status) --> caused the "Split" text to appear in the amount description even after submission

App/src/libs/TransactionUtils/index.ts

Lines 2317 to 2330 in 98ffa03

	function isExpenseSplit(transaction: OnyxEntry<Transaction>, originalTransaction?: OnyxEntry<Transaction>): boolean {
	if (!originalTransaction) {
	return !!transaction?.comment?.originalTransactionID && transaction?.comment?.source === 'split';
	}
	const {originalTransactionID, source, splits} = transaction?.comment ?? {};
	// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
	if ((splits && splits.length > 0) || !originalTransactionID || source !== CONST.IOU.TYPE.SPLIT) {
	return false;
	}
	return !originalTransaction?.comment?.splits;
	}

What changes do you think we should make in order to solve the problem?

If the transaction has been submitted to a report (not unreported), it's no longer a split expense

    if (transaction?.reportID && transaction.reportID !== CONST.REPORT.UNREPORTED_REPORT_ID) {
        return false;
    }

App/src/libs/TransactionUtils/index.ts

Line 2328 in 98ffa03

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022009470090561349745

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)