[Due for payment 2026-01-23] [$250] Travel - User without verification can trigger “Request Sent” state on Travel page

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.90-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-2597/folder/13177079/41237920/1101375175
Email or phone of affected tester (no customers): luongvu92@private.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Windows 10/Chrome
App Component: Workspace Settings

Action Performed:

1. Sign up for a new account in NewDot with a private domain account (Don't validate the account)
2. Finish the onboarding with 1-10 members
3. Navigate to the Workspace features
4. Toggle on the Travel
5. Click on the Travel -> Let's Go button
6. Click back on the RHP without entering the magic code

Expected Result:

The Let's go button is in the same status because the account isn't verified yet

Actual Result:

The Let's go button changed status to Request sent

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022006670805403073426
• Upwork Job ID: 2006670805403073426
• Last Price Increase: 2026-01-01
• Automatic offers:
• situchan | Reviewer | 110019120

Issue Owner

Current Issue Owner: @bfitzexpensify

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[TaduJR]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a user without account verification clicks "Let's Go" on the Travel page, navigates to the verification page, then clicks back without entering the magic code, the button state incorrectly changes to "Request Sent".

What is the root cause of that problem?

The handleClose callback in VerifyAccountPage.tsx unconditionally calls requestTravelAccess() when the page closes, regardless of whether the user actually completed verification.

Root Cause Flow Analysis

1. User clicks "Let's Go" button which triggers bookATrip():

App/src/components/BookTravelButton.tsx

Lines 120 to 124 in 66de3d6

	} else if (!isBetaEnabled(CONST.BETAS.IS_TRAVEL_VERIFIED)) {
	if (!isUserValidated) {
	Navigation.navigate(ROUTES.TRAVEL_VERIFY_ACCOUNT.getRoute(undefined, activePolicyID, Navigation.getActiveRoute()));
	return;
	}

2. Since user is not validated, they're navigated to VerifyAccountPage:

App/src/pages/Travel/VerifyAccountPage.tsx

Lines 16 to 46 in 66de3d6

	function VerifyAccountPage({route}: VerifyAccountPageProps) {
	const {domain, backTo, policyID} = route.params;
	const [travelProvisioning] = useOnyx(ONYXKEYS.TRAVEL_PROVISIONING, {canBeMissing: true});
	const {isBetaEnabled} = usePermissions();
	useEffect(() => {
	return () => {
	setTravelProvisioningNextStep();
	};
	}, []);
	const isTravelVerifiedBetaEnabled = isBetaEnabled(CONST.BETAS.IS_TRAVEL_VERIFIED);
	// Determine where to navigate after successful OTP validation
	const navigateForwardTo = isTravelVerifiedBetaEnabled ? (travelProvisioning?.nextStepRoute ?? ROUTES.TRAVEL_TCS.getRoute(domain ?? '', policyID)) : undefined;
	const handleClose = useCallback(() => {
	requestTravelAccess();
	Navigation.goBack(backTo);
	}, [backTo]);
	return (
	<VerifyAccountPageBase
	navigateBackTo={backTo}
	navigateForwardTo={navigateForwardTo}
	handleClose={!isTravelVerifiedBetaEnabled ? handleClose : undefined}
	/>
	);
	}
	export default VerifyAccountPage;

3. The handleClose callback unconditionally calls requestTravelAccess():

App/src/pages/Travel/VerifyAccountPage.tsx

Lines 32 to 35 in 66de3d6

	const handleClose = useCallback(() => {
	requestTravelAccess();
	Navigation.goBack(backTo);
	}, [backTo]);

4. When user clicks back button, handleCloseWithFallback triggers the custom handleClose:

App/src/pages/settings/VerifyAccountPageBase.tsx

Lines 44 to 50 in 66de3d6

	const handleCloseWithFallback = useCallback(() => {
	if (handleClose) {
	handleClose();
	return;
	}
	Navigation.goBack(navigateBackTo);
	}, [handleClose, navigateBackTo]);

5. requestTravelAccess() sets lastTravelSignupRequestTime in Onyx:

App/src/libs/actions/Travel.ts

Lines 52 to 65 in 66de3d6

	{
	onyxMethod: 'merge',
	key: ONYXKEYS.TRAVEL_PROVISIONING,
	value: {
	isLoading: false,
	errors: getMicroSecondOnyxErrorWithTranslationKey('travel.errorMessage'),
	},
	},
	];
	const params: AcceptSpotnanaTermsParams = {domain, policyID};
	// We need to call this API immediately to get the response and open the travel page.
	// See https://github.com/Expensify/App/pull/69769#discussion_r2368967354 for more info.

6. getTravelStep() returns REVIEWING_REQUEST when lastTravelSignupRequestTime exists:

App/src/libs/PolicyUtils.ts

Lines 1683 to 1685 in 66de3d6

	return CONST.TRAVEL.STEPS.BOOK_OR_MANAGE_YOUR_TRIP;
	}
	if (!isTravelVerifiedBetaEnabled && travelSettings?.lastTravelSignupRequestTime) {

The problem is that handleClose is called both when user dismisses/goes back AND when they successfully validate, but it doesn't distinguish between these two cases.

What changes do you think we should make in order to solve the problem?

Add an onValidationSuccess callback prop to VerifyAccountPageBase that is called ONLY when the user successfully validates their account. This separates the success path from the dismiss/back path.

Solution

1. Add onValidationSuccess prop to VerifyAccountPageBase:

App/src/pages/settings/VerifyAccountPageBase.tsx

Line 17 in 66de3d6

type VerifyAccountPageBaseProps = {navigateBackTo?: Route; navigateForwardTo?: Route; handleClose?: () => void};

-type VerifyAccountPageBaseProps = {navigateBackTo?: Route; navigateForwardTo?: Route; handleClose?: () => void};
+type VerifyAccountPageBaseProps = {
+    navigateBackTo?: Route;
+    navigateForwardTo?: Route;
+    handleClose?: () => void;
+    /** Callback called ONLY when user successfully validates their account (not on dismiss/back) */
+    onValidationSuccess?: () => void;
+};

2. Call onValidationSuccess in the validation useEffect before navigation:

App/src/pages/settings/VerifyAccountPageBase.tsx

Lines 53 to 62 in 66de3d6

	useEffect(() => {
	if (!isUserValidated) {
	return;
	}
	if (navigateForwardTo) {
	Navigation.navigate(navigateForwardTo, {forceReplace: true});
	} else {
	handleCloseWithFallback();
	}
	}, [isUserValidated, navigateForwardTo, handleCloseWithFallback, handleClose]);

 useEffect(() => {
     if (!isUserValidated) {
         return;
     }
+    // Call the success callback ONLY when user successfully validates
+    onValidationSuccess?.();
+
     if (navigateForwardTo) {
         Navigation.navigate(navigateForwardTo, {forceReplace: true});
     } else {
         handleCloseWithFallback();
     }
-}, [isUserValidated, navigateForwardTo, handleCloseWithFallback, handleClose]);
+}, [isUserValidated, navigateForwardTo, handleCloseWithFallback, handleClose, onValidationSuccess]);

3. Update VerifyAccountPage.tsx to use onValidationSuccess and remove requestTravelAccess() from handleClose:

App/src/pages/Travel/VerifyAccountPage.tsx

Lines 32 to 35 in 66de3d6

	const handleClose = useCallback(() => {
	requestTravelAccess();
	Navigation.goBack(backTo);
	}, [backTo]);

+const handleValidationSuccess = useCallback(() => {
+    requestTravelAccess();
+}, []);
+
 const handleClose = useCallback(() => {
-    requestTravelAccess();
     Navigation.goBack(backTo);
 }, [backTo]);

 return (
     <VerifyAccountPageBase
         navigateBackTo={backTo}
         navigateForwardTo={navigateForwardTo}
         handleClose={!isTravelVerifiedBetaEnabled ? handleClose : undefined}
+        onValidationSuccess={!isTravelVerifiedBetaEnabled ? handleValidationSuccess : undefined}
     />
 );

This ensures:

• handleClose → navigation only (dismiss/back)
• onValidationSuccess → business logic triggered on actual validation success

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Travel - User without verification can trigger “Request Sent” state on Travel page.

What is the root cause of that problem?

The Travel verify account page always calls requestTravelAccess when the user closes the OTP flow, no matter whether the account is validated. That writes lastTravelSignupRequestTime and moves the workspace into the “Reviewing request” state.

App/src/pages/Travel/VerifyAccountPage.tsx

Lines 16 to 35 in 66de3d6

	function VerifyAccountPage({route}: VerifyAccountPageProps) {
	const {domain, backTo, policyID} = route.params;
	const [travelProvisioning] = useOnyx(ONYXKEYS.TRAVEL_PROVISIONING, {canBeMissing: true});
	const {isBetaEnabled} = usePermissions();
	useEffect(() => {
	return () => {
	setTravelProvisioningNextStep();
	};
	}, []);
	const isTravelVerifiedBetaEnabled = isBetaEnabled(CONST.BETAS.IS_TRAVEL_VERIFIED);
	// Determine where to navigate after successful OTP validation
	const navigateForwardTo = isTravelVerifiedBetaEnabled ? (travelProvisioning?.nextStepRoute ?? ROUTES.TRAVEL_TCS.getRoute(domain ?? '', policyID)) : undefined;
	const handleClose = useCallback(() => {
	requestTravelAccess();
	Navigation.goBack(backTo);
	}, [backTo]);

What changes do you think we should make in order to solve the problem?

• Read the account record inside the Travel verify page and gate the close handler so we only call requestTravelAccess after the account is validated. This keeps the CTA as “Let’s go” until the user finishes OTP.

Updated code snippet:

function VerifyAccountPage({route}: VerifyAccountPageProps) {
    const {domain, backTo, policyID} = route.params;
    const [account] = useOnyx(ONYXKEYS.ACCOUNT, {canBeMissing: true});
    const [travelProvisioning] = useOnyx(ONYXKEYS.TRAVEL_PROVISIONING, {canBeMissing: true});
    const {isBetaEnabled} = usePermissions();
    const isUserValidated = account?.validated ?? false;
    ...
    const handleClose = useCallback(() => {
        if (isUserValidated) {
            requestTravelAccess();
        }
        Navigation.goBack(backTo);
    }, [backTo, isUserValidated]);
    ...
}

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022006670805403073426

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[nyomanjyotisa]

🚨 Edited by proposal-police: This proposal was edited at 2026-01-01 11:18:22 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Travel - User without verification can trigger "Request Sent" state on Travel page

What is the root cause of that problem?

handleClose calls requestTravelAccess when the user navigates back

App/src/pages/Travel/VerifyAccountPage.tsx

Lines 32 to 35 in 66de3d6

	const handleClose = useCallback(() => {
	requestTravelAccess();
	Navigation.goBack(backTo);
	}, [backTo]);

This sets lastTravelSignupRequestTime which then causes getTravelStep to return the REVIEWING_REQUEST step

App/src/libs/PolicyUtils.ts

Lines 1685 to 1686 in 66de3d6

	if (!isTravelVerifiedBetaEnabled && travelSettings?.lastTravelSignupRequestTime) {
	return CONST.TRAVEL.STEPS.REVIEWING_REQUEST;

The request should only be sent when the user is validated and clicks the button, which is already handled in BookTravelButton

App/src/components/BookTravelButton.tsx

Lines 128 to 130 in 66de3d6

	if (!travelSettings?.lastTravelSignupRequestTime) {
	requestTravelAccess();
	}

What changes do you think we should make in order to solve the problem?

Remove the requestTravelAccess call from handleClose. If the user verifies, VerifyAccountPageBase navigates forward (handled by its useEffect). If the user goes back without verifying, we should not set the request time

    const handleClose = useCallback(() => {
        Navigation.goBack(backTo);
    }, [backTo]);

App/src/pages/Travel/VerifyAccountPage.tsx

Lines 32 to 35 in 66de3d6

	const handleClose = useCallback(() => {
	requestTravelAccess();
	Navigation.goBack(backTo);
	}, [backTo]);

Then we can add a useEffect that watches for successful verification and sends the request when the user becomes validated (only when the beta is disabled)

    const [account] = useOnyx(ONYXKEYS.ACCOUNT, {canBeMissing: true});
    const [travelSettings] = useOnyx(ONYXKEYS.NVP_TRAVEL_SETTINGS, {canBeMissing: true});
    const isUserValidated = account?.validated ?? false;

    useEffect(() => {
        if (!isTravelVerifiedBetaEnabled && isUserValidated && !travelSettings?.lastTravelSignupRequestTime) {
            requestTravelAccess();
        }
    }, [isTravelVerifiedBetaEnabled, isUserValidated, travelSettings?.lastTravelSignupRequestTime]);

What alternative solutions did you explore? (Optional)

We could check isUserValidated in handleClose before calling requestTravelAccess