[Due for payment 2025-12-30] [$250] Expense header shows wrong amount after dismissing distance rate error

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.78-7
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from BrowserStack:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @QichenZhu
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

Precondition: have a workspace with at least two distance rates

1. Go to the workspace chat
2. Create two manual distance expenses and select a non-default rate for both
3. Go to workspace settings and delete the rate selected in step 2
4. Open one of the expenses
5. Update the amount
6. Verify the new amount appears in the header
7. Update the distance
8. Dismiss "The selected rate has been deleted" error
9. Close the expense and open it again

Expected Result:

The header amount shows the new amount in both step 8 and step 9

Actual Result:

1. After step 8, the header amount reverts to the original amount
2. After reopening the expense in step 9, the header shows the new amount

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

nab.mov

Recording.2082.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022001074938606151109
• Upwork Job ID: 2001074938606151109
• Last Price Increase: 2025-12-16
• Automatic offers:
• abzokhattab | Reviewer | 109851344
• daledah | Contributor | 109851347

Issue Owner

Current Issue Owner: @brianlee-expensify

[melvin-bot]

Triggered auto assignment to @brianlee-expensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After step 8, the header amount reverts to the original amount
After reopening the expense in step 9, the header shows the new amount

What is the root cause of that problem?

The code treated all errors the same when dismissing them, without distinguishing between:

• Informational errors (route/waypoint errors like "the selected rate has been deleted")
• Transaction errors that require reverting (e.g., receipt errors)

App/src/components/ReportActionItem/MoneyRequestReceiptView.tsx

Lines 230 to 234 in 87d56e3

	if (!isEmptyObject(errorsWithoutReportCreation)) {
	revert(transaction, getLastModifiedExpense(report?.reportID));
	clearError(transaction.transactionID);
	clearAllRelatedReportActionErrors(report.reportID, parentReportAction);
	}

What changes do you think we should make in order to solve the problem?

Separate route/waypoint errors from transaction/report action errors:

• Only revert if there are actual transaction/report action errors
• Clear route/waypoint errors without reverting

This preserves user updates when dismissing informational errors while still reverting when appropriate.

    const transactionAndReportActionErrors = useMemo(
        () => ({
            ...transaction?.errors,
            ...parentReportAction?.errors,
        }),
        [transaction?.errors, parentReportAction?.errors],
    );

        if (!isEmptyObject(transactionAndReportActionErrors)) {
            revert(transaction, getLastModifiedExpense(report?.reportID));
        }
        if (!isEmptyObject(errorsWithoutReportCreation)) {
            clearError(transaction.transactionID);
            clearAllRelatedReportActionErrors(report.reportID, parentReportAction);
        }

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022001074938606151109

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abzokhattab (External)

[abzokhattab]

Thanks @daledah the core logic you proposed here looks good to me!

🎀 👀 🎀 C+ reviewed