[$250] Company cards - Unable to select default vendor bills export

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.78-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176706/test-cases/41236847
Email or phone of affected tester (no customers): applausetester+ccardfeed@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: macOS Tahoe
App Component: Workspace Settings

Action Performed:

1. Navigate to staging.new.expensify.com
2. Sign in with applausetester+ccardfeed@applause.expensifail.com
3. Navigate to the workspace named Company Cards tests - DO NOT DELETE
4. Navigate to accounting and connect with Intacct
5. Navigate to company cards settings
6. Click on one of the assigned cards
7. Click on Sage Intacct vendor bills export > Click on Default vendor
   If Vendor bill is not selected as the default option follow the following steps first:
8. Click on export option hyperlink found on the description
9. Click on Export company card expenses as
10. Click on Export as > Select Vendor bills
11. Click on Default vendor and select any company

Expected Result:

At step 7, the default vendor option should be selected and filled with the default value set inside the settings.

Actual Result:

At step 7, the Sage Intacct vendor bills export value holds an empty value.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022008202546374605836
• Upwork Job ID: 2008202546374605836
• Last Price Increase: 2026-01-05
• Automatic offers:
• daledah | Contributor | 110013631

Issue Owner

Current Issue Owner: @stitesExpensify

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

At step 7, the Sage Intacct vendor bills export value holds an empty value.

What is the root cause of that problem?

In WorkspaceCompanyCardAccountSelectCardPage, the selection handler only treated the “Default card” label as a default.

App/src/pages/workspace/companyCards/WorkspaceCompanyCardAccountSelectCardPage.tsx

Lines 82 to 84 in 16c0abf

	const isDefaultCardSelected = value === defaultCard;
	const exportValue = isDefaultCardSelected ? CONST.COMPANY_CARDS.DEFAULT_EXPORT_TYPE : value;
	setCompanyCardExportAccount(policyID, domainOrWorkspaceAccountID, cardID, exportMenuItem.exportType, exportValue, getCompanyCardFeed(bank));

What changes do you think we should make in order to solve the problem?

We shoud add a defaultVendor label using translate('workspace.accounting.defaultVendor') and updated the default-selection check to treat both Default card and Default vendor as defaults:

const defaultCard = translate('workspace.moreFeatures.companyCards.defaultCard');
const defaultVendor = translate('workspace.accounting.defaultVendor');
...
const isDefaultCardSelected = value === defaultCard || value === defaultVendor;

App/src/pages/workspace/companyCards/WorkspaceCompanyCardAccountSelectCardPage.tsx

Lines 82 to 84 in 16c0abf

	const isDefaultCardSelected = value === defaultCard;
	const exportValue = isDefaultCardSelected ? CONST.COMPANY_CARDS.DEFAULT_EXPORT_TYPE : value;
	setCompanyCardExportAccount(policyID, domainOrWorkspaceAccountID, cardID, exportMenuItem.exportType, exportValue, getCompanyCardFeed(bank));

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[lorretheboy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Company cards - Unable to select default vendor bills export

What is the root cause of that problem?

Issue 1: Selection Issue

We only check default card value here --> The default vendor is not working

App/src/pages/workspace/companyCards/WorkspaceCompanyCardAccountSelectCardPage.tsx

Lines 77 to 89 in 909c8cd

	const updateExportAccount = useCallback(
	({value}: SelectorType) => {
	if (!exportMenuItem?.exportType) {
	return;
	}
	const isDefaultCardSelected = value === defaultCard;
	const exportValue = isDefaultCardSelected ? CONST.COMPANY_CARDS.DEFAULT_EXPORT_TYPE : value;
	setCompanyCardExportAccount(policyID, domainOrWorkspaceAccountID, cardID, exportMenuItem.exportType, exportValue, getCompanyCardFeed(bank));
	Navigation.goBack(ROUTES.WORKSPACE_COMPANY_CARD_DETAILS.getRoute(policyID, cardID, bank));
	},
	[exportMenuItem?.exportType, domainOrWorkspaceAccountID, cardID, policyID, bank, defaultCard],
	);

Issue 2: Display Issue
When isDefaultTitle was true, the code was showing the translated string "Default vendor" instead of looking up and displaying the actual vendor name from the vendor list.

App/src/pages/workspace/companyCards/utils.tsx

Line 248 in fa5e06d

title = isDefaultTitle ? defaultVendor : selectedVendor?.value;

What changes do you think we should make in order to solve the problem?

1. We should check default vendor value as well here

    const defaultVendor = translate('workspace.accounting.defaultVendor');
...
    const isDefaultCardSelected = value === defaultCard || value === defaultVendor;

App/src/pages/workspace/companyCards/WorkspaceCompanyCardAccountSelectCardPage.tsx

Line 82 in 909c8cd

const isDefaultCardSelected = value === defaultCard;

2. We need to make sure that it displays correct default vendor value

                    const defaultVendorName = getDefaultVendorName(defaultAccount, vendors);
                    title = isDefaultTitle ? defaultVendorName : selectedVendor?.value;

App/src/pages/workspace/companyCards/utils.tsx

Line 248 in fa5e06d

title = isDefaultTitle ? defaultVendor : selectedVendor?.value;

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@johncschuster Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@johncschuster 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

@johncschuster Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[melvin-bot]

@johncschuster 10 days overdue. Is anyone even seeing these? Hello?

[melvin-bot]

@johncschuster this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

This issue has not been updated in over 14 days. @johncschuster eroding to Weekly issue.