[HOLD for payment 2022-04-13] When [Attachment] is sent as the message, 'Edit Comment' option does not appear in contextMenu - reported by @sobitneupane

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Navigate to any chat
2. Send message [Attachment].
3. Hover over the message for context menu.

Expected Result:

Edit option should display

Actual Result:

Edit Option does not appear in contextMenu.

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.38-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Upwork job URL: https://www.upwork.com/jobs/~01555eaa1328846469
Issue reported by: @sobitneupane
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1643885274749229

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @laurenreidexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[sobitneupane]

PROPOSAL
Reason:
Message Text is being compared to '[Attachment]' to decide whether the message is editable or not.

App/src/libs/reportUtils.js

Lines 31 to 33 in fd24e0d

	function isReportMessageAttachment(reportMessageText) {
	return reportMessageText === '[Attachment]';
	}

Solution:
Use Message HTML instead of Message Text to decide whether the message is editable or not.

function isReportMessageAttachment(reportMessageHtml, reportMessageText) {
    console.log('debug1', reportMessageHtml);
    return (/<img([^>]+)\/>/gi.test(reportMessageHtml) || /<a/gi.test(reportMessageHtml)) && reportMessageText === '[Attachment]';
}

[laurenreidexpensify]

@sobitneupane can you confirm if this happening only on Web app or across all platforms

[sobitneupane]

@laurenreidexpensify Issue exists across all platforms.

[MelvinBot]

Triggered auto assignment to @Gonals (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.