Problem
In this PR we moved a bunch of functions to a ReportNameUtils file, made some modifications to make them pure functions and we marked the original source functions from ReportUtils as deprecated.
We did that as part of this issue Refactor getReportName to prepare for formula computation which was the first step of this larger refactor - [HOLD 72613] Refactor optimistic custom report names to use Onyx derived values
Overall we didn't get too far before deciding to abandon this approach due to low ROI. Now we need to clean up the code.
Solution
Remove the deprecated functions. We might also want to rename the function computeReportName in ReportNameUtils to computeReportNameWithoutFormula or something similar to make its use more clear.
Issue Owner
Current Issue Owner: @eVoloshchak
Problem
In this PR we moved a bunch of functions to a ReportNameUtils file, made some modifications to make them pure functions and we marked the original source functions from ReportUtils as deprecated.
We did that as part of this issue Refactor getReportName to prepare for formula computation which was the first step of this larger refactor - [HOLD 72613] Refactor optimistic custom report names to use Onyx derived values
Overall we didn't get too far before deciding to abandon this approach due to low ROI. Now we need to clean up the code.
Solution
Remove the deprecated functions. We might also want to rename the function
computeReportNamein ReportNameUtils to computeReportNameWithoutFormula or something similar to make its use more clear.Issue Owner
Current Issue Owner: @eVoloshchak