Reports - Submit button appears when the expense is rejected

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.72-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #74541
Email or phone of affected tester (no customers): siodjosidjosjosjisjd@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 26.1 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Create an expense.
4. Click Submit.
5. Go to Reports > Reports.
6. Select the report via checkbox.
7. Click dropdown button > Reject.
8. Enter reason and click Reject expense.
   → Submit button is shown.
9. Open the rejected report.
10. Click More.
    → Submit button is hidden when expense is rejected.

Expected Result:

In Step 8, Submit button should not appear because the expense is rejected and pending for "mark as resolved".

Actual Result:

In Step 8, Submit button appears when the expense is rejected.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[cretadn22]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The Submit button is shown when an expense has already been rejected.

What is the root cause of that problem?

On the Search page, we don’t handle the logic to show the MARK_AS_RESOLVED action or hide the Submit button when the report is waiting to be marked as resolved.

What changes do you think we should make in order to solve the problem?

Show the MARK_AS_RESOLVED action instead of the Submit button.

Add this block in getActions before adding the Submit action:

if (isExpenseReport(report) && isMarkAsResolvedAction(report, transactionViolations, policy)) {
    allActions.push(CONST.SEARCH.PRIMARY_ACTIONS.MARK_AS_RESOLVED);
}

What alternative solutions did you explore? (Optional)

Hide the Submit button. In canSubmitReport, apply the same logic so it returns false when it’s an expense report and isMarkAsResolvedAction returns true.

[Julesssss]

Likely introduced with these changes