[Due for payment 2026-03-02] [$250] GBR briefly reappears on LHN when approver leave workspace

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.59-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: n/a
Email or phone of affected tester (no customers): gocemate+b2155426@gmail.com
Issue reported by: Applause Internal Team
Device used: Lenovo 80ES / Windows 10 Pro
App Component: Left Hand Navigation (LHN)

Action Performed:

Precondition: Owner create workspace and invite employee and approver. Submission frequency in Workflows needs to be disabled

1. Employee submits 2 expenses in workspace chat
2. Approver approve the expenses
3. Approver navigates to workspaces> leave the workspace
4. Approver navigates back to inbox

Expected Result:

Green dot should not appear on workspace chat

Actual Result:

Green dot appears briefly when approver leaves the workspace

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug7006306_1763379661852.Recording__6825.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021991222255923911951
• Upwork Job ID: 1991222255923911951
• Last Price Increase: 2025-11-26

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021991222255923911951

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)

[imadirtydog]

Proposal

Please re-state the problem that we are trying to solve in this issue.

GBR briefly reappears on LHN when approver leave workspace.

What is the root cause of that problem?

The brick road status is gotten from reportAttributes createOnyxDerivedValueConfig

requiresAttention tag is briefly true when we first click back on the inbox, because shouldShowSettlementButton resolves to true

App/src/libs/actions/IOU.ts

Line 10303 in 1d0ce34

const shouldShowSettlementButton = canIOUBePaid(iouReport, chatReport, policy) || canApproveIOU(iouReport, policy);

It happens because when you leave the workspace, you don't actually touch the iou reports, and so the managerId is equal still temporarily to the approved id.

What changes do you think we should make in order to solve the problem?

We can modify the canApproveIOU

App/src/libs/actions/IOU.ts

Line 10153 in 1d0ce34

function canApproveIOU(iouReport: OnyxTypes.OnyxInputOrEntry<OnyxTypes.Report>, policy: OnyxTypes.OnyxInputOrEntry<OnyxTypes.Policy>, iouTransactions?: OnyxTypes.Transaction[]) {

and canIOUBePaid

App/src/libs/actions/IOU.ts

Line 10153 in 1d0ce34

function canApproveIOU(iouReport: OnyxTypes.OnyxInputOrEntry<OnyxTypes.Report>, policy: OnyxTypes.OnyxInputOrEntry<OnyxTypes.Policy>, iouTransactions?: OnyxTypes.Transaction[]) {

to basically leave early if the policy is not there. Note it is a bit more tricky for canIOUBePaid as it can also be used outside of workspace context.

function canApproveIOU(iouReport: OnyxTypes.OnyxInputOrEntry<OnyxTypes.Report>, policy: OnyxTypes.OnyxInputOrEntry<OnyxTypes.Policy>, iouTransactions?: OnyxTypes.Transaction[]) {
    // Only expense reports can be approved
    if (!isExpenseReport(iouReport) || !(policy && isPaidGroupPolicy(policy))) {
        return false;
    }
    const currentUserLogin = getLoginByAccountID(userAccountID);
    if (!isPolicyMember(policy, currentUserLogin)) {
        return false;
    }
    const isOnSubmitAndClosePolicy = isSubmitAndClose(policy);
    if (isOnSubmitAndClosePolicy) {
        return false;
    }

function canIOUBePaid(
    iouReport: OnyxTypes.OnyxInputOrEntry<OnyxTypes.Report>,
    chatReport: OnyxTypes.OnyxInputOrEntry<OnyxTypes.Report>,
    policy: OnyxTypes.OnyxInputOrEntry<OnyxTypes.Policy>,
    transactions?: OnyxTypes.Transaction[],
    onlyShowPayElsewhere = false,
    chatReportRNVP?: OnyxTypes.ReportNameValuePairs,
    invoiceReceiverPolicy?: OnyxTypes.Policy,
    shouldCheckApprovedState = true,
) {
    const reportNameValuePairs = chatReportRNVP ?? allReportNameValuePairs?.[`${ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS}${chatReport?.reportID}`];
    const isChatReportArchived = isArchivedReport(reportNameValuePairs);
    const iouSettled = isSettled(iouReport);

    if (isEmptyObject(iouReport)) {
        return false;
    }
    const currentUserLogin = getLoginByAccountID(userAccountID);
    if (isExpenseReport(iouReport)) {
        if (!policy) {
            return false;
        }

        if (!isPolicyMember(policy, currentUserLogin)) {
            return false;
        }
    }

What alternative solutions did you explore? (Optional)

N/A

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.