[Due for payment 2025-12-03] [$125] Chat - "Default to Billable" and "Default to non-billable" text is briefly translated

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.2.59-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #65320
Email or phone of affected tester (no customers): Slottwo1 l@gmail.com
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13
App Component: Workspace Settings

Action Performed:

Pre-condition: For example: Set Language to French

1. Go to https://staging.new.expensify.com/home
2. Go to workspace settings - more features - Enable Rules
3. Tap Rules
4. Tap Billable default
5. Set to Billable
6. Go to workspace chat
7. Create an expense
8. Toggle on and off Billable toggle

Expected Result:

"Default to Billable" and "Default to non-billable" text musn't be translated briefly in system message in expense details page.

Actual Result:

"Default to Billable" and "Default to non-billable" text is translated briefly in system message in expense details page.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021990469418021952154
• Upwork Job ID: 1990469418021952154
• Last Price Increase: 2025-11-19

Issue Owner

Current Issue Owner: @joekaufmanexpensify

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - "Default to Billable" and "Default to non-billable" text is briefly translated

What is the root cause of that problem?

• oldDefaultBillable and newDefaultBillable are not translated.
  

  App/src/libs/ReportActionsUtils.ts

  Lines 2888 to 2900 in 5ddaed5

  	function getPolicyChangeLogDefaultBillableMessage(action: ReportAction): string {
  	const {oldDefaultBillable, newDefaultBillable} = getOriginalMessage(action as ReportAction<typeof CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.UPDATE_DEFAULT_BILLABLE>) ?? {};
  	if (typeof oldDefaultBillable === 'string' && typeof newDefaultBillable === 'string') {
  	// eslint-disable-next-line @typescript-eslint/no-deprecated
  	return translateLocal('workspaceActions.updateDefaultBillable', {
  	oldValue: oldDefaultBillable,
  	newValue: newDefaultBillable,
  	});
  	}
  	return getReportActionText(action);
  	}

What changes do you think we should make in order to solve the problem?

• Add translations for oldDefaultBillable and newDefaultBillable and pass the translated values.
• We would need to check the expected values for oldDefaultBillable and newDefaultBillable and create translations based on that.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Result

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Billable update system message old and new value is briefly translated.

What is the root cause of that problem?

When building the optimistic action, we translate the old and new value.

App/src/libs/ReportUtils.ts

Lines 5327 to 5332 in 5ddaed5

	if ('billable' in transactionChanges) {
	const oldBillable = getBillable(oldTransaction);
	// eslint-disable-next-line @typescript-eslint/no-deprecated
	originalMessage.oldBillable = oldBillable ? translateLocal('common.billable').toLowerCase() : translateLocal('common.nonBillable').toLowerCase();
	// eslint-disable-next-line @typescript-eslint/no-deprecated
	originalMessage.billable = transactionChanges?.billable ? translateLocal('common.billable').toLowerCase() : translateLocal('common.nonBillable').toLowerCase();

But after receiving the value from the BE, it's not translated (which is expected). And we just show the old and new value as it is.

App/src/libs/ModifiedExpenseMessage.ts

Lines 358 to 362 in 5ddaed5

	const hasModifiedBillable = isReportActionOriginalMessageAnObject && 'oldBillable' in reportActionOriginalMessage && 'billable' in reportActionOriginalMessage;
	if (hasModifiedBillable) {
	buildMessageFragmentForValue(
	reportActionOriginalMessage?.billable ?? '',
	reportActionOriginalMessage?.oldBillable ?? '',

This happens to Reimbursable field too.

What changes do you think we should make in order to solve the problem?

First, no need to translate the old and new value here.

App/src/libs/ReportUtils.ts

Lines 5327 to 5332 in 5ddaed5

	if ('billable' in transactionChanges) {
	const oldBillable = getBillable(oldTransaction);
	// eslint-disable-next-line @typescript-eslint/no-deprecated
	originalMessage.oldBillable = oldBillable ? translateLocal('common.billable').toLowerCase() : translateLocal('common.nonBillable').toLowerCase();
	// eslint-disable-next-line @typescript-eslint/no-deprecated
	originalMessage.billable = transactionChanges?.billable ? translateLocal('common.billable').toLowerCase() : translateLocal('common.nonBillable').toLowerCase();

Then, translate the old and new value here.

App/src/libs/ModifiedExpenseMessage.ts

Lines 358 to 362 in 5ddaed5

	const hasModifiedBillable = isReportActionOriginalMessageAnObject && 'oldBillable' in reportActionOriginalMessage && 'billable' in reportActionOriginalMessage;
	if (hasModifiedBillable) {
	buildMessageFragmentForValue(
	reportActionOriginalMessage?.billable ?? '',
	reportActionOriginalMessage?.oldBillable ?? '',

const oldBillable = reportActionOriginalMessage?.oldBillable === "billable" ? translateLocal("common.billable").toLowerCase() : translateLocal("common.nonBillable").toLowerCase();
const newBillable = reportActionOriginalMessage?.billable === "billable" ? translateLocal("common.billable").toLowerCase() : translateLocal("common.nonBillable").toLowerCase();
buildMessageFragmentForValue(
    newBillable,
    oldBillable,

Do the same for the Reimbursable field.

[joekaufmanexpensify]

Not sure why @trjExpensify is assigned here too, but going to remove you for now Tom as IDT this needs 2 BZ. LMK if there is any context on that though 👍

[joekaufmanexpensify]

Agreed with the bug though. Billable and non-billable are translated elsewhere, so they should be in the expense comments too 👍

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021990469418021952154