[Due for payment 2026-02-04] Video - Video player shows NaN:NaN when playing video full screen while uploading

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.59-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #66793
Email or phone of affected tester (no customers): jnsonijsoidjsiosjios@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Chat Report View

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Create an expense.
4. Open the expense report.
5. Click + > Add attachment.
6. Upload a video.
7. Click Send.
8. While the video is uploading, click play button and click full screen.
9. Wait for video control to show up.

Expected Result:

Video player will not show NaN:NaN.

Actual Result:

Video player shows NaN:NaN when playing video full screen while uploading.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @Guccio163

[melvin-bot]

Triggered auto assignment to @lydiabarclay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @lakchote (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Video player shows NaN:NaN when playing video full screen while uploading

What is the root cause of that problem?

When a video is uploading, the duration may be 0 or undefined, and when passed to convertSecondsToTime, it can produce "NaN:NaN" when Math.floor operations are performed on invalid numbers. We pass duration ?? 0 to VideoPlayerControls and currentTime ?? 0 for position. However, if duration is 0 (which happens during upload before the video metadata is loaded), and currentTime might also have issues, the convertSecondsToTime function will produce "NaN:NaN".

What changes do you think we should make in order to solve the problem?

We should add

if (!Number.isFinite(secondsTotal) || secondsTotal < 0) {
    return '0:00';
}

in convertSecondsToTime to handle invalid values

here

App/src/components/VideoPlayer/utils.ts

Lines 3 to 9 in 89d3ca3

	/**
	* Converts seconds to '[hours:]minutes:seconds' format
	*/
	function convertSecondsToTime(secondsTotal: number) {
	const hours = Math.floor(secondsTotal / 3600);
	const minutes = Math.floor((secondsTotal / 60) % 60);
	const seconds = Math.floor(secondsTotal % 60)

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.