[Due for payment 2025-12-25] [$250] Report - Expenses moved to Self DM, display a "Join" button on top of report.

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.49-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-1935/folder/13176670/41237109/1008201782
Email or phone of affected tester (no customers): ibellicotest+2049@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 / Android 12 / Chrome ( mWeb / Hybrid app) - Windows 11 / Chrome
App Component: Money Requests

Action Performed:

1. Open the Expensify app.
2. Sign up with a new account.
3. Complete onboarding selecting "Track and budget expenses" option.
4. Once redirected to "Inbox" create a new workspace.
5. Navigate to workspace chat.
6. Create two manual expenses.
7. Open the report of the just created expenses.
8. Tap on "More" and delete the report.
9. Navigate to Self DM.
10. Open one of the just moved expenses.
11. Note that a "Join" button is displayed on top of report.

Expected Result:

Only a "More" button should be visible on top of expense report, after being moved to Self DM.

Actual Result:

After deleting a report with more than one expense, a "Join" button appears on top of the report of the expenses that were moved to Self DM.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug7000826_1762883203780.Join.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021990808453495904025
• Upwork Job ID: 1990808453495904025
• Last Price Increase: 2025-11-18

Issue Owner

Current Issue Owner: @nkdengineer

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Report - Expenses moved to Self DM, display a "Join" button on top of report

What is the root cause of that problem?

When expenses are moved to Self DM after deleting a report, transaction thread reports (child reports) are created. In canJoinChat, we use isSelfDM(report) which only checks if the report itself is a Self DM, not if it's a thread whose parent is a Self DM. For transaction thread reports that are children of Self DM, isSelfDM(report) returns false, so the Join button displayed

App/src/libs/ReportUtils.ts

Line 10650 in 48f5093

if (isRootGroupChat(report, isReportArchived) || isSelfDM(report) || isInvoiceRoom(report) || isSystemChat(report) || isExpenseChat) {

What changes do you think we should make in order to solve the problem?

Replace isSelfDM(report) with isSelfDMOrSelfDMThread(report) to checks if the report is a Self DM or if it's a thread whose parent is a Self DM

    if (isRootGroupChat(report, isReportArchived) || isSelfDMOrSelfDMThread(report) || isInvoiceRoom(report) || isSystemChat(report) || isExpenseChat) {

App/src/libs/ReportUtils.ts

Line 10650 in 48f5093

if (isRootGroupChat(report, isReportArchived) || isSelfDM(report) || isInvoiceRoom(report) || isSystemChat(report) || isExpenseChat) {

What alternative solutions did you explore? (Optional)

None

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After deleting a report with more than one expense, a "Join" button appears on top of the report of the expenses that were moved to Self DM.

What is the root cause of that problem?

When we select Track and budget expenses option, we create a selfDM in optimistic data but the CompleteGuidedSetup API doesn't create the selfDM report from the backend side. We can open the optimistic selfDM report after completing the onboarding, the OpenReport will return report not found error.

App/src/libs/ReportUtils.ts

Line 11516 in 82a45ab

if (engagementChoice === CONST.ONBOARDING_CHOICES.PERSONAL_SPEND || engagementChoice === CONST.ONBOARDING_CHOICES.TRACK_WORKSPACE) {

Then when the expense report is deleted, the backend create another selfDM report

App/src/libs/actions/Report.ts

Line 5092 in 48f5093

const parameters: DeleteAppReportParams = {

Which causes the isTrackExpenseReport check return false

App/src/libs/ReportUtils.ts

Line 10648 in 48f5093

const isExpenseChat = isMoneyRequestReport(report) || isMoneyRequest(report) || isInvoiceReport(report) || isTrackExpenseReport(report);

Because findSelfDMReportID return the optimistic selfDM while report.parentReportID is the selfDM report from the backend.

App/src/libs/ReportUtils.ts

Lines 2390 to 2397 in 48f5093

	function isTrackExpenseReport(report: OnyxInputOrEntry<Report>): boolean {
	if (isThread(report)) {
	const selfDMReportID = findSelfDMReportID();
	const parentReportAction = allReportActions?.[`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report.parentReportID}`]?.[report.parentReportActionID];
	return !isEmptyObject(parentReportAction) && selfDMReportID === report.parentReportID && isTrackExpenseAction(parentReportAction);
	}
	return false;
	}

What changes do you think we should make in order to solve the problem?

If it's expected that the selfDM is not created from the backend in the onboarding flow anymore, we can remove the optimistic data here. We can only remove engagementChoice === CONST.ONBOARDING_CHOICES.TRACK_WORKSPACE if we only want to do this for CONST.ONBOARDING_CHOICES.TRACK_WORKSPACE choice

App/src/libs/ReportUtils.ts

Line 11516 in 82a45ab

if (engagementChoice === CONST.ONBOARDING_CHOICES.PERSONAL_SPEND || engagementChoice === CONST.ONBOARDING_CHOICES.TRACK_WORKSPACE) {

What alternative solutions did you explore? (Optional)

We can improve isTrackExpenseReport check by checking the parent report is selfDM report or not instead of checking selfDMReportID === report.parentReportID

if (isThread(report)) {
        const parentReport = getParentReport(report);
        const parentReportAction = allReportActions?.[`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report.parentReportID}`]?.[report.parentReportActionID];
        return !isEmptyObject(parentReportAction) && isSelfDM(parentReport) && isTrackExpenseAction(parentReportAction);
    }

App/src/libs/ReportUtils.ts

Lines 2390 to 2397 in 48f5093

	function isTrackExpenseReport(report: OnyxInputOrEntry<Report>): boolean {
	if (isThread(report)) {
	const selfDMReportID = findSelfDMReportID();
	const parentReportAction = allReportActions?.[`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report.parentReportID}`]?.[report.parentReportActionID];
	return !isEmptyObject(parentReportAction) && selfDMReportID === report.parentReportID && isTrackExpenseAction(parentReportAction);
	}
	return false;
	}

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021990808453495904025

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Krishna2323 (External)