[Due for payment 2025-11-28] [$250] Per Diem search does not include subrate name

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.49-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @twisterdotcom
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

1. Upload Per Diem rates to a workspace
2. Go to the Per Diem section
3. Attempt to search for a rate using the subrate name

Expected Result:

Search should return results matching subrate names

Actual Result:

No results found matching "Subrate" displayed

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

perDiem.Search.mp4

Recording.1909.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021990294632971195715
• Upwork Job ID: 1990294632971195715
• Last Price Increase: 2025-11-17

Issue Owner

Current Issue Owner: @kadiealexander

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Eskalifer1]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Per Diem search does not include subrate name

What is the root cause of that problem?

Here is the function of filter:

App/src/pages/workspace/perDiem/WorkspacePerDiemPage.tsx

Lines 192 to 195 in ff5108f

	const filterRate = useCallback((rate: PolicyOption, searchInput: string) => {
	const results = tokenizedSearch([rate], searchInput, (option) => [option.text ?? '']);
	return results.length > 0;
	}, []);

We onlyc include name(text) here

What changes do you think we should make in order to solve the problem?

We should also inlcude subRate and maybe other fields that we need:

const results = tokenizedSearch([rate], searchInput, (option) => {
            return [option.text ?? '', option.subRateName];
        });

PS: maybe we already have function for that

And add this value here:

App/src/pages/workspace/perDiem/WorkspacePerDiemPage.tsx

Lines 156 to 190 in ff5108f

	const subRatesList = useMemo<PolicyOption[]>(
	() =>
	allSubRates.map((value) => {
	const isDisabled = value.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE;
	return {
	text: value.destination,
	subRateID: value.subRateID,
	rateID: value.rateID,
	keyForList: value.subRateID,
	isDisabled,
	pendingAction: value.pendingAction,
	rightElement: (
	<>
	<View style={styles.flex2}>
	<Text
	numberOfLines={1}
	style={[styles.alignItemsStart, styles.textSupporting, styles.label, styles.pl2]}
	>
	{value.subRateName}
	</Text>
	</View>
	<View style={styles.flex2}>
	<Text
	numberOfLines={1}
	style={[styles.alignSelfEnd, styles.textSupporting, styles.pl2, styles.label]}
	>
	{convertAmountToDisplayString(value.rate, value.currency)}
	</Text>
	</View>
	</>
	),
	};
	}),
	[allSubRates, styles.flex2, styles.alignItemsStart, styles.textSupporting, styles.label, styles.pl2, styles.alignSelfEnd],
	);

subRateName: value.subRateName,

We should also adjust types for that here:

App/src/pages/workspace/perDiem/WorkspacePerDiemPage.tsx

Lines 53 to 59 in ff5108f

	type PolicyOption = ListItem & {
	/** subRateID is used as a key for identification of the entry */
	subRateID: string;
	/** rateID is used as a key for identification of the entry */
	rateID: string;
	};

As i mentioned before we can add any other value, like amount or other

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@kadiealexander Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021990294632971195715

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)