[Due for payment 2025-12-19] [$250] Add BA - When accept terms offline and go online, "You must accept terms" error shown

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.48-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176691/test-cases/41236745
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: MacBook Air 15.6.1 Chrome, iPhone 15 iOS 26.0.1
App Component: Other

Action Performed:

1. Sign up to ND with a new gmail account, verify it
2. Create a workspace, open Workflows, tap "Add bank account"
3. Select "Log into your bank", Wells Fargo 1111 bank account
4. Proceed with the flow until final confirmation page "Please confirm the agreements below"
5. Go offline and accept all the terms
6. Go back online - the checkmarks are presented, tap "Save&Continue" button

Expected Result:

The successful modal is displayed after accepting all the terms

Actual Result:

"You must accept the terms" error is shown online when the terms were accepted offline and the checkmarks are presented

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021991092758012921430
• Upwork Job ID: 1991092758012921430
• Last Price Increase: 2025-11-19
• Automatic offers:
• samranahm | Contributor | 109593799

Issue Owner

Current Issue Owner: @dylanexpensify

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Add BA - When accept terms offline and go online, "You must accept terms" error shown

What is the root cause of that problem?

The form reading default values from reimbursementAccount?.achData instead of checking draft values first.

• User goes offline > checks boxes > saved to draft
• User goes online > form reads from reimbursementAccount?.achData (still false) instead of draft (now true)
• Validation fails > "You must accept terms" error

What changes do you think we should make in order to solve the problem?

We should changed to use getSubStepValues() which checks draft values first, then falls back to reimbursementAccount?.achData.
here

App/src/pages/ReimbursementAccount/USD/CompleteVerification/subSteps/ConfirmAgreements.tsx

Lines 44 to 48 in 73a784d

	const defaultValues = {
	isAuthorizedToUseBankAccount: reimbursementAccount?.achData?.isAuthorizedToUseBankAccount ?? false,
	certifyTrueInformation: reimbursementAccount?.achData?.certifyTrueInformation ?? false,
	acceptTermsAndConditions: reimbursementAccount?.achData?.acceptTermsAndConditions ?? false,
	};

const [reimbursementAccountDraft] = useOnyx(ONYXKEYS.FORMS.REIMBURSEMENT_ACCOUNT_FORM_DRAFT, {canBeMissing: true});
const values = useMemo(() => getSubStepValues(COMPLETE_VERIFICATION_KEYS, reimbursementAccountDraft, reimbursementAccount), [reimbursementAccount, reimbursementAccountDraft]);
const defaultValues = {
    isAuthorizedToUseBankAccount: values.isAuthorizedToUseBankAccount ?? false,
    certifyTrueInformation: values.certifyTrueInformation ?? false,
    acceptTermsAndConditions: values.acceptTermsAndConditions ?? false,
};

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"You must accept the terms" error is shown online when the terms were accepted offline and the checkmarks are presented

What is the root cause of that problem?

We only save the check box state in reimbursementAccountDraft => when ther user go online again => all default values will be false

App/src/pages/ReimbursementAccount/USD/CompleteVerification/subSteps/ConfirmAgreements.tsx

Lines 44 to 48 in 73a784d

	const defaultValues = {
	isAuthorizedToUseBankAccount: reimbursementAccount?.achData?.isAuthorizedToUseBankAccount ?? false,
	certifyTrueInformation: reimbursementAccount?.achData?.certifyTrueInformation ?? false,
	acceptTermsAndConditions: reimbursementAccount?.achData?.acceptTermsAndConditions ?? false,
	};

What changes do you think we should make in order to solve the problem?

We should update it to use reimbursementAccountDraft instead of reimbursementAccount (or we can add reimbursementAccountDraft data as the fallback of reimbursementAccount data) like we did in confirmationBusiness step here

App/src/pages/ReimbursementAccount/USD/BusinessInfo/subSteps/ConfirmationBusiness.tsx

Line 60 in 3cb2fe3

const defaultCheckboxState = reimbursementAccountDraft?.[BUSINESS_INFO_STEP_KEYS.HAS_NO_CONNECTION_TO_CANNABIS] ?? false;

    const [reimbursementAccountDraft] = useOnyx(ONYXKEYS.FORMS.REIMBURSEMENT_ACCOUNT_FORM_DRAFT, {canBeMissing: true});
    ...
    const defaultValues = {
        isAuthorizedToUseBankAccount: reimbursementAccountDraft?.[COMPLETE_VERIFICATION_KEYS.IS_AUTHORIZED_TO_USE_BANK_ACCOUNT] ?? false,
        certifyTrueInformation: reimbursementAccountDraft?.[COMPLETE_VERIFICATION_KEYS.CERTIFY_TRUE_INFORMATION] ?? false,
        acceptTermsAndConditions: reimbursementAccountDraft?.[COMPLETE_VERIFICATION_KEYS.ACCEPT_TERMS_AND_CONDITIONS] ?? false,
    };

App/src/pages/ReimbursementAccount/USD/CompleteVerification/subSteps/ConfirmAgreements.tsx

Lines 44 to 48 in 73a784d

	const defaultValues = {
	isAuthorizedToUseBankAccount: reimbursementAccount?.achData?.isAuthorizedToUseBankAccount ?? false,
	certifyTrueInformation: reimbursementAccount?.achData?.certifyTrueInformation ?? false,
	acceptTermsAndConditions: reimbursementAccount?.achData?.acceptTermsAndConditions ?? false,
	};

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[dylanexpensify]

@joekaufmanexpensify this sounds like a bug, but wanted to confirm first if we did indeed design this flow w/the offline consideration at this stage

[joekaufmanexpensify]

I was not involved with the initial design, but agree that this looks like a bug. If you accept the terms offline and then go back online, you shouldn't have to deselect the checkbox and then check it again just to proceed

[melvin-bot]

@dylanexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021991092758012921430