[$250] Subscription - "Trial:" text is not centered after removing the subtitle

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.48-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: #74531
Issue reported by: Applause - Internal Team

Action Performed:

1. Open Expensify Android app
2. Create New Account > Create Workspace > Go to subscriptions
3. Paste the following in console: Onyx.merge('nvp_expensify_billingFundID', 32)

Expected Result:

The subtitle "Add a payment card to continue using all of your favorite features." is removed and the title is centered

Actual Result:

The subtitle "Add a payment card to continue using all of your favorite features." is removed but the title is not centered

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6999665_1762793498305.f6966f64-ea2e-44be-9e46-804514431f2d.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021988216255221991275
• Upwork Job ID: 1988216255221991275
• Last Price Increase: 2025-11-11
• Automatic offers:
• samranahm | Contributor | 109478311

Issue Owner

Current Issue Owner: @

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @AndrewGable (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Subscription - "Trial:" text is not centered after removing the subtitle

What is the root cause of that problem?

In BillingBanner.tsx, the subtitle was always rendered regardless of whether it contained content

When payment card is added via Onyx.merge('nvp_expensify_billingFundID', 32):

SubscriptionUtils.doesUserHavePaymentCardAdded() returns true
TrialStartedBillingBanner sets subtitle = ''
The BillingBanner component still renders an empty Text component

App/src/pages/settings/Subscription/CardSection/BillingBanner/BillingBanner.tsx

Lines 108 to 111 in 73a784d

	<View style={[styles.flex1, styles.justifyContentCenter]}>
	{typeof title === 'string' ? <Text style={[styles.textStrong, titleStyle]}>{title}</Text> : title}
	{typeof subtitle === 'string' ? <Text style={subtitleStyle}>{subtitle}</Text> : subtitle}
	</View>

What changes do you think we should make in order to solve the problem?

We should add a conditional check !!subtitle && before rendering the subtitle component, so when subtitle is an empty string or falsy, it's not rendered at all. This allows the single title element to be properly centered by justifyContentCenter.

{!!subtitle && (typeof subtitle === 'string' ? <Text style={subtitleStyle}>{subtitle}</Text> : subtitle)}

App/src/pages/settings/Subscription/CardSection/BillingBanner/BillingBanner.tsx

Lines 108 to 111 in 73a784d

	<View style={[styles.flex1, styles.justifyContentCenter]}>
	{typeof title === 'string' ? <Text style={[styles.textStrong, titleStyle]}>{title}</Text> : title}
	{typeof subtitle === 'string' ? <Text style={subtitleStyle}>{subtitle}</Text> : subtitle}
	</View>

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.