[Due for Payment 2025-12-03] [$250] Expense - Invited to chat user have Hold option when there is expenses

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.48-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exploratory
Email or phone of affected tester (no customers): gocemate+b2155043@gmail.com
Issue reported by: Applause Internal Team
Device used: Lenovo 80ES / Windows 10 Pro
App Component: Chat Report View

Action Performed:

1. User A create 2 expenses to User B
2. On report page User A mention User C
3. User A select "Invite to chat only"
4. User C open the mention chat
5. User C select one of the expenses> Hold the expens
6. Verify error appear
7. Open the expense detail page and dismiss the error> Go back to report

Expected Result:

Since User C is invited to chat only there should be no Hold option available.

Actual Result:

User C can unsuccessfully hold the expense, and when dismiss the error "This expense was put on hold" still remains

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021987928452055566187
• Upwork Job ID: 1987928452055566187
• Last Price Increase: 2025-11-17

Issue Owner

Current Issue Owner: @twisterdotcom

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

🚨 Edited by proposal-police: This proposal was edited at 2025-11-12 07:34:00 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

User C can unsuccessfully hold the expense, and when dismiss the error "This expense was put on hold" still remains

What is the root cause of that problem?

canHoldRequest condition doesn't return false if the user is not owner/manger of an iou report

App/src/libs/ReportUtils.ts

Line 4730 in 40dfb2f

const canHoldRequest = canHoldOrUnholdRequest && !isOnHold && (isRequestIOU || canModifyStatus) && !isScanning(transaction) && (isSubmitted || isActionOwner);

The same problem for secondary action

App/src/libs/ReportSecondaryActionUtils.ts

Line 415 in 40dfb2f

function isHoldActionForTransaction(report: Report, reportTransaction: Transaction, reportAction: ReportAction): boolean {

What changes do you think we should make in order to solve the problem?

We should update the check to remove isRequestIOU and update canModifyStatus check for iouReport

function canModifyHoldStatus(report: Report) {
    if (!isMoneyRequestReport(report) || isTrackExpenseReport(report)) {
        return false;
    }
    const isAdmin = isPolicyAdmin(report.policyID, allPolicies);
    const isActionOwner = isActionOrReportPreviewOwner(report);
    const isManager = isMoneyRequestReport(report) && report?.managerID !== null && currentUserPersonalDetails?.accountID === report?.managerID;
    
    if (isIOUReport(report)) {
        return isActionOwner || isManager;
    }

    return isAdmin || isActionOwner || isManager;
}
const canModifyStatus = canModifyHoldStatus(moneyRequestReport);
const canHoldRequest = canHoldOrUnholdRequest && !isOnHold && canModifyStatus && !isScanning(transaction) && (isSubmitted || isActionOwner);

App/src/libs/ReportUtils.ts

Line 4730 in 40dfb2f

const canHoldRequest = canHoldOrUnholdRequest && !isOnHold && (isRequestIOU || canModifyStatus) && !isScanning(transaction) && (isSubmitted || isActionOwner);

if (isIOUReport) {
        return (isSubmitter || isReportManager) && !isSettled(report);
    }

App/src/libs/ReportSecondaryActionUtils.ts

Line 415 in 40dfb2f

function isHoldActionForTransaction(report: Report, reportTransaction: Transaction, reportAction: ReportAction): boolean {

const isSubmitter = isCurrentUserSubmitter(report);
const isManager = isReportManagerUtils(report);

if (isIOUReportUtils(report) && !isSubmitter && isManager) {
    return false;
}

App/src/libs/ReportSecondaryActionUtils.ts

Line 444 in 82a45ab

function isChangeWorkspaceAction(report: Report, policies: OnyxCollection<Policy>, reportActions?: ReportAction[]): boolean {

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Users who are invited to chat only can see the Hold option on expenses, but cannot successfully perform the action

What is the root cause of that problem?

Hold option is shown because isHoldActionForTransaction checks role-based permissions (submitter, manager, admin, etc.) but doesn't check write capabilities. The user are added as a participant to the report but don't have write capabilities

App/src/libs/ReportSecondaryActionUtils.ts

Lines 415 to 442 in fc89cfe

	function isHoldActionForTransaction(report: Report, reportTransaction: Transaction, reportAction: ReportAction): boolean {
	const isExpenseReport = isExpenseReportUtils(report);
	const isIOUReport = isIOUReportUtils(report);
	const iouOrExpenseReport = isExpenseReport || isIOUReport;
	const {canHoldRequest} = canHoldUnholdReportAction(reportAction);
	if (!iouOrExpenseReport || !canHoldRequest) {
	return false;
	}
	const isReportOnHold = isOnHoldTransactionUtils(reportTransaction);
	if (isReportOnHold) {
	return false;
	}
	const isOpenReport = isOpenReportUtils(report);
	const isSubmitter = isCurrentUserSubmitter(report);
	const isReportManager = isReportManagerUtils(report);
	if (isOpenReport && (isSubmitter || isReportManager)) {
	return true;
	}
	const isProcessingReport = isProcessingReportUtils(report);
	return isProcessingReport;
	}

What changes do you think we should make in order to solve the problem?

We can add a write capability check in isHoldActionForTransaction before returning true

function isHoldActionForTransaction(report: Report, reportTransaction: Transaction, reportAction: ReportAction): boolean {
    const isExpenseReport = isExpenseReportUtils(report);
    const isIOUReport = isIOUReportUtils(report);
    const iouOrExpenseReport = isExpenseReport || isIOUReport;
    const {canHoldRequest} = canHoldUnholdReportAction(reportAction);

    if (!iouOrExpenseReport || !canHoldRequest) {
        return false;
    }

    // Check if user has write capabilities to perform actions on the expense report
    if (!isAllowedToComment(report)) {
        return false;
    }

    ...
}

We need to update the bulk action as well

        if (canHoldTransactions && canUserPerformWriteAction) {

App/src/hooks/useSelectedTransactionsActions.ts

Line 182 in fc89cfe

if (canHoldTransactions) {

What alternative solutions did you explore? (Optional)

None

[nkdengineer]

Updated proposal

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021987928452055566187

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)

[eh2077]

@nyomanjyotisa It's not a good practice to copy issue title for the section Please re-state the problem that we are trying to solve in this issue.

[nyomanjyotisa]

@eh2077 Thanks for the feedback! I've updated the proposal