[$250] Cards - After deleting region bank direct feed, company card link is not removed instantly

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.2.44-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-1795/folder/13176706/41236862/994330632
Email or phone of affected tester (no customers): Slottwo1 72old.approver@gmail.com
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13 phone
App Component: Money Requests

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Go to workspace settings
3. Tap company card
4. Assign a direct feed card via region bank
5. Open workpace chat and check system message with company card link
6. Go to company card
7. Unassign the card
8. Go to workspace chat and note company card link is disappeared
9. Go to company card, assign a card and delete the entire region bank feed
10. Go to workspace chat
11. Note company card link is shown
12. Revisit and refresh the page
13. Note company card link is still displayed
14. Tap on the company card link
    15.Tap device back button
15. Open workpace chat again
16. Note company card link not shown now

Expected Result:

After deleting region bank direct feed, company card link must be removed instantly.

Actual Result:

After deleting region bank direct feed, company card link is not removed instantly.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021988746750204904960
• Upwork Job ID: 1988746750204904960
• Last Price Increase: 2025-11-12
• Automatic offers:
• aimane-chnaif | Reviewer | 109525344

Issue Owner

Current Issue Owner: @jasperhuangg

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mukhrr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After deleting a region bank direct feed from company cards, the company card link in the workspace chat system message is not removed instantly.

What is the root cause of that problem?

When deleteWorkspaceCompanyCardFeed is called, the cards associated with the deleted feed are not properly removed from CARD_LIST in Onyx. The success data only clears the pendingAction field ({pendingAction: null}) instead of removing the cards entirely (null).

App/src/libs/actions/CompanyCards.ts

Line 218 in 5279e0b

const successAndFailureCardUpdates = Object.fromEntries(cardIDs.map((cardID) => [cardID, {pendingAction: null}]));

App/src/libs/actions/CompanyCards.ts

Lines 260 to 264 in 5279e0b

	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: ONYXKEYS.CARD_LIST,
	value: successAndFailureCardUpdates,
	},

What changes do you think we should make in order to solve the problem?

We need to split successAndFailureCardUpdates into two separate variables:

successCardUpdates: Maps each cardID to null to remove cards from Onyx
failureCardUpdates: Maps each cardID to {pendingAction: null} to preserve cards on failure

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021988746750204904960

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[melvin-bot]

@johncschuster 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[aimane-chnaif]

@mukhrr thanks for the proposal. Can you please share demo video?