[Due for payment 2025-12-11] [$250] Per diem - Create report button subtitle shows wrong workspace when accessed from Reports

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.43-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-1739/folder/13176674/53829876/991934204
Email or phone of affected tester (no customers): sijdiosjoisjdio@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Account has a default workspace which does not have per diem feature (disabled).
• Create a second workspace with per diem rates.

1. Go to staging.new.expensify.com
2. Go to the second workspace chat.
3. Create a per diem expense in workspace chat.
4. Open the expense report.
5. Click Report field
   → Create report button subtitle shows the workspace with per diem rates - Expected.
6. Go to Reports > Expenses.
7. Select the expense via checkbox.
8. Click dropdown button > Move expense.

Expected Result:

Create report button subtitle will show the workspace with per diem rates.

Actual Result:

Create report button subtitle shows the default workspace that does not have per diem rates, which is inconsistent with the button when accessed from Inbox (Step 5).

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6993384_1762235571860.4.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021990940105130209711
• Upwork Job ID: 1990940105130209711
• Last Price Increase: 2025-11-19
• Automatic offers:
• daledah | Contributor | 109584215

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Create report button subtitle shows the default workspace that does not have per diem rates, which is inconsistent with the button when accessed from Inbox (Step 5).

What is the root cause of that problem?

We are missing passing the isPerDiemRequest props here

App/src/pages/Search/SearchTransactionsChangeReport.tsx

Lines 146 to 157 in 995eec3

	<IOURequestEditReportCommon
	backTo={undefined}
	transactionIDs={selectedTransactionsKeys}
	selectedReportID={selectedReportID}
	selectReport={selectReport}
	removeFromReport={removeFromReport}
	createReport={createReport}
	isEditing
	isUnreported={areAllTransactionsUnreported}
	targetOwnerAccountID={targetOwnerAccountID}
	/>
	</>

=> isPerdiemRequest is undefined here

App/src/pages/iou/request/step/IOURequestEditReportCommon.tsx

Line 83 in 995eec3

const {policyForMovingExpenses} = usePolicyForMovingExpenses(isPerDiemRequest);

=> We filter fails

App/src/hooks/usePolicyForMovingExpenses.ts

Lines 33 to 40 in 995eec3

	const userPolicies = Object.values(allPolicies ?? {}).filter(
	(policy) =>
	checkForUserPendingDelete(login, policy) &&
	isPolicyMemberByRole(policy) &&
	isPaidGroupPolicy(policy) &&
	policy?.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE &&
	(!isPerDiemRequest || canSubmitPerDiemExpenseFromWorkspace(policy)),
	);

What changes do you think we should make in order to solve the problem?

We should pass isPerdiemRequest prop like the way we did here

    const [allTransactions] = useOnyx(ONYXKEYS.COLLECTION.TRANSACTION, {canBeMissing: true});
    const hasPerDiemTransactions = useMemo(() => {
        return selectedTransactionsKeys.some((transactionID) => {
            const transaction = allTransactions?.[`${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`];
            return transaction && isPerDiemRequest(transaction);
        });
    }, [selectedTransactionsKeys, allTransactions]);
    ...
    <IOURequestEditReportCommon
          ...
          isPerDiemRequest={hasPerDiemTransactions}
      />

App/src/pages/iou/request/step/IOURequestEditReport.tsx

Lines 49 to 54 in 995eec3

	const hasPerDiemTransactions = useMemo(() => {
	return selectedTransactionIDs.some((transactionID) => {
	const transaction = allTransactions?.[`${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`];
	return transaction && isPerDiemRequest(transaction);
	});
	}, [selectedTransactionIDs, allTransactions]);

App/src/pages/iou/request/step/IOURequestEditReport.tsx

Line 138 in 995eec3

isPerDiemRequest={hasPerDiemTransactions}

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[thelullabyy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Create report button subtitle shows the default workspace that does not have per diem rates, which is inconsistent with the button when accessed from Inbox (Step 5).

What is the root cause of that problem?

In SearchTransactionsChangeReport, we don't pass isPerDiemRequest so that

App/src/pages/Search/SearchTransactionsChangeReport.tsx

Line 146 in e947015

<IOURequestEditReportCommon

So that in IOURequestEditReportCommon, it relies solely on usePolicyForMovingExpenses. However, this hook doesn't consider the context of where the expense originated

App/src/pages/iou/request/step/IOURequestEditReport.tsx

Line 56 in b162d0a

const {policyForMovingExpensesID, shouldSelectPolicy} = usePolicyForMovingExpenses(hasPerDiemTransactions);

Therefore, component to fall back to the default workspace instead of maintaining the workspace context

Also, I see that we don't pass selectedReportID so that the filter here is not working correctly as well

App/src/pages/iou/request/step/IOURequestEditReportCommon.tsx

Line 117 in d8fa26f

if (!selectedPolicyID || selectedPolicyID === personalPolicyID || isSelfDM(selectedReport)) {

What changes do you think we should make in order to solve the problem?

We need to add selectedPolicyID={selectedReport?.policyID} prop when rendering IOURequestEditReportCommon in IOURequestEditReport

App/src/pages/iou/request/step/IOURequestEditReport.tsx

Line 129 in b162d0a

<IOURequestEditReportCommon

Then in IOURequestEditReportCommon, we need to update when moving per diem expenses, prefer the policy from the selected report if it has per diem rates

    const {policyForMovingExpenses: policyForMovingExpensesFromHook} = usePolicyForMovingExpenses(isPerDiemRequest);
    const [selectedPolicyData] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY}${selectedPolicyID}`, {canBeMissing: true});

    const policyForMovingExpenses = useMemo(() => {
        if (isPerDiemRequest && selectedPolicyData && canSubmitPerDiemExpenseFromWorkspace(selectedPolicyData)) {
            return selectedPolicyData;
        }
        return policyForMovingExpensesFromHook;
    }, [isPerDiemRequest, selectedPolicyData, policyForMovingExpensesFromHook]);

App/src/pages/iou/request/step/IOURequestEditReportCommon.tsx

Line 83 in d8fa26f

const {policyForMovingExpenses} = usePolicyForMovingExpenses(isPerDiemRequest);

In SearchTransactionsChangeReport, when call usePolicyForMovingExpenses hook, we need to pass isPerDiemRequest there

    const [allTransactions] = useOnyx(ONYXKEYS.COLLECTION.TRANSACTION, {canBeMissing: true});

    const hasPerDiemTransactions = useMemo(() => {
        return selectedTransactionsKeys.some((transactionID) => {
            const transaction = allTransactions?.[`${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`];
            return transaction && isPerDiemRequest(transaction);
        });
    }, [selectedTransactionsKeys, allTransactions]);

    const {policyForMovingExpensesID, shouldSelectPolicy} = usePolicyForMovingExpenses(hasPerDiemTransactions);

App/src/pages/Search/SearchTransactionsChangeReport.tsx

Line 33 in e947015

const {policyForMovingExpensesID, shouldSelectPolicy} = usePolicyForMovingExpenses();

After that, we can pass selectedPolicyID and isPerDiemRequest to IOURequestEditReportCommon

    const selectedPolicyID = firstTransactionKey ? selectedTransactions[firstTransactionKey]?.policyID : undefined;

            <IOURequestEditReportCommon
                ...
                selectedPolicyID={selectedPolicyID}
                isPerDiemRequest={hasPerDiemTransactions}
            />

App/src/pages/Search/SearchTransactionsChangeReport.tsx

Line 146 in e947015

<IOURequestEditReportCommon

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mallenexpensify]

Gonna take me a few to attempt reproduciton.

[melvin-bot]

@mallenexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021990940105130209711