[Due for payment 2025-11-18] [$250] Expense-Total amount of the split expenses is displayed incorrectly and an error occurs later

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.2.37-6
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-1439/folder/13176791/41237172/969659997
Email or phone of affected tester (no customers): Slottwo1 fgg55@gmail.com
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13 phone
App Component: Money Requests

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Open workspace chat
3. Create a manual expense for (-8)
4. Open the expense details of transaction
5. Tap more - split expense
6. Remove the second split
7. Add a split
8. Change amount to 0.01
9. Remove negative sign from first split by keeping cursor on first split
   10.Note the text above save button mentioning total is less than original amount
10. Tap save

Expected Result:

Step 10 : The text above the save button is incorrect. It should say 'Total amount is 4.01 greater than the original expense,' and the user should not be able to split the expense.

Actual Result:

Step 10 : The text above the save button is displayed as 'Total amount is 3.99 less than the original expense' . Even though the correct total amount is 4.01, which is actually greater than the original expense.

Error displayed after click save button in Step 11 :

• The sum of split amounts exceeds the original amount
• Unexpected error submitting this expense. Please try again later.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6982894_1761276314558.Screenrecorder-2025-10-24-08-53-54-721.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021981750828087713524
• Upwork Job ID: 1981750828087713524
• Last Price Increase: 2025-10-24
• Automatic offers:
• aimane-chnaif | Reviewer | 109284062
• mkzie2 | Contributor | 109284063

Issue Owner

Current Issue Owner: @sakluger

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[dmkt9]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Step 10 : The text above the save button is displayed as 'Total amount is 3.99 less than the original expense' . Even though the correct total amount is 4.01, which is actually greater than the original expense.

What is the root cause of that problem?

We’ve always taken the absolute value of transactionDetailsAmount, which causes the warning message to show a smaller amount than the actual value.

App/src/pages/iou/SplitExpensePage.tsx

Lines 299 to 302 in 302280e

	const shouldShowWarningMessage = sumOfSplitExpenses < Math.abs(transactionDetailsAmount);
	const warningMessage = shouldShowWarningMessage
	? translate('iou.totalAmountLessThanOriginal', {amount: convertToDisplayString(Math.abs(transactionDetailsAmount) - sumOfSplitExpenses, transactionDetails.currency)})
	: '';

What changes do you think we should make in order to solve the problem?

Remove Math.abs from transactionDetailsAmount.
Add a warningMessage for the totalAmountGreaterThanOriginal case.
When totalAmountGreaterThanOriginal is true, we should disable the Save button.

App/src/pages/iou/SplitExpensePage.tsx

Lines 299 to 302 in 302280e

	const shouldShowWarningMessage = sumOfSplitExpenses < Math.abs(transactionDetailsAmount);
	const warningMessage = shouldShowWarningMessage
	? translate('iou.totalAmountLessThanOriginal', {amount: convertToDisplayString(Math.abs(transactionDetailsAmount) - sumOfSplitExpenses, transactionDetails.currency)})
	: '';

App/src/pages/iou/SplitExpensePage.tsx

Line 316 in 302280e

<Button

If we don’t disable the Save button, we can remove Math.abs here to show the error message upon submission:

App/src/pages/iou/SplitExpensePage.tsx

Lines 142 to 146 in 302280e

	if (sumOfSplitExpenses > Math.abs(transactionDetailsAmount)) {
	const difference = sumOfSplitExpenses - Math.abs(transactionDetailsAmount);
	setErrorMessage(translate('iou.totalAmountGreaterThanOriginal', {amount: convertToDisplayString(difference, transactionDetails?.currency)}));
	return;
	}

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021981750828087713524

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Step 10 : The text above the save button is displayed as 'Total amount is 3.99 less than the original expense' . Even though the correct total amount is 4.01, which is actually greater than the original expense.

What is the root cause of that problem?

1. sumOfSplitExpenses isn't calculated correctly. We're calculating the total of the absolute amount value

App/src/pages/iou/SplitExpensePage.tsx

Line 87 in 56763a0

const sumOfSplitExpenses = useMemo(() => (draftTransaction?.comment?.splitExpenses ?? []).reduce((acc, item) => acc + Math.abs(item.amount ?? 0), 0), [draftTransaction]);

2. We're comparing the absolute amount instead of the original amount value

App/src/pages/iou/SplitExpensePage.tsx

Line 142 in 56763a0

if (sumOfSplitExpenses > Math.abs(transactionDetailsAmount)) {

App/src/pages/iou/SplitExpensePage.tsx

Line 299 in 56763a0

const shouldShowWarningMessage = sumOfSplitExpenses < Math.abs(transactionDetailsAmount);

What changes do you think we should make in order to solve the problem?

1. We should remove all Math.abs when calculating the sumOfSplitExpenses here

App/src/pages/iou/SplitExpensePage.tsx

Line 87 in 56763a0

const sumOfSplitExpenses = useMemo(() => (draftTransaction?.comment?.splitExpenses ?? []).reduce((acc, item) => acc + Math.abs(item.amount ?? 0), 0), [draftTransaction]);

2. Remove all Math.abs usages on SplitExpensePage when comparing/calculating the difference on SplitExpensePage
3. We don't need to disable the confirm button since the greater than error will appear when we click on this button with the fix above

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[aimane-chnaif]

@mkzie2's proposal looks good.
Split amount input currently doesn't support negative value input. I think we should fix this as well.
🎀 👀 🎀 C+ reviewed