[Due for payment 2025-11-26] [Due for payment 2025-11-19] [$250] Report - System messages disappear when splitting expense and reappear in offline mode.

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.37-6
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-1441/folder/13176791/41237172/969661805
Email or phone of affected tester (no customers): ibellicotest+1950@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 / Android 12 / Chrome ( mWeb / Hybrid app) - Windows 11 / Chrome
App Component: Money Requests

Action Performed:

Prerequisite: Account has a workspace.
Prerequisite 2: Delayed submissions and approvals enabled.

1. Open the Expensify app.
2. Open any workspace chat.
3. Create a manual expense.
4. Open the just created expense.
5. Submit and approve the expense.
6. Tap on "More" and unnaprove the expense.
7. Note that system messages appeared at the bottom of report, showing the last actions.
8. Tap on "More" and select "Split"
9. Save the splits amount.
10. Note that when landing on report again, no system messages are visible on report.
11. Turn off internet connection.
12. Note that system messages reappear.

Expected Result:

System messages generated when submitting or approving a report, should still be visible when splitting an expense.

Actual Result:

System messages generated when submitting or approving a report, disappear when splitting an expense and reappear when user is in offline mode.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6982891_1761270713345.Split.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021983141120090928306
• Upwork Job ID: 1983141120090928306
• Last Price Increase: 2025-10-28
• Automatic offers:
• situchan | Contributor | 109313009

Issue Owner

Current Issue Owner: @sonialiap

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The system message disappears after splitting the expense, but appears back when offline.

What is the root cause of that problem?

When we do the split, we optimistically mark the original IOU action as deleted by using prepareToCleanUpMoneyRequest.

App/src/libs/actions/IOU.ts

Lines 13677 to 13688 in 8ebf129

	if (firstIOU) {
	const {updatedReportAction, transactionThread} = prepareToCleanUpMoneyRequest(originalTransactionID, firstIOU, iouReport, chatReport, isChatReportArchived);
	optimisticData.push({
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT}${firstIOU?.childReportID}`,
	value: null,
	});
	optimisticData.push({
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${iouReport?.reportID}`,
	value: updatedReportAction,
	});

However, inside prepareToCleanUpMoneyRequest, we have a logic to delete all the IOU report actions if we are deleting the last expense inside the report.

App/src/libs/actions/IOU.ts

Lines 8258 to 8285 in 8ebf129

	const shouldDeleteIOUReport = getReportTransactions(iouReportID).filter((trans) => !transactionIDsPendingDeletion?.includes(trans.transactionID)).length === 1;
	if (shouldDeleteIOUReport) {
	const iouReportActions = allReportActions?.[`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${iouReportID}`];
	for (const [reportActionID, reportActionData] of Object.entries(iouReportActions ?? {})) {
	if (
	reportAction.reportActionID === reportActionID ||
	reportActionData.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE ||
	reportActionData.actionName === 'CREATED' ||
	!reportActionData.message ||
	isDeletedAction(reportActionData)
	) {
	continue;
	}
	updatedReportAction[reportActionID] = {
	pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE,
	previousMessage: reportAction.message,
	message: [
	{
	type: 'COMMENT',
	html: '',
	text: '',
	isEdited: true,
	},
	],
	errors: null,

This causes the system message to be marked as deleted too, which is unexpected.

What changes do you think we should make in order to solve the problem?

We use prepareToCleanUpMoneyRequest only to mark the original IOU action as deleted and also get the transaction thread object. We have 2 options:

First, add a new param to ignore the shouldDeleteIOUReport.

App/src/libs/actions/IOU.ts

Line 8258 in 8ebf129

const shouldDeleteIOUReport = getReportTransactions(iouReportID).filter((trans) => !transactionIDsPendingDeletion?.includes(trans.transactionID)).length === 1;

OR

Second, we can just copy the code to get the IOU action optimistic data and transaction thread.

if (firstIOU) {
    const updatedReportAction = {
        [firstIOU.reportActionID]: {
            pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE,
            previousMessage: firstIOU.message,
            message: [
                {
                    type: 'COMMENT',
                    html: '',
                    text: '',
                    isEdited: true,
                    isDeletedParentAction: true,
                },
            ],
            originalMessage: {
                IOUTransactionID: null,
            },
            errors: null,
        },
    }
    const transactionThread = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${firstIOU.childReportID}`];

I prefer this more because we also won't run many unnecessarry code inside prepareToCleanUpMoneyRequest.

[melvin-bot]

@sonialiap Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021983141120090928306

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @bernhardoj (External)