[Due for payment 2025-12-26][$250] Scan - Error missing amount when scan multi receipts from QAB for 1:1 conversation

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.37-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: N/A
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: iPhone 16 pro/ 18.6.2
App Component: Money Requests

Action Performed:

1. Open app
2. Navigate to any 1:1 conversation
3. Create a scan receipt
4. After scanning completed, go back to home page
5. Tap on FAB
6. Tap on Scan receipt at quick action
7. Tap on scan multi icon
8. Take photo 2 receipts and complete flow
9. After scanning completed, tap on this report

Expected Result:

Expenses are created

Actual Result:

Error "Missing amount" are displayed. Tap on expenses, receipt isn't added

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021981805006922591602
• Upwork Job ID: 1981805006922591602
• Last Price Increase: 2025-10-31

Issue Owner

Current Issue Owner: @garrettmknight

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021981805006922591602

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

[gijoe0295]

🚨 Edited by proposal-police: This proposal was edited at 2025-10-29 16:39:47 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Error missing amount when scan multi receipts from QAB for 1:1 conversation. Reproducible steps:

Precondition: You've dismissed location permission modal before

1. Submit a scan expense and wait till scan completes
2. FAB > Scan expense quick action button (important)
3. Toggle multi scan mode
4. Capture a photo > Next
5. The expense is created but receipt is not uploaded

What is the root cause of that problem?

If the receipt is missing uri, we won't upload it:

App/src/libs/actions/IOU.ts

Line 6048 in 6b678ca

receipt: isFileUploadable(receipt) ? receipt : undefined,

Normally for single scan flow, file URI is already handled here in readFileAsync and the handled file is directly passed to submitReceipts here.

But for multi scan flow, we delegate the file handling to ReceiptPreviews. In ReceiptPreviews, we don't use readFileAsync to handle file URI but use receipts from draft transactions instead. Draft transaction's receipt does not contain URI.

App/src/pages/iou/request/step/IOURequestStepScan/ReceiptPreviews/index.tsx

Lines 120 to 123 in e44fa61

	const submitReceipts = () => {
	const transactionReceipts = (optimisticTransactionsReceipts ?? []).filter((receipt): receipt is ReceiptWithTransactionID & {source: string} => !!receipt.source);
	submit(transactionReceipts);
	};

This only happens when creating multi-scan expenses via quick action button but not other flows because in those flows, we navigate to confirmation step, and run revalidation on all the receipts using checkIfScanFileCanBeRead which internally uses readFileAsync that handles the file URI:

App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Lines 459 to 463 in 30b765b

	return checkIfScanFileCanBeRead(itemReceiptFilename, itemReceiptPath, itemReceiptType, onSuccess, onFailure);
	}),
	).then(() => {
	if (isScanFilesCanBeRead) {
	setReceiptFiles(newReceiptFiles);

App/src/libs/actions/IOU.ts

Line 12108 in 80a1a59

return readFileAsync(receiptPath.toString(), receiptFilename, onSuccess, onFailure, receiptType);

What changes do you think we should make in order to solve the problem?

In IOURequestStepScan, we already have the receiptFiles state variable which contain all captured receipts with proper file handling (including uri, filename...), we can reuse it instead of recomputing it again in ReceiptPreviews like we're currently doing:

App/src/pages/iou/request/step/IOURequestStepScan/ReceiptPreviews/index.tsx

Lines 120 to 123 in e44fa61

	const submitReceipts = () => {
	const transactionReceipts = (optimisticTransactionsReceipts ?? []).filter((receipt): receipt is ReceiptWithTransactionID & {source: string} => !!receipt.source);
	submit(transactionReceipts);
	};

Remove the above logic, instead just simply call submit().

Then in the callback prop here, update:

App/src/pages/iou/request/step/IOURequestStepScan/index.native.tsx

Line 951 in 9f1f0ac

submit={submitReceipts}

to

submit={() => submitReceipts(receiptFiles)}

What alternative solutions did you explore? (Optional)

1. Save file uri directly to transaction's receipt via setMoneyRequestReceipt here. uri is always same as source. But we need to update the Receipt model here and change a lot relating files.
2. Replace all instances of optimisticTransactionsReceipts in ReceiptPreviews with receiptFiles state from IOURequestStepScan
3. There are several other ways like manually updating receipt.uri = receipt.source in requestMoney, trackExpense,... but the general idea is that we need to supplement URI for the receipt to be uploaded

[melvin-bot]

@suneox Whoops! This issue is 2 days overdue. Let's get this updated quick!

[suneox]

We just got a proposal, I’ll take a look at this one today.