[Needs Repro] Expense - Inconsistency on tapping Mark as paid for invoice and expenses

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.2.34-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176671/test-cases/51507176
Email or phone of affected tester (no customers): Slottwo1 fgg55@gmail.com
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13
App Component: Money Requests

Action Performed:

1. Pre-condition : Use 2 non validated gmail accounts

2. Login in mweb(user A) and android (user B)

3. Go to https://staging.new.expensify.com/home

4. Go to workspace settings

5. Enable invoice

6. Send a invoice to user B

7. Launch app

8. Open invoice as user B

9. Pay invoice as individual

10. Note invoice is paid

Case 2
Pre-condition: Use non validated gmail account

1. Create few expenses in workspace chat
2. Submit and approve the expenses
3. Tap pay dropdown
4. Select mark as paid
5. Note prompt to enter mage code is shown

Expected Result:

Inconsistency must not be shown on tapping Mark as paid for invoice and expenses.

Actual Result:

Tapping Mark as paid prompts to enter magic for workspace expenses and paid automatically for invoice. Inconsistency on tapping Mark as paid for invoice and expenses.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

2.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - Inconsistency on tapping Mark as paid for invoice and expenses

What is the root cause of that problem?

In invoices, the Mark as paid individually is wired with an inline onSelected handler in usePaymentOptions.ts inside usePaymentOptions. This bypasses the SettlementButton/KYCWall flow that performs the validation redirect. For expenses, the selection flows through the parent handler, so the validation redirect is triggered.

App/src/hooks/usePaymentOptions.ts

Lines 190 to 195 in 4d1a0f7

	{
	text: translate('iou.payElsewhere', {formattedAmount: ''}),
	icon: Expensicons.Cash,
	value: CONST.IOU.PAYMENT_TYPE.ELSEWHERE,
	onSelected: () => onPress(CONST.IOU.PAYMENT_TYPE.ELSEWHERE),
	},

What changes do you think we should make in order to solve the problem?

We should remove the onSelected for isIndividualInvoiceRoomUtil

    onSelected: () => onPress(CONST.IOU.PAYMENT_TYPE.ELSEWHERE),

here

App/src/hooks/usePaymentOptions.ts

Lines 190 to 195 in 4d1a0f7

	{
	text: translate('iou.payElsewhere', {formattedAmount: ''}),
	icon: Expensicons.Cash,
	value: CONST.IOU.PAYMENT_TYPE.ELSEWHERE,
	onSelected: () => onPress(CONST.IOU.PAYMENT_TYPE.ELSEWHERE),
	},

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@strepanier03 Still overdue 6 days?! Let's take care of this!

[strepanier03]

Haven't been able to test this yet.

[truph01]

We should hold this one as per #71330

[hungvu193]

Let me know if this is still reproducible after #71330 is merged. I will fix it as a part of the Payment Option project.

Thanks!

[melvin-bot]

@strepanier03 this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@strepanier03 Huh... This is 4 days overdue. Who can take care of this?

[strepanier03]

Will do! The PR isn't deployed yet so I'll check tomorrow.