[Due for payment 2025-11-11] [$250] Search - "No results found" is displayed instead of "invalid phone number"

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.34-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #72840
Email or phone of affected tester (no customers): htad26+ewry@gmail.com
Issue reported by: Applause Internal Team
Device used: Android 11/Tecno spark 8, iOS 18.6/iPhone 13
App Component: Search

Action Performed:

1.Navigate to the Android or the iOS app
2. Click Fab icon > Create Expense
3. Enter some amount
4. Go to next step
5. Click on 'To' selector
6. In the search type "489327498237492374"

Expected Result:

The invalid phone number message appears

Actual Result:

"No results found" message appears instead of the "Invalid phone number" message

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021981083461252157554
• Upwork Job ID: 1981083461252157554
• Last Price Increase: 2025-10-22

Issue Owner

Current Issue Owner: @bernhardoj

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Eskalifer1]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search - "No results found" is displayed instead of "invalid phone number"

What is the root cause of that problem?

On native devices if showImportContacts is true we show this header:

App/src/pages/iou/request/ImportContactButton/index.native.tsx

Lines 14 to 32 in 59123b4

	function ImportContactButton({showImportContacts, inputHelperText, isInSearch = false}: ImportContactButtonProps) {
	const styles = useThemeStyles();
	const {translate} = useLocalize();
	return showImportContacts && inputHelperText ? (
	<View style={[styles.ph5, styles.pb5, styles.flexRow]}>
	<Text style={[styles.textLabel, styles.colorMuted, styles.minHeight5]}>
	{isInSearch ? `${translate('common.noResultsFound')}. ` : null}
	<Text
	style={[styles.textLabel, styles.minHeight5, styles.link]}
	onPress={goToSettings}
	>
	{translate('contact.importContactsTitle')}
	</Text>{' '}
	{translate('contact.importContactsExplanation')}
	</Text>
	</View>
	) : null;
	}

And we always show here "no results found"

What changes do you think we should make in order to solve the problem?

We can show inputHelperText instead and as fallback no results found:

        {isInSearch ? inputHelperText ?? `${translate('common.noResultsFound')}. ` : null}

PS: We can adjust this text based on expected behaviour

What alternative solutions did you explore? (Optional)

We can inside this button check if this is phone number and if its not valid just show other result
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

No result found message is displayed instead of invalid number in native.

What is the root cause of that problem?

In native, when there is no result, whatever the reason is, we show the import contact message.

App/src/pages/iou/request/MoneyRequestParticipantsSelector.tsx

Line 117 in 9fdab54

const showImportContacts = isNative && !(contactPermissionState === RESULTS.GRANTED || contactPermissionState === RESULTS.LIMITED);

App/src/pages/iou/request/MoneyRequestParticipantsSelector.tsx

Lines 638 to 643 in 9fdab54

	headerContent={
	<ImportContactButton
	showImportContacts={showImportContacts}
	inputHelperText={inputHelperText}
	isInSearch
	/>

App/src/pages/iou/request/ImportContactButton/index.native.tsx

Lines 18 to 26 in 9fdab54

	return showImportContacts && inputHelperText ? (
	<View style={[styles.ph5, styles.pb5, styles.flexRow]}>
	<Text style={[styles.textLabel, styles.colorMuted, styles.minHeight5]}>
	{isInSearch ? `${translate('common.noResultsFound')}. ` : null}
	<Text
	style={[styles.textLabel, styles.minHeight5, styles.link]}
	onPress={goToSettings}
	>
	{translate('contact.importContactsTitle')}

What changes do you think we should make in order to solve the problem?

We should only show the import contact message if it's really not found, not because invalid email or number. We can update showImportContacts to check if the header message is no result found.

const showImportContacts = isNative && !(contactPermissionState === RESULTS.GRANTED || contactPermissionState === RESULTS.LIMITED) && inputHelperText === translate('common.noResultsFound');

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021981083461252157554

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)