[Awaiting Checklist Completion] [$250] Add bank account - User not prompted to change currency after account validation

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.32-0-staging
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #72572
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Windows 11, Chrome | Samsung A15, Android 15
App Component: Workspace Settings

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Sign up with a Gmail address that includes a +
3. Choose Track and budget expenses. Complete the onboarding flow.
4. Create a workspace.
5. Go to more features, toggle on Invoices
6. Go to Invoices
7. Click on Add bank account

Expected Result:

After validating the bank account, the user should be prompted to change the account currency.

Actual Result:

No prompt appears to change or confirm the currency after account validation.

Additionally, the flow for adding a bank account after validation looks like to Wallet > Add bank account flow, which displays the “Personal bank account added” screen upon completion.

However, if the user cancels the add bank account flow after validation and reopens it, the add bank account flow now looks like Workflows > Add bank account and the “Personal bank account added” screen is not shown at the end of the process.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6976161_1760573980653.explorer_7RztxF50ak.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021978848806837670726
• Upwork Job ID: 1978848806837670726
• Last Price Increase: 2025-10-16

Issue Owner

Current Issue Owner: @brunovjk

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[paulnjs]

Proposal

Please re-state the problem that we are trying to solve in this issue.

No prompt appears to change or confirm the currency after account validation.

What is the root cause of that problem?

The user always navigate to the bank account flow instead of checking the currency first.

App/src/pages/workspace/invoices/WorkspaceInvoiceVBASection.tsx

Lines 138 to 145 in e4aabe2

	const onAddBankAccountPress = () => {
	if (shouldShowDefaultDeleteMenu) {
	setShouldShowDefaultDeleteMenu(false);
	return;
	}
	navigateToBankAccountRoute(policyID, ROUTES.WORKSPACE_INVOICES.getRoute(policyID));
	};

What changes do you think we should make in order to solve the problem?

Follow the same approach on WorkspaceWorkflowsPage, we should prompt the user to change the currency first.

1. Add currency checking in onAddBankAccountPress to display the currency confirm modal like here

App/src/pages/workspace/invoices/WorkspaceInvoiceVBASection.tsx

Lines 138 to 145 in e4aabe2

	const onAddBankAccountPress = () => {
	if (shouldShowDefaultDeleteMenu) {
	setShouldShowDefaultDeleteMenu(false);
	return;
	}
	navigateToBankAccountRoute(policyID, ROUTES.WORKSPACE_INVOICES.getRoute(policyID));
	};

2. The modal can be copied from here

3. After confirming, follow the logic here to call navigateToBankAccountRoute(policyID, ROUTES.WORKSPACE_INVOICES.getRoute(policyID));

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

undefined

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[lorretheboy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Add bank account - User not prompted to change currency after account validation

What is the root cause of that problem?

In onAddBankAccountPress, we don't handle the currency change

App/src/pages/workspace/invoices/WorkspaceInvoiceVBASection.tsx

Lines 138 to 144 in 47b6fdd

	const onAddBankAccountPress = () => {
	if (shouldShowDefaultDeleteMenu) {
	setShouldShowDefaultDeleteMenu(false);
	return;
	}
	navigateToBankAccountRoute(policyID, ROUTES.WORKSPACE_INVOICES.getRoute(policyID));
	};

What changes do you think we should make in order to solve the problem?

We should add currency validation before navigating to the bank account setup (similar to the Workflows flow)

1. Below here, we should add modal for currency change (We might need minor changes in PR phase if needed)

    type CurrencyType = TupleToUnion<typeof CONST.DIRECT_REIMBURSEMENT_CURRENCIES>;

    const {isBetaEnabled} = usePermissions();
    const [reimbursementAccount] = useOnyx(ONYXKEYS.REIMBURSEMENT_ACCOUNT, {canBeMissing: true});
    const [reimbursementAccountDraft] = useOnyx(ONYXKEYS.FORMS.REIMBURSEMENT_ACCOUNT_FORM_DRAFT, {canBeMissing: true});
    const [isUpdateWorkspaceCurrencyModalOpen, setIsUpdateWorkspaceCurrencyModalOpen] = useState(false);

    const hasValidExistingAccounts = getEligibleExistingBusinessBankAccounts(bankAccountList, policy?.outputCurrency).length > 0;

    const isNonUSDWorkspace = policy?.outputCurrency !== CONST.CURRENCY.USD;
    const achData = reimbursementAccount?.achData;
    const nonUSDCountryDraftValue = reimbursementAccountDraft?.country ?? '';

    const shouldShowContinueModal = useMemo(() => {
        return hasInProgressVBBA(achData, isNonUSDWorkspace, nonUSDCountryDraftValue);
    }, [achData, isNonUSDWorkspace, nonUSDCountryDraftValue]);

    const confirmCurrencyChangeAndHideModal = useCallback(() => {
        if (!policy) {
            return;
        }

        setIsUpdateWorkspaceCurrencyModalOpen(false);

        if (isBetaEnabled(CONST.BETAS.GLOBAL_REIMBURSEMENTS_ON_ND)) {
            setIsForcedToChangeCurrency(true);
            Navigation.navigate(ROUTES.WORKSPACE_OVERVIEW_CURRENCY.getRoute(policy.id));
        } else {
            updateGeneralSettings(policy.id, policy.name, CONST.CURRENCY.USD);
            clearDraftValues(ONYXKEYS.FORMS.REIMBURSEMENT_ACCOUNT_FORM);
            clearCorpayBankAccountFields();
            const hasValidExistingUSDAccounts = getEligibleExistingBusinessBankAccounts(bankAccountList, CONST.CURRENCY.USD).length > 0;
            if (hasValidExistingUSDAccounts) {
                Navigation.navigate(ROUTES.WORKSPACE_WORKFLOWS_CONNECT_EXISTING_BANK_ACCOUNT.getRoute(policyID));
            } else {
                navigateToBankAccountRoute(policyID, ROUTES.WORKSPACE_INVOICES.getRoute(policyID));
            }
        }
    }, [bankAccountList, isBetaEnabled, policy, policyID]);

...

            <ConfirmModal
                title={translate('workspace.bankAccount.workspaceCurrency')}
                isVisible={isUpdateWorkspaceCurrencyModalOpen}
                onConfirm={confirmCurrencyChangeAndHideModal}
                onCancel={() => setIsUpdateWorkspaceCurrencyModalOpen(false)}
                prompt={translate('workspace.bankAccount.updateCurrencyPrompt')}
                confirmText={translate('workspace.bankAccount.updateToUSD')}
                cancelText={translate('common.cancel')}
                danger
            />

App/src/pages/workspace/invoices/WorkspaceInvoiceVBASection.tsx

Lines 218 to 232 in 47b6fdd

	<ConfirmModal
	isVisible={showConfirmDeleteModal}
	onConfirm={() => {
	deletePaymentMethod();
	hideDefaultDeleteMenu();
	}}
	onCancel={hideDefaultDeleteMenu}
	title={translate('walletPage.deleteAccount')}
	prompt={translate('walletPage.deleteConfirmation')}
	confirmText={translate('common.delete')}
	cancelText={translate('common.cancel')}
	shouldShowCancelButton
	danger
	onModalHide={resetSelectedPaymentMethodData}
	/>

2. In onAddBankAccountPress, we should handle currency as well
   Add here this snippet code

        // Check if the workspace currency is supported for global reimbursement
        if (!isCurrencySupportedForGlobalReimbursement((policy?.outputCurrency ?? '') as CurrencyType, isBetaEnabled(CONST.BETAS.GLOBAL_REIMBURSEMENTS_ON_ND))) {
            setIsUpdateWorkspaceCurrencyModalOpen(true);
            return;
        }

        // If there are existing eligible bank accounts and no in-progress setup, navigate to connect existing account
        if (hasValidExistingAccounts && !shouldShowContinueModal) {
            Navigation.navigate(ROUTES.WORKSPACE_WORKFLOWS_CONNECT_EXISTING_BANK_ACCOUNT.getRoute(policyID));
            return;
        }

App/src/pages/workspace/invoices/WorkspaceInvoiceVBASection.tsx

Line 142 in 47b6fdd

}

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021978848806837670726

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk (External)

[melvin-bot]

@brunovjk Whoops! This issue is 2 days overdue. Let's get this updated quick!