[Due for payment 2025-10-31] [$250] Expensify Card - More button is shown when there is only one option in More button

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.31-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #65959
Email or phone of affected tester (no customers): applausetester+141001kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

• Workspace is set up with Expensify Card feature.

1. Go to staging.new.expensify.com
2. Go to workspace settings > Expensify Card.
3. Click More.

Expected Result:

Only Settings button will be displayed instead of More button because there is only one option in More button (according to #65959).

Actual Result:

More button is shown when there is only one option in More button.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6975154_1760496307643.expensify_card.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021978574984948865415
• Upwork Job ID: 1978574984948865415
• Last Price Increase: 2025-10-15
• Automatic offers:
• etCoderDysto | Contributor | 109200981

Issue Owner

Current Issue Owner: @NicMendonca

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

More button is shown when there is only one option in More button.

What is the root cause of that problem?

We're passing shouldAlwaysShowDropdownMenu as true here

App/src/pages/workspace/expensifyCard/WorkspaceExpensifyCardListPage.tsx

Line 140 in 5c27729

shouldAlwaysShowDropdownMenu

What changes do you think we should make in order to solve the problem?

We should pass it as false or remove this line. We can also fix other places which have the same problem

App/src/pages/workspace/expensifyCard/WorkspaceExpensifyCardListPage.tsx

Line 140 in 5c27729

shouldAlwaysShowDropdownMenu

Note: We can complete other styles in the PR.

One more thing, we can remove shouldUseOptionIcon prop since when only one option is displayed, we always want to display the option's icon or the custom icon prop

icon={!shouldShowButtonRightIcon ? options.at(0)?.icon : icon ?? options.at(0)?.icon}

App/src/components/ButtonWithDropdownMenu/index.tsx

Line 243 in 5c27729

icon={shouldUseOptionIcon && !shouldShowButtonRightIcon ? options.at(0)?.icon : icon}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[etCoderDysto]

Proposal

Please re-state the problem that we are trying to solve in this issue.

More button is shown when there is only one option in More button

What is the root cause of that problem?

We are passing shouldAlwaysShowDropdownMenu prop here

App/src/pages/workspace/expensifyCard/WorkspaceExpensifyCardListPage.tsx

Lines 137 to 145 in 5c27729

	<ButtonWithDropdownMenu
	success={false}
	onPress={() => {}}
	shouldAlwaysShowDropdownMenu
	customText={translate('common.more')}
	options={secondaryActions}
	isSplitButton={false}
	wrapperStyle={isEmptyObject(cardsList) ? styles.flexGrow1 : styles.flexGrow0}
	/>

What changes do you think we should make in order to solve the problem?

We should remove shouldAlwaysShowDropdownMenu prop, and we should pass shouldUseOptionIcon so that the setting icon is displayed on the button

Note: The settings icon won't be displayed if we don't pass shouldUseOptionIcon
Result:

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[etCoderDysto]

Note

For C+ the first proposal was updated to include the left icon issue after I posted a proposal. And mentioning such a difference should be handled in PR phase is not fair considering that our proposals are posted in seconds difference. And my approach is used on other places as company cards too.

App/src/pages/workspace/companyCards/WorkspaceCompanyCardsListHeaderButtons.tsx

Lines 140 to 148 in 5c27729

	<ButtonWithDropdownMenu
	success={false}
	onPress={() => {}}
	shouldUseOptionIcon
	customText={translate('common.more')}
	options={secondaryActions}
	isSplitButton={false}
	wrapperStyle={shouldShowAssignCardButton ? styles.flexGrow0 : styles.flex1}
	/>

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021978574984948865415

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[parasharrajat]

Both proposals are correct and were posted almost at the same time, but the first proposal lacked completeness as an icon change would have been required in the PR, so it should have been mentioned in the proposal. Due to completeness over quickness, I think we can let @etCoderDysto implement this change. @etCoderDysto's proposal sounds good.

🎀 👀 🎀 C+ reviewed