Report-Submit button is displayed with disabled 'Submission frequency'

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.30-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #72033
Email or phone of affected tester (no customers): ndk.2303+new244@gmail.com
Issue reported by: Applause Internal Team
Device used: Windows 11 Home/Chrome
App Component: Workspace Settings

Action Performed:

1. Open https://staging.new.expensify.com/
2. Navigatte to Workspace setting > Workflow
3. Disable 'Submission frequence' and 'Approval'
4. Navigate to Workspace chat
5. Create an expense

Expected Result:

'Pay' button should be displayed after creating expense

Actual Result:

'Submit' button is still displayed after creating expense

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6974186_1760416838407.submit_button_display.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[NJ-2020]

I think this is expected based on this PR

[mountiny]

@trjExpensify Could you please double check if this one is expected?

[trjExpensify]

Mhm, this looks different. The other issue/PR linked was addressing an issue whereby a draft report exists.

Anyhow, the workspace set up here appears to be:

• autoReporting: false (Submission frequency disabled)
• approvals: disabled
• payments: enabled

So I think the question here is; why did the new expense create an open draft report, and not create the expense unreported?

The first place I'd probably look is at the account's personal policy on OldDot, to check if a submission frequency is set. If so, then that drives autoReporting in lieu of the workspace having none.

CC: @s77rt for general vis on this should it be autoReporting related.

[melvin-bot]

@abekkala Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[s77rt]

👋 @trjExpensify

So I think the question here is; why did the new expense create an open draft report, and not create the expense unreported?

The expense was created from the chat and not the global create. In this case we'd create the expense reported.

[s77rt]

I don't think we have a bug here? Disabling the submission freuqnecy is not equivalent to setting it to instant submit.

[trjExpensify]

The expense was created from the chat and not the global create. In this case we'd create the expense reported.

Ahhh okay, gotcha.. fixed destination. Cool 👍

I don't think we have a bug here? Disabling the submission freuqnecy is not equivalent to setting it to instant submit.

Yep, I agree on that part.

Closing!