[Due for payment 2025-10-22] Tags - Tag icon on upgrade page is black

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.29-5
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exp
Email or phone of affected tester (no customers): sdoisnosjdsojnsiod@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Workspace Settings

Action Performed:

1. Go to staging.new.expensify.com
2. Create a workspace.
3. Go to workspace settings > More features.
4. Enable Tags.
5. Go to Tags.
6. Click Import.
7. Select Multi-level tags.

Expected Result:

Tag icon on upgrade screen will show the correct icon.

Actual Result:

Tag icon on upgrade screen shows a black icon.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6973642_1760366081716.Screen_Recording_2025-10-13_at_22.32.10.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @Krishna2323

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @inimaga (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The multi-level tags upgrade screen is showing a flat black tag icon instead of the yellow illustration that matches the rest of the upgrade art. This makes the upgrade prompt feel broken and out of place.

What is the root cause of that problem?

The icon loader logic picks assets from the illustrationIcons map before checking illustrations. The Tag asset exists in both maps, but the version in illustrationIcons renders as a monochrome SVG, so the UI never reaches the colored illustration.

App/src/pages/workspace/upgrade/UpgradeIntro.tsx

Lines 96 to 103 in 42d0574

	const isIllustration = feature.icon in illustrations;
	const isIllustrationIcon = feature.icon in illustrationIcons;
	let iconSrc;
	if (isIllustrationIcon) {
	iconSrc = illustrationIcons[feature.icon as keyof typeof illustrationIcons];
	} else if (isIllustration) {
	iconSrc = illustrations[feature.icon as keyof typeof illustrations];
	}

What changes do you think we should make in order to solve the problem?

Flip the selection order so that we prefer the illustration set when it is available, and only fall back to the icon set when an illustration does not exist. That guarantees that the multi-level tags feature uses the yellow tag art while keeping the avatar fallback for other icons.

const isIllustration = feature.icon in illustrations;
const isIllustrationIcon = feature.icon in illustrationIcons;
let iconSrc;
if (isIllustration) {
    iconSrc = illustrations[feature.icon as keyof typeof illustrations];
} else if (isIllustrationIcon) {
    iconSrc = illustrationIcons[feature.icon as keyof typeof illustrationIcons];
}