[$250] Full story : Reports appear in ToDo > Submit but missing Submit button until user clicks into the report

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation (hyperlinked to channel name): #Migrate

Action Performed:

1. Migrate an existing user to New Expensify
2. After migration completes, open ToDo > Submit list
3. Observe that multiple reports appear in the list
4. Note that some reports don’t display the “Submit” button on the list view
5. Click into one of those reports
6. The Submit button appears inside the report view

Expected Result:

Only reports requiring submission should appear in ToDo > Submit. Each listed report should show the Submit button consistently in the list view.

Actual Result:

Reports are listed in ToDo > Submit without the Submit button. The button only becomes visible after clicking into the report.

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

The screenshots and link for FS are in OP

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021975912589131035819
• Upwork Job ID: 1975912589131035819
• Last Price Increase: 2025-10-08

Issue Owner

Current Issue Owner: @Krishna2323

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021975912589131035819

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Krishna2323 (External)

[dragonking20021215-cell]

Hi there,

thanks for the clear write-up.

I’ve handled similar cross-platform UI quirks in finance and expense tools, including an Electron desktop client and a Capacitor mobile app where action buttons disappeared in list views after account migrations. T
hat experience maps closely to what you’re seeing.

Here is exactly how I’d tackle this, step by step:

1.Reproduce in staging with a fresh migrated user and a seeded account, capturing HAR, device logs, and UI state snapshots for list vs detail.

2.Compare API responses for each report object in ToDo vs inside the report, looking for mismatched fields like state, policy role, or submitEligibility.

3.Inspect the list item component to see if it derives button visibility from cached data or an incomplete selector while the detail screen recomputes it correctly.

4.Force state refreshes after migration and after report fetches, checking for race conditions or stale stores that hide the button in the list.

5.Validate platform parity by running the same flows on Android app, iOS app, desktop, and mWeb, recording any divergence.

6.Draft a minimal fix proposal, for example unifying the eligibility check, adding a post-migration invalidate, and writing a regression test that asserts the button renders in list for eligible reports.

7.Share a concise report with repro steps, root cause, screenshots, and a PR or patch notes for review.

Deliverables would include a reproducible case, a short video, a root-cause summary, and a fix recommendation with test coverage. I can usually turn around the first repro report in 1 business day and a candidate fix proposal within 2 to 3 days, depending on access to staging data and build pipelines.

If that works for you, please confirm which environments I should target first and whether I’ll have access to the internal Slack thread and the Stack Overflow logs reference. I’m ready to start.

Best regard.

[melvin-bot]

📣 @dragonking20021215-cell! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Reports are listed in ToDo > Submit without the Submit button. The button only becomes visible after clicking into the report.

What is the root cause of that problem?

I can reproduce this bug in two cases, with the precondition is manual submission is disabled.

• Case 1: The report is retracted
• Case 2: No other conditions

For case 1: the report data in the snapshot doesn't return hasReportBeenReopened, hasReportBeenRetracted data then we need to get the reportActions to check this condition. Because the expense report is not loaded fully, the retracted action isn't returned which casuse this condition failure

App/src/libs/actions/IOU.ts

Line 9843 in b107cee

const hasBeenRetracted = hasReportBeenReopened(report, reportActions) || hasReportBeenRetracted(report, reportActions);

For case 2: We returned false here if manual submission isn't enabled

App/src/libs/actions/IOU.ts

Line 9848 in b107cee

return baseCanSubmit && isManualSubmitEnabled;

What changes do you think we should make in order to solve the problem?

For case 1: The backend should return hasReportBeenReopened, hasReportBeenRetracted data for the report in snapshot

App/src/libs/actions/IOU.ts

Line 9843 in b107cee

const hasBeenRetracted = hasReportBeenReopened(report, reportActions) || hasReportBeenRetracted(report, reportActions);

For case 2: We should remove isManualSubmitEnabled condition here since we can still submit the report even if manual submission is disabled. Or we can define a new parameter shouldAllowScheduledSubmit and pass it as true here

App/src/libs/actions/IOU.ts

Line 9848 in b107cee

return baseCanSubmit && isManualSubmitEnabled;

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Update canSubmitReport test to verify it works for these cases

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.