User land on Manual tab instead of Distance tab when going back from confirmation page

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.23-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exploratory issue around #71746
Email or phone of affected tester (no customers): kiatest.80+ck103251@gmail.com
Issue reported by: Applause Internal Team
Device used: Windows 11/Chrome, iPhone 16/iOS 18.3.1, Pixel 8a/Android 15
App Component: Money Requests

Action Performed:

1. Navigate to staging.new.expensify.com
2. Create a group chat with two new users.
3. Tap + > Split expense > Distance >> Enter waypoints > Next
4. Observe Confirm details page is displayed
5. Tap RHP back button

Expected Result:

User should land on Distance tab displaying expense details

Actual Result:

User land on Manual tab instead of Distance tab when going back from confirmation page. Entered waypoints are cleared when selecting Distance tab again & user has to again enter the waypoints

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

11.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

User land on Manual tab instead of Distance tab when going back from confirmation page

What is the root cause of that problem?

getRequestType incorrectly identifies transactions with iouRequestType = DISTANCE as manual requests instead of distance requests, because its missing the CONST.IOU.REQUEST_TYPE.DISTANCE check

App/src/libs/TransactionUtils/index.ts

Lines 219 to 234 in b1a83aa

	function getRequestType(transaction: OnyxEntry<Transaction>): IOURequestType {
	if (isManualDistanceRequest(transaction)) {
	return CONST.IOU.REQUEST_TYPE.DISTANCE_MANUAL;
	}
	if (isMapDistanceRequest(transaction)) {
	return CONST.IOU.REQUEST_TYPE.DISTANCE_MAP;
	}
	if (isScanRequest(transaction)) {
	return CONST.IOU.REQUEST_TYPE.SCAN;
	}
	if (isPerDiemRequest(transaction)) {
	return CONST.IOU.REQUEST_TYPE.PER_DIEM;
	}
	return CONST.IOU.REQUEST_TYPE.MANUAL;
	}

What changes do you think we should make in order to solve the problem?

Add a check for CONST.IOU.REQUEST_TYPE.DISTANCE

function getRequestType(transaction: OnyxEntry<Transaction>): IOURequestType {
    if (isManualDistanceRequest(transaction)) {
        return CONST.IOU.REQUEST_TYPE.DISTANCE_MANUAL;
    }
    if (isMapDistanceRequest(transaction)) {
        return CONST.IOU.REQUEST_TYPE.DISTANCE_MAP;
    }
    if (isDistanceRequest(transaction)) {
        return CONST.IOU.REQUEST_TYPE.DISTANCE;
    }
...

App/src/libs/TransactionUtils/index.ts

Lines 219 to 234 in b1a83aa

	function getRequestType(transaction: OnyxEntry<Transaction>): IOURequestType {
	if (isManualDistanceRequest(transaction)) {
	return CONST.IOU.REQUEST_TYPE.DISTANCE_MANUAL;
	}
	if (isMapDistanceRequest(transaction)) {
	return CONST.IOU.REQUEST_TYPE.DISTANCE_MAP;
	}
	if (isScanRequest(transaction)) {
	return CONST.IOU.REQUEST_TYPE.SCAN;
	}
	if (isPerDiemRequest(transaction)) {
	return CONST.IOU.REQUEST_TYPE.PER_DIEM;
	}
	return CONST.IOU.REQUEST_TYPE.MANUAL;
	}

We can also create a separate function to check specifically for CONST.IOU.REQUEST_TYPE.DISTANCE, since currently isDistanceRequest checks for all three distance request types

What alternative solutions did you explore? (Optional)

None

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Users creating a distance split expense can add waypoints on the Distance tab, proceed to the confirmation page, and then back out. Instead of returning to the same Distance tab with their map data intact, the flow navigates to the Manual tab.

What is the root cause of that problem?

When a draft distance expense is created, it is stored in Onyx with iouRequestType: 'distance'. The helper that drives downstream behavior (getRequestType) attempts to classify the expense more precisely (map vs manual) and overwrites the legacy distance value. Because DistanceRequestStartPage stores the tab selection in Onyx, the transformed request type causes the navigator to select the wrong tab and the map waypoints to be reset the next time the screen mounts. The legacy request type also determines tab titles, so forcing it to distance-map swaps the order and label.

App/src/libs/TransactionUtils/index.ts

Lines 174 to 192 in 68ce6bf

	function isMapDistanceRequest(transaction: OnyxEntry<Transaction>): boolean {
	// This is used during the expense creation flow before the transaction has been saved to the server
	if (lodashHas(transaction, 'iouRequestType')) {
	return transaction?.iouRequestType === CONST.IOU.REQUEST_TYPE.DISTANCE_MAP;
	}
	// This is the case for transaction objects once they have been saved to the server
	return hasDistanceCustomUnit(transaction);
	}
	function isManualDistanceRequest(transaction: OnyxEntry<Transaction>): boolean {
	// This is used during the expense creation flow before the transaction has been saved to the server
	if (lodashHas(transaction, 'iouRequestType')) {
	return transaction?.iouRequestType === CONST.IOU.REQUEST_TYPE.DISTANCE_MANUAL;
	}
	// This is the case for transaction objects once they have been saved to the server
	return hasDistanceCustomUnit(transaction) && isEmptyObject(transaction?.comment?.waypoints);
	}

App/src/libs/TransactionUtils/index.ts

Lines 219 to 234 in 68ce6bf

	function getRequestType(transaction: OnyxEntry<Transaction>): IOURequestType {
	if (isManualDistanceRequest(transaction)) {
	return CONST.IOU.REQUEST_TYPE.DISTANCE_MANUAL;
	}
	if (isMapDistanceRequest(transaction)) {
	return CONST.IOU.REQUEST_TYPE.DISTANCE_MAP;
	}
	if (isScanRequest(transaction)) {
	return CONST.IOU.REQUEST_TYPE.SCAN;
	}
	if (isPerDiemRequest(transaction)) {
	return CONST.IOU.REQUEST_TYPE.PER_DIEM;
	}
	return CONST.IOU.REQUEST_TYPE.MANUAL;
	}

What changes do you think we should make in order to solve the problem?

Update the distance request helpers so that they continue to detect map/manual without mutating the original request type. If iouRequestType is still the legacy 'distance', the helper should return that value while the lower-level predicates (isMapDistanceRequest / isManualDistanceRequest) use waypoint presence to provide more detail.

// src/libs/TransactionUtils/index.ts
function isMapDistanceRequest(transaction: OnyxEntry<Transaction>): boolean {
    if (lodashHas(transaction, 'iouRequestType')) {
        const requestType = transaction?.iouRequestType;
        if (requestType === CONST.IOU.REQUEST_TYPE.DISTANCE) {
            const waypoints = transaction?.comment?.waypoints;
            return !isEmptyObject(waypoints);
        }

        return requestType === CONST.IOU.REQUEST_TYPE.DISTANCE_MAP;
    }

    return hasDistanceCustomUnit(transaction);
}

function isManualDistanceRequest(transaction: OnyxEntry<Transaction>): boolean {
    if (lodashHas(transaction, 'iouRequestType')) {
        const requestType = transaction?.iouRequestType;
        if (requestType === CONST.IOU.REQUEST_TYPE.DISTANCE) {
            const waypoints = transaction?.comment?.waypoints;
            return isEmptyObject(waypoints);
        }

        return requestType === CONST.IOU.REQUEST_TYPE.DISTANCE_MANUAL;
    }

    return hasDistanceCustomUnit(transaction) && isEmptyObject(transaction?.comment?.waypoints);
}

function getRequestType(transaction: OnyxEntry<Transaction>): IOURequestType {
    if (transaction?.iouRequestType === CONST.IOU.REQUEST_TYPE.DISTANCE) {
        return CONST.IOU.REQUEST_TYPE.DISTANCE;
    }
    if (isManualDistanceRequest(transaction)) {
        return CONST.IOU.REQUEST_TYPE.DISTANCE_MANUAL;
    }
    if (isMapDistanceRequest(transaction)) {
        return CONST.IOU.REQUEST_TYPE.DISTANCE_MAP;
    }
    if (isScanRequest(transaction)) {
        return CONST.IOU.REQUEST_TYPE.SCAN;
    }
    if (isPerDiemRequest(transaction)) {
        return CONST.IOU.REQUEST_TYPE.PER_DIEM;
    }

    return CONST.IOU.REQUEST_TYPE.MANUAL;
}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

• Legacy distance draft with waypoints: ensure isMapDistanceRequest is true, isManualDistanceRequest is false, and getRequestType returns 'distance'.
• Legacy distance draft without waypoints: ensure isManualDistanceRequest is true, isMapDistanceRequest is false, and getRequestType returns 'distance'.

[melvin-bot]

@JmillsExpensify Still overdue 6 days?! Let's take care of this!

[melvin-bot]

@JmillsExpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[JmillsExpensify]

Not a priority flow right now.