[Due for payment 2025-12-16] [$250] Re-enabling the Categories feature doesn't re-enable category values or set categories required.

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.21-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/test-runs/TR-1104/folder/13176818/41237262/927169718
Email or phone of affected tester (no customers): ibellicotest+1875@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 / Android 12 / Chrome ( mWeb / Hybrid app) - Windows 11 / Chrome
App Component: Money Requests

Action Performed:

1. Go to Workspaces
2. Create a new workspace
3. Go to Categories
4. Observe all category values are enabled
5. Click on Settings
6. Observe "categories are required" setting is enabled
7. Go to More features
8. Disable Categories feature
9. Re-enable Categories feature
10. Go to Categories
11. Observe all category values are disabled
12. Click on Settings
13. Observe "categories are required" setting is disabled.

Expected Result:

When you disable Categories as a feature in More features and re-enable it again, we should 1) enable all of the category values again and 2) set categories to required again.

Actual Result:

We don't re-enable the category values and we don't set categories to required again.

Workaround:

Manually re-enable them.

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

2025-10-01_12-41-41.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021975156415154450087
• Upwork Job ID: 1975156415154450087
• Last Price Increase: 2025-10-06
• Automatic offers:
• linhvovan29546 | Reviewer | 109203858
• NJ-2020 | Contributor | 109203859

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Report - "Missing Category" seen when enabling "Categories" and all categories are disabled

What is the root cause of that problem?

When enabling categories, we automatically sets requiresCategory: true

App/src/libs/actions/Policy/Category.ts

Lines 1109 to 1115 in fa5e06d

	const policyUpdate: Partial<Policy> = {
	areCategoriesEnabled: enabled,
	requiresCategory: enabled,
	pendingFields: {
	areCategoriesEnabled: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
	},
	};

When categories are enabled:

• All categories return enabled: true
• policy.requiresCategory becomes true
• Existing transactions that don't have categories get "missingCategory" violations

App/src/libs/Violations/ViolationsUtils.ts

Lines 256 to 282 in fa5e06d

	const policyRequiresCategories = !!policy.requiresCategory;
	if (policyRequiresCategories) {
	const hasCategoryOutOfPolicyViolation = transactionViolations.some((violation) => violation.name === 'categoryOutOfPolicy');
	const hasMissingCategoryViolation = transactionViolations.some((violation) => violation.name === 'missingCategory');
	const categoryKey = updatedTransaction.category;
	const isCategoryInPolicy = categoryKey ? policyCategories?.[categoryKey]?.enabled : false;
	// Add 'categoryOutOfPolicy' violation if category is not in policy
	if (!hasCategoryOutOfPolicyViolation && categoryKey && !isCategoryInPolicy) {
	newTransactionViolations.push({name: 'categoryOutOfPolicy', type: CONST.VIOLATION_TYPES.VIOLATION});
	}
	// Remove 'categoryOutOfPolicy' violation if category is in policy
	if (hasCategoryOutOfPolicyViolation && updatedTransaction.category && isCategoryInPolicy) {
	newTransactionViolations = reject(newTransactionViolations, {name: 'categoryOutOfPolicy'});
	}
	// Remove 'missingCategory' violation if category is valid according to policy
	if (hasMissingCategoryViolation && isCategoryInPolicy) {
	newTransactionViolations = reject(newTransactionViolations, {name: 'missingCategory'});
	}
	// Add 'missingCategory' violation if category is required and not set
	if (!hasMissingCategoryViolation && policyRequiresCategories && !categoryKey) {
	newTransactionViolations.push({name: 'missingCategory', type: CONST.VIOLATION_TYPES.VIOLATION, showInReview: true});
	}
	}

What changes do you think we should make in order to solve the problem?

Enabling categories should not automatically make them required. We can change the enablePolicyCategories function to not automatically set requiresCategory: true when enabling categories. Instead, only set requiresCategory: false when disabling categories

    const policyUpdate: Partial<Policy> = {
        areCategoriesEnabled: enabled,
        ...(enabled ? {} : {requiresCategory: false}),
        pendingFields: {
            areCategoriesEnabled: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
        },
    };

App/src/libs/actions/Policy/Category.ts

Lines 1109 to 1115 in fa5e06d

	const policyUpdate: Partial<Policy> = {
	areCategoriesEnabled: enabled,
	requiresCategory: enabled,
	pendingFields: {
	areCategoriesEnabled: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
	},
	};

Additionally, when enabling categories, we can set all individual categories to enabled: false

    const policyCategoriesUpdate: Record<string, Partial<PolicyCategory>> = Object.fromEntries(
        Object.entries(policyCategories).map(([categoryName]) => [categoryName, {name: categoryName, enabled: false}]),
    );

App/src/libs/actions/Policy/Category.ts

Lines 1119 to 1121 in fa5e06d

	const policyCategoriesUpdate: Record<string, Partial<PolicyCategory>> = Object.fromEntries(
	Object.entries(policyCategories).map(([categoryName]) => [categoryName, {name: categoryName, enabled}]),
	);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

None

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Missing Category" error message appears on expenses report preview, after the "Category" feature is enabled, despite all the categories being still disabled. RBR is also displayed on workspace chat preview on LHN.
Error message and RBR disappear after opening expenses report.

What is the root cause of that problem?

We set the requiresCategory to true when enabling the policy categories feature here, which causes the violation to be added unexpectedly

App/src/libs/actions/Policy/Category.ts

Lines 1109 to 1123 in fa5e06d

	const policyUpdate: Partial<Policy> = {
	areCategoriesEnabled: enabled,
	requiresCategory: enabled,
	pendingFields: {
	areCategoriesEnabled: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
	},
	};
	const policyCategories = allPolicyCategories?.[`${ONYXKEYS.COLLECTION.POLICY_CATEGORIES}${policyID}`] ?? {};
	const policyCategoriesUpdate: Record<string, Partial<PolicyCategory>> = Object.fromEntries(
	Object.entries(policyCategories).map(([categoryName]) => [categoryName, {name: categoryName, enabled}]),
	);
	pushTransactionViolationsOnyxData(onyxData, policyID, policyTagLists, policyCategories, allTransactionViolations, policyUpdate, policyCategoriesUpdate);

What changes do you think we should make in order to solve the problem?

It's unnecessary to call pushTransactionViolationsOnyxData when enabling the category feature, because at this time, all categories are disabled. It does a better performance because pushTransactionViolationsOnyxData will update all transactions related to the policy.

We also need to update requiresCategory in policyUpdate correctly

const policyUpdate: Partial<Policy> = {
        areCategoriesEnabled: enabled,
        ...(enabled ? {} : {requiresCategory: false}),
        pendingFields: {
            areCategoriesEnabled: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
        },
    };

if (!enabled) {
        pushTransactionViolationsOnyxData(onyxData, policyID, policyTagLists, policyCategories, allTransactionViolations, policyUpdate, policyCategoriesUpdate);
    }

App/src/libs/actions/Policy/Category.ts

Lines 1109 to 1123 in fa5e06d

	const policyUpdate: Partial<Policy> = {
	areCategoriesEnabled: enabled,
	requiresCategory: enabled,
	pendingFields: {
	areCategoriesEnabled: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
	},
	};
	const policyCategories = allPolicyCategories?.[`${ONYXKEYS.COLLECTION.POLICY_CATEGORIES}${policyID}`] ?? {};
	const policyCategoriesUpdate: Record<string, Partial<PolicyCategory>> = Object.fromEntries(
	Object.entries(policyCategories).map(([categoryName]) => [categoryName, {name: categoryName, enabled}]),
	);
	pushTransactionViolationsOnyxData(onyxData, policyID, policyTagLists, policyCategories, allTransactionViolations, policyUpdate, policyCategoriesUpdate);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Add enablePolicyCategories test and verify that the violation is not added when enabling the policy category

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[NJ-2020]

🚨 Edited by proposal-police: This proposal was edited at 2025-10-06 12:24:25 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Re-enabling the Categories feature doesn't re-enable category values or set categories required

What is the root cause of that problem?

We don't enable category (individually/all) to true when enabling Categories feature

App/src/libs/actions/Policy/Category.ts

Lines 1059 to 1119 in 7585b7f

	const onyxUpdatesToDisableCategories: OnyxUpdate[] = [];
	if (!enabled) {
	onyxUpdatesToDisableCategories.push(
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.POLICY_CATEGORIES}${policyID}`,
	value: Object.fromEntries(
	Object.entries(policyCategories).map(([categoryName]) => [
	categoryName,
	{
	enabled: false,
	},
	]),
	),
	},
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
	value: {
	requiresCategory: false,
	},
	},
	);
	}
	const onyxData: OnyxData = {
	optimisticData: [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
	value: {
	areCategoriesEnabled: enabled,
	pendingFields: {
	areCategoriesEnabled: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
	},
	},
	},
	],
	successData: [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
	value: {
	pendingFields: {
	areCategoriesEnabled: null,
	},
	},
	},
	],
	failureData: [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
	value: {
	areCategoriesEnabled: !enabled,
	pendingFields: {
	areCategoriesEnabled: null,
	},
	},
	},
	],
	};

What changes do you think we should make in order to solve the problem?

We should enable all category lists based on the enabled toggle parameter boolean value

function enablePolicyCategories(
    policyID: string,
    enabled: boolean,
    policyTagLists: PolicyTagLists = {},
    policyCategories: PolicyCategories = {},
    allTransactionViolations: OnyxCollection<TransactionViolations> = {},
    shouldGoBack = true,
) {
    const onyxData: OnyxData = {
        optimisticData: [
            {
                onyxMethod: Onyx.METHOD.MERGE,
                key: `${ONYXKEYS.COLLECTION.POLICY_CATEGORIES}${policyID}`,
                value: Object.fromEntries(
                    Object.entries(policyCategories).map(([categoryName]) => [
                        categoryName,
                        {
                            enabled,
                        },
                    ]),
                ),
            },
            {
                onyxMethod: Onyx.METHOD.MERGE,
                key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
                value: {
                    areCategoriesEnabled: enabled,
                    requiresCategory: enabled,
                    pendingFields: {
                        areCategoriesEnabled: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
                    },
                },
            },
        ],
        successData: [
            {
                onyxMethod: Onyx.METHOD.MERGE,
                key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
                value: {
                    pendingFields: {
                        areCategoriesEnabled: null,
                    },
                },
            },
        ],
        failureData: [
            {
                onyxMethod: Onyx.METHOD.MERGE,
                key: `${ONYXKEYS.COLLECTION.POLICY_CATEGORIES}${policyID}`,
                value: Object.fromEntries(
                    Object.entries(policyCategories).map(([categoryName]) => [
                        categoryName,
                        {
                            enabled: !enabled,
                        },
                    ]),
                ),
            },
            {
                onyxMethod: Onyx.METHOD.MERGE,
                key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
                value: {
                    requiresCategory: !enabled,
                    areCategoriesEnabled: !enabled,
                    pendingFields: {
                        areCategoriesEnabled: null,
                    },
                },
            },
        ],
    };

    const policyUpdate: Partial<Policy> = {
        areCategoriesEnabled: enabled,
        requiresCategory: enabled,
        pendingFields: {
            areCategoriesEnabled: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
        },
    };

    ...
}

We need to align it with the BE changes as well.

Result

Screen.Recording.2025-10-06.at.19.22.45.mov

What alternative solutions did you explore? (Optional)

N/A

[muhammad-ali-abbasi]

1. Problem Statement

When categories are enabled on a policy, the system currently sets requiresCategory: true by default. This has two side effects:

• All transactions without a category are flagged with a missingCategory violation.
• Users see “Missing Category” errors even if they simply wanted to enable categories without making them mandatory.

This behavior is unintuitive and creates unnecessary noise for end users.

---

2. Root Cause

The logic in App/src/libs/actions/Policy/Category.ts (lines 1109–1115) automatically forces categories to be required whenever they are enabled:

const policyUpdate: Partial<Policy> = { 
    areCategoriesEnabled: enabled, 
    requiresCategory: enabled,   // problem line 
    pendingFields: { 
        areCategoriesEnabled: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE, 
    }, 
};

Because requiresCategory is tied directly to enabled, the system assumes that all transactions must have a category once categories are switched on.

---

3. Proposed Solution

We recommend removing the automatic requirement and hardcoding requiresCategory: false when updating policies:

const policyUpdate: Partial<Policy> = {
    areCategoriesEnabled: enabled,
    requiresCategory: false,   // changed: no longer auto-required
    pendingFields: {
        areCategoriesEnabled: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
    },
};

With this change:

• Enabling categories will no longer trigger missingCategory violations on existing transactions.
• Admins can still later choose to enforce category requirements explicitly.

---

4. Expected Impact

• ✅ No sudden missingCategory violations when enabling categories.
• ✅ Cleaner onboarding for admins who want to configure categories gradually.
• ✅ Transactions without categories remain valid until requirements are explicitly turned on.

---

6. Alternatives Considered

Earlier approaches involved conditional logic (e.g., only setting requiresCategory to false when disabling). However, this simpler fix achieves the same outcome with less complexity.

[trjExpensify]

Mhm, the test case linked in the OP is about testing that enabling categories in the workspace shows the category field on an expense. It doesn't cover conditions for violations being displayed etc so it hasn't failed an expected test per se.

Working through this..

• When enabling categories on the workspace it's expected to set categories to required (internal ref). -- CC: @garrettmknight
• When categories are required on the workspace, you can't manually disable them all, which is expected:

2025-10-01_12-39-19.mp4

• As such, when you disable Categories as a feature in More features and re-enable it again, I'd think we should 1) enable all of the category values again and 2) set categories to required again. That's not happening:

2025-10-01_12-41-41.mp4

That's what we need to focus on fixing here, I'd say. CC: @Expensify/product-pr for additional eyes.

[joekaufmanexpensify]

I'm good with that.

[trjExpensify]

Alright, thanks. I've spruced the OP to reflect that... sending external.