[Due for payment 2025-10-21] [$250] Reports - "New Messages" badge on report, opens the same report again.

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.19-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/test-runs/TR-962/folder/13176670/41237099/920382469
Email or phone of affected tester (no customers): ibellicotest+1852@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 / Android 12 / Chrome ( mWeb / Hybrid app) - Windows 11 / Chrome
App Component: Money Requests

Action Performed:

Prerequisite: Account has at least one workspace available.

1. Open the Expensify app.
2. Open any workspace chat.
3. Create a manual expense.
4. Create a new report but don´t add any expense to it.
5. Navigate to "Reports"
6. Open the expense created on step 3.
7. Tap on report field and select the report created on step 4.
8. Return to "Reports" and open the report where the expense was moved.
9. Scroll to the top of report.
10. Tap on the "New Messages" badge.
11. Note that same report is reopened.
12. Tap on the arrow on the top left corner.
13. Note that you land on the same report again.

Expected Result:

Tapping on the "New Messages" badge on report, should redirect to the last message on the expense report.

Actual Result:

Tapping on the "New Messages" badge on report, after changing the report of an expense. reopens the same report again, and the user has to close it twice to return to "Reports".

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

11.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021972781322305901203
• Upwork Job ID: 1972781322305901203
• Last Price Increase: 2025-09-29

Issue Owner

Current Issue Owner: @sakluger

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tapping on the "New Messages" badge on report, after changing the report of an expense. reopens the same report again, and the user has to close it twice to return to "Reports".

What is the root cause of that problem?

We are navigating to the route SEARCH_REPORT or SEARCH_MONEY_REQUEST_REPORT here

App/src/pages/home/report/ReportActionsList.tsx

Lines 529 to 534 in 3a43041

	if (isSearchTopmostFullScreenRoute()) {
	if (Navigation.getReportRHPActiveRoute()) {
	Navigation.navigate(ROUTES.SEARCH_REPORT.getRoute({reportID: report.reportID}));
	} else {
	Navigation.navigate(ROUTES.SEARCH_MONEY_REQUEST_REPORT.getRoute({reportID: report.reportID}));
	}

What changes do you think we should make in order to solve the problem?

1. We should not navigate when we are already in that route (report.id === linkedReportActionID)

            if (isSearchTopmostFullScreenRoute() && report.reportID !== linkedReportActionID) {
                if (Navigation.getReportRHPActiveRoute()) {
                    Navigation.navigate(ROUTES.SEARCH_REPORT.getRoute({reportID: report.reportID}));
                } else {
                    Navigation.navigate(ROUTES.SEARCH_MONEY_REQUEST_REPORT.getRoute({reportID: report.reportID}));
                }
            } else {
                Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(report.reportID));
            }

App/src/pages/home/report/ReportActionsList.tsx

Line 206 in 3a43041

const linkedReportActionID = route?.params?.reportActionID;

App/src/pages/home/report/ReportActionsList.tsx

Lines 529 to 534 in 3a43041

	if (isSearchTopmostFullScreenRoute()) {
	if (Navigation.getReportRHPActiveRoute()) {
	Navigation.navigate(ROUTES.SEARCH_REPORT.getRoute({reportID: report.reportID}));
	} else {
	Navigation.navigate(ROUTES.SEARCH_MONEY_REQUEST_REPORT.getRoute({reportID: report.reportID}));
	}

2. Add linkedReportActionID as a dependency of this useCallback

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[lorretheboy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tapping on the "New Messages" badge on report, after changing the report of an expense. reopens the same report again, and the user has to close it twice to return to "Reports".

What is the root cause of that problem?

When an expense is moved between reports, the report state becomes stale and hasNewestReportAction becomes false. The original code in scrollToBottomAndMarkReportAsRead function would then navigate to the same report again to refresh the data, causing a double navigation issue where users had to press back twice to return to the Reports page.

App/src/pages/home/report/ReportActionsList.tsx

Lines 529 to 537 in 71687df

	if (isSearchTopmostFullScreenRoute()) {
	if (Navigation.getReportRHPActiveRoute()) {
	Navigation.navigate(ROUTES.SEARCH_REPORT.getRoute({reportID: report.reportID}));
	} else {
	Navigation.navigate(ROUTES.SEARCH_MONEY_REQUEST_REPORT.getRoute({reportID: report.reportID}));
	}
	} else {
	Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(report.reportID));
	}

What changes do you think we should make in order to solve the problem?

We should only navigate if we're not already viewing the correct report. This prevents double navigation when the report state is stale (e.g., after moving expenses)

We should not use linkedReportActionID to check if it is equal to report.reportID as it will not always represent for reportID - it identifies a specific message/action within that report. Instead, we can follow the check if user is in the correct route like what we did here.

App/src/libs/actions/Report.ts

Line 1849 in 4acebc7

if (Navigation.getActiveRoute().includes(`/r/${reportID}`)) {

            const currentRoute = Navigation.getActiveRoute();

            // Note: we can create a util func for this check pattern and re-use in all existing places if needed
            const isAlreadyOnCorrectReport = currentRoute.includes(`/r/${report.reportID}`); // Can consider to check currentRoute.includes(`/${report.reportID}`) if we want to do the same on view report in search page

            if (!isAlreadyOnCorrectReport) {
                  ....
            }

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tapping on the "New Messages" badge on report, after changing the report of an expense. reopens the same report again, and the user has to close it twice to return to "Reports".

What is the root cause of that problem?

When users move expense, we don't have the logic to update lastVisibleActionCreated of transactionThread report in changeTransactionsReport, so it's still old value.

That causes hasNewestReportAction = false

App/src/pages/home/report/ReportActionsList.tsx

Line 333 in 3a43041

const hasNewestReportAction = lastAction?.created === lastVisibleActionCreated || isReportPreviewAction(lastAction);

If it's false

App/src/pages/home/report/ReportActionsList.tsx

Lines 525 to 537 in 3a43041

	const scrollToBottomAndMarkReportAsRead = useCallback(() => {
	setIsFloatingMessageCounterVisible(false);
	if (!hasNewestReportAction) {
	if (isSearchTopmostFullScreenRoute()) {
	if (Navigation.getReportRHPActiveRoute()) {
	Navigation.navigate(ROUTES.SEARCH_REPORT.getRoute({reportID: report.reportID}));
	} else {
	Navigation.navigate(ROUTES.SEARCH_MONEY_REQUEST_REPORT.getRoute({reportID: report.reportID}));
	}
	} else {
	Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(report.reportID));
	}

We'll try to navigate

What changes do you think we should make in order to solve the problem?

To fix this issue we should update the lastVisibleActionCreated optimistically

In changeTransactionsReport, when building the movedAction, we should detect if it's the final transaction, then update the lastVisibleActionCreated to be movedAction?.created

App/src/libs/actions/Transaction.ts

Lines 1031 to 1036 in 3a43041

	// 7. Add MOVED_TRANSACTION or UNREPORTED_TRANSACTION report actions
	const movedAction =
	reportID === CONST.REPORT.UNREPORTED_REPORT_ID
	? buildOptimisticUnreportedTransactionAction(transactionThreadReportID, oldReportID)
	: buildOptimisticMovedTransactionAction(transactionThreadReportID, reportID);

let transactionThreadReportID = newIOUAction.childReportID;
        let transactionThreadReport = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${transactionThreadReportID}`];

...

if (index === transactions.length - 1) {
            optimisticData.push({
                onyxMethod: Onyx.METHOD.MERGE,
                key: `${ONYXKEYS.COLLECTION.REPORT}${transactionThreadReportID}`,
                value: {lastVisibleActionCreated: movedAction?.created},
            });
            if (transactionThreadReport) {
            failureData.push({
                onyxMethod: Onyx.METHOD.MERGE,
                key: `${ONYXKEYS.COLLECTION.REPORT}${transactionThreadReportID}`,
                value: {lastVisibleActionCreated: transactionThreadReport?.lastVisibleActionCreated},
            });
            }
        }

We also need to update this logic on BE

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pressing the New message floating badge opens the same report.

What is the root cause of that problem?

When hasNewestReportAction is false, we navigate to the same report but without reportActionID. One reason hasNewestReportAction can happen when we link to an old action so the newest action is not loaded yet, so when pressing New message, we navigate to the same report but without reportActionID, call openReport, and scroll to the bottom.

App/src/pages/home/report/ReportActionsList.tsx

Lines 528 to 540 in 174e69f

	if (!hasNewestReportAction) {
	if (isSearchTopmostFullScreenRoute()) {
	if (Navigation.getReportRHPActiveRoute()) {
	Navigation.navigate(ROUTES.SEARCH_REPORT.getRoute({reportID: report.reportID}));
	} else {
	Navigation.navigate(ROUTES.SEARCH_MONEY_REQUEST_REPORT.getRoute({reportID: report.reportID}));
	}
	} else {
	Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(report.reportID));
	}
	openReport(report.reportID);
	reportScrollManager.scrollToBottom();
	return;

But since the current route has a backTo param, it's detected as a different route, so a new screen is pushed into the stack.

What changes do you think we should make in order to solve the problem?

We can clear the reportActionID using

Navigation.setParams({reportActionID: ''});

just like we did here.

App/src/pages/home/ReportScreen.tsx

Lines 762 to 765 in 174e69f

	const navigateToEndOfReport = useCallback(() => {
	Navigation.setParams({reportActionID: ''});
	fetchReport();
	}, [fetchReport]);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Include the backTo param when navigating.

const backTo = route?.params?.backTo as string;
...
Navigation.navigate(ROUTES.SEARCH_REPORT.getRoute({reportID: report.reportID, backTo}));
Navigation.navigate(ROUTES.SEARCH_MONEY_REQUEST_REPORT.getRoute({reportID: report.reportID, backTo}));

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021972781322305901203