[Due for payment 2025-10-17] [$250] Workspace - Bank account icon has the wrong style in the settlement button

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.18-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dominictb
Slack conversation (hyperlinked to channel name): #expensify_bugs

Action Performed:

1. Navigate to https://staging.new.expensify.com/
2. Create a workspace
3. Go to Workflows page and add a bank account
4. Submit an expense
5. Approve this expense
6. Click on the dropdown button
7. Obverse bank account icon

Expected Result:

Bank account icon should be larger and have a border radius similar to other places.

Actual Result:

Bank account icon is small and square.

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Recording.3430.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021971211017955849130
• Upwork Job ID: 1971211017955849130
• Last Price Increase: 2025-09-25
• Automatic offers:
• dominictb | Contributor | 108922466

[melvin-bot]

Triggered auto assignment to @clarajones-expensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

From @dominictb

Proposal

Please re-state the problem that we are trying to solve in this issue.

Bank account icon has the wrong style in the settlement button

What is the root cause of that problem?

We don't pass the iconStyles and iconSize here

App/src/components/SettlementButton/index.tsx

Lines 240 to 246 in ffe38b1

	if (!isEmpty(latestBankItem) && latestBankItem) {
	buttonOptions.push({
	text: latestBankItem.at(0)?.text ?? '',
	icon: latestBankItem.at(0)?.icon,
	value: CONST.PAYMENT_METHODS.BUSINESS_BANK_ACCOUNT,
	description: latestBankItem.at(0)?.description,
	});

What changes do you think we should make in order to solve the problem?

1. Get the iconStyles and iconSize from the formattedPaymentMethod to latestBankItem

    return policyBankAccounts.map((formattedPaymentMethod) => {
        const {icon, title, description, methodID, iconStyles, iconSize} = formattedPaymentMethod ?? {};
        return {
            ...
            iconStyles,
            iconSize,
        };
    });

App/src/components/SettlementButton/index.tsx

Line 172 in ffe38b1

const latestBankItem = getLatestBankAccountItem();

App/src/components/SettlementButton/index.tsx

Lines 153 to 164 in ffe38b1

	return policyBankAccounts.map((formattedPaymentMethod) => {
	const {icon, title, description, methodID} = formattedPaymentMethod ?? {};
	return {
	text: title ?? '',
	description: description ?? '',
	icon: typeof icon === 'number' ? Bank : icon,
	onSelected: () => onPress(CONST.IOU.PAYMENT_TYPE.EXPENSIFY, true, undefined),
	methodID,
	value: CONST.PAYMENT_METHODS.BUSINESS_BANK_ACCOUNT,
	};
	});

2. Then pass it to buttonOptions like the way we did here

    buttonOptions.push({
        ...
        iconStyles: latestBankItem.at(0)?.iconStyles,
        iconWidth: latestBankItem.at(0)?.iconSize,
        iconHeight: latestBankItem.at(0)?.iconSize,
    });

App/src/components/SettlementButton/index.tsx

Lines 240 to 246 in ffe38b1

	if (!isEmpty(latestBankItem) && latestBankItem) {
	buttonOptions.push({
	text: latestBankItem.at(0)?.text ?? '',
	icon: latestBankItem.at(0)?.icon,
	value: CONST.PAYMENT_METHODS.BUSINESS_BANK_ACCOUNT,
	description: latestBankItem.at(0)?.description,
	});

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

None

[imadirtydog]

Register

[melvin-bot]

📣 @imadirtydog! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[imadirtydog]

Contributor details
Your Expensify account email: misterlovalova1989@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01b5e6e70c5fbe1e02

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021971211017955849130