[HOLD for payment 2022-01-21] Staging Desktop app is not installed when download dmg from staging.new.expensify

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open app on Web
2. Navigate to Settings > About > App download links > MacOS
3. Install the app

Expected Result:

User should be able to install Staging version from Staging.new.expensify.com

Actual Result:

User gets PROD app installed

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• Desktop App

Version Number: 1.1.27-0
Reproducible in staging?: Y
Reproducible in production?: n/a
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1641588228144900

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @flodnv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MelvinBot]

Triggered auto assignment to @jboniface (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[parasharrajat]

Proposal

1. we need to check the Environment from Environment.getEnvironment()

   App/src/libs/Environment/Environment.js

   Line 16 in a2e1cf8

   getEnvironment,

   and then change the URL in

   App/src/CONST.js

   Line 16 in a2e1cf8

   DESKTOP: `${NEW_EXPENSIFY_URL}/NewExpensify.dmg`,

with STAGING_NEW_EXPENSIFY_URL const when the environment is CONST.ENVIRONMENT.STAGING.

Another Method

Use

App/src/CONFIG.js

Line 46 in a2e1cf8

URL_EXPENSIFY_CASH: expensifyCashURL,

Directly in place NEW_EXPENSIFY_URL of

App/src/CONST.js

Line 16 in a2e1cf8

DESKTOP: `${NEW_EXPENSIFY_URL}/NewExpensify.dmg`,

.

I am leaning towards second. I am guessing that we leave the URL to NEW_EXPENSIFY_URL for PROD and DEV environment ??

[jboniface]

https://www.upwork.com/jobs/~0110761aea23dd8881

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)