[Due for payment 2025-10-13] `Enter your credentials` menu item shows when there's no need.

[trjExpensify]

Coming from here.

We're showing the "Enter your credentials" menu item when the connection isn't broken, which is somewhat unnecessary.

In the doc we said:

Should the connection fail or credentials become invalidated, we’ll re-use the RBR pattern we have for accounting integrations. Within the popover menu, an option to Enter your credentials will be included to navigate to Uber to reconnect

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.

[mukhrr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The "Enter your credentials" menu item is being shown for Uber receipt partner connections even when the connection is working properly and credentials are valid.

What is the root cause of that problem?

The receipt partner implementation doesn't check for authentication errors before showing the "Enter your credentials" menu item

App/src/pages/workspace/receiptPartners/WorkspaceReceiptPartnersPage.tsx

Lines 115 to 128 in 5edc01d

	(integration: string) => {
	switch (integration) {
	case CONST.POLICY.RECEIPT_PARTNERS.NAME.UBER:
	return [
	{
	icon: Expensicons.Key,
	text: translate('workspace.accounting.enterCredentials'),
	onSelected: () => startIntegrationFlow({name: CONST.POLICY.RECEIPT_PARTNERS.NAME.UBER}),
	shouldCallAfterModalHide: true,
	disabled: isOffline,
	iconRight: Expensicons.NewWindow,
	},
	{
	icon: Expensicons.Trashcan,

What changes do you think we should make in order to solve the problem?

We have already a check if uber is connected or not:

App/src/pages/workspace/receiptPartners/WorkspaceReceiptPartnersPage.tsx

Line 54 in 5edc01d

const isUberConnected = useIsPolicyConnectedToUberReceiptPartner({policyID});

So we can show the option conditionally here

                    return [
                        ...(!isUberConnected
                            ? [
                                  {
                                      icon: Expensicons.Key,
                                      text: translate('workspace.accounting.enterCredentials'),
                                      onSelected: () => startIntegrationFlow({name: CONST.POLICY.RECEIPT_PARTNERS.NAME.UBER}),
                                      shouldCallAfterModalHide: true,
                                      disabled: isOffline,
                                      iconRight: Expensicons.NewWindow,
                                  },
                              ]
                            : []),

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Alternatively, we can focus on authentication error message instead of uber enabled check

const isUberAuthenticationError = useCallback(() => {
        const uberConnection = policy?.receiptPartners?.uber;

        // Check if there are any authentication-related errors
        const hasAuthenticationErrors = uberConnection?.errors ? Object.values(uberConnection.errors).some((error) => 
            error?.toLowerCase()?.includes('authentication')
        ) : false;
        // Check if there are any authentication-related error fields
        const hasAuthenticationErrorFields = uberConnection?.errorFields ? Object.keys(uberConnection.errorFields).some((field) => 
            field.toLowerCase().includes('authentication')
        ) : false;
        return hasAuthenticationErrors ?? hasAuthenticationErrorFields;
    }, [policy?.receiptPartners?.uber]);

[trjExpensify]

Ah, sorry @mukhrr. We have a project team on this one, @narefyev91 is working on the PR already. 👍

[trjExpensify]

@narefyev91 if #71241 solves this, can we make sure to link the PR to it? Else, we don't get automation.

Do you want to use this issue now for fixing the red brick road? It should be an RBR path that leads you there with:

1. Red dot on the Workspaces tab in the LHB/Bottom Tab Bar
2. Red dot on the workspace that contains the error in the list of workspaces
3. Red dot on the Receipt partners menu item in the LHN of the workspace settings
4. Red dot next to the three dots in the Uber connection card
5. Red error message in the Uber connection card.

[narefyev91]

@narefyev91 if #71241 solves this, can we make sure to link the PR to it? Else, we don't get automation.

Do you want to use this issue now for fixing the red brick road? It should be an RBR path that leads you there with:

1. Red dot on the Workspaces tab in the LHB/Bottom Tab Bar
2. Red dot on the workspace that contains the error in the list of workspaces
3. Red dot on the Receipt partners menu item in the LHN of the workspace settings
4. Red dot next to the three dots in the Uber connection card
5. Red error message in the Uber connection card.

Yeah i will add logic for RBR as a part of this issue. Unfortunately could not link PR to #71241 in case it was initially by Artem (could not edit description). Anyway RBR will be covered here

[trjExpensify]

Okay, can you prioritise that? We failed this this test in the certification process, and I'd like to have the full RBR flow in place before I tell them to retest.