[Due for payment 2025-10-27] [$250] Per diem - Blank area above the keyboard on Destination list on confirm page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.16-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/test-runs/TR-859/folder/13176674/41237177/907089399
Email or phone of affected tester (no customers): sosdpsosnjojs@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• Workspace has imported per diem rates

1. Launch Expensify app
2. Go to workspace chat
3. Tap + > Create expense > Per diem
4. Go through the flow and proceed to confirm page
5. On confirm page, tap Destination field
6. Tap on the seaerch field

Expected Result:

There will be no blank area above the keyboard

Actual Result:

On confirm page, there is blank area above the keyboard on Destination list

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6952425_1758553690299.ScreenRecording_09-22-2025_23-04-47_1.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021970427535680316576
• Upwork Job ID: 1970427535680316576
• Last Price Increase: 2025-09-23

Issue Owner

Current Issue Owner: @twisterdotcom

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[abzokhattab]

🚨 Edited by proposal-police: This proposal was edited at 2025-09-23 12:55:29 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Blank area appears above the keyboard when tapping the Destination field on the per diem confirm page.

What is the root cause of that problem?

The IOURequestStepDestination component uses a hardcoded keyboardVerticalOffset that includes tab selector button height and padding, but this component is used in two different contexts:

• From the per diem tab (with tab selector buttons)
• From the confirmation page (without tab selector buttons)

When accessed from the confirmation page, the extra offset creates unnecessary blank space above the keyboard.

What changes do you think we should make in order to solve the problem?

• Modify the keyboardVerticalOffset calculation in IOURequestStepDestination to conditionally include tab selector dimensions
• Use the existing openedFromStartPage prop to determine the context
• Only add variables.tabSelectorButtonHeight + variables.tabSelectorButtonPadding when openedFromStartPage is true
• This ensures proper keyboard behavior in both tab and non-tab contexts

            keyboardVerticalOffset={variables.contentHeaderHeight + top + (openedFromStartPage ? variables.tabSelectorButtonHeight + variables.tabSelectorButtonPadding : 0)}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

An alternative solution is to enable the shouldEnableKeyboardAvoidingView prop in case openedFromStartPage is false in the screen warpper
This way, we preserve backward compatibility and tackle the new issue

shouldEnableKeyboardAvoidingView={openedFromStartPage}

[Eskalifer1]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Per diem - Blank area above the keyboard on Destination list on confirm page

What is the root cause of that problem?

We have calculation for keyboard here, but we need this calculation only when we are using this on creatation tab:

App/src/pages/iou/request/step/IOURequestStepDestination.tsx

Line 132 in 24962c7

keyboardVerticalOffset={variables.contentHeaderHeight + top + variables.tabSelectorButtonHeight + variables.tabSelectorButtonPadding}

What changes do you think we should make in order to solve the problem?

We dont need to add any offset if we are on other page like in this case, so we just need to pass 0 in this case:

 keyboardVerticalOffset={openedFromStartPage ? variables.contentHeaderHeight + top + variables.tabSelectorButtonHeight + variables.tabSelectorButtonPadding : 0}

PS: we can introduce a new param for that, or rely on an existing param

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Or we can add:

shouldEnableKeyboardAvoidingView={openedFromStartPage}

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[VictoriaExpensify]

I haven't had a chance to look at this and I'm just about to head out on OoO for 6 days. Reassigning - sorry!

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021970427535680316576