[Due for payment 2025-10-09] We show option to enable global reimbursements for account that already has it enabled

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @joekaufmanexpensify
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

1. Create a GBP workspace on an account on the global reimbursements beta.
2. Add a GBP business bank account from the workflows page so it is fully enabled.
3. Go to Account > Wallet.
4. Tap the GBP bank account row.

Expected Result:

You don't see the Enable global reimbursements button. We should only show that for US accounts that are not global reimbursements enabled. GBP/EUR/CAD/AUD accounts are always global reimbursements enabled.

Actual Result:

We show the Enable global reimbursements button for non-US accounts.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @hungvu193 / @sonialiap

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[hungvu193]

Comment here for assignment, since this is part of GR

[lorretheboy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We show the Enable global reimbursements button for non-US accounts.

What is the root cause of that problem?

We decide to show/hide by this logic

App/src/pages/settings/Wallet/WalletPage/WalletPage.tsx

Lines 350 to 353 in 01babe0

	const shouldShowEnableGlobalReimbursementsButton =
	isBetaEnabled(CONST.BETAS.GLOBAL_REIMBURSEMENTS_ON_ND) &&
	paymentMethod.selectedPaymentMethod.type === CONST.BANK_ACCOUNT.TYPE.BUSINESS &&
	!paymentMethod.selectedPaymentMethod?.additionalData?.corpay?.achAuthorizationForm;

What changes do you think we should make in order to solve the problem?

Should update to

    // Get the bank account currency to determine if global reimbursements button should be shown
    const selectedBankAccount = bankAccountList[paymentMethod.selectedPaymentMethod.bankAccountID ?? ''];
    const bankAccountCurrency = selectedBankAccount?.bankCurrency ?? '';

    const shouldShowEnableGlobalReimbursementsButton =
        isBetaEnabled(CONST.BETAS.GLOBAL_REIMBURSEMENTS_ON_ND) &&
        paymentMethod.selectedPaymentMethod.type === CONST.BANK_ACCOUNT.TYPE.BUSINESS &&
        !paymentMethod.selectedPaymentMethod?.additionalData?.corpay?.achAuthorizationForm &&
        // Only show for USD accounts. GBP/EUR/CAD/AUD accounts are always global reimbursements enabled
        bankAccountCurrency === CONST.CURRENCY.USD;

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[hungvu193]

Sorry @lorretheboy , @MrMuzyk will handle this one.

[lorretheboy]

Ah sure, thanks for remind me ^^