[$250] Onboarding - Invite your accountant task is not complete when a member is invited on onboarding

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.12-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/folder/13176677/test-cases/41236545
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: MacBook Air 15.6.1 Chrome, iPhone 15 iOS 18.5 Safari
App Component: Other

Action Performed:

1. Sign in to ND with a new gmail account
2. Select the "Track and budget expenses" purpose
3. Enter a name, click "Continue"
4. On the modal "Stay organized with a workspace" click "Create workspace"
5. On the "Invite members" screen enter your member's email address and continue
6. Navigate to #admins (If you created an account without +) or to the Concierge room
7. Verify that the task "Invite your accountant" is marked as complete

Expected Result:

"Invite your accountant" task is complete after inviting member during onboarding process

Actual Result:

"Invite your accountant" task is not complete after inviting member during onboarding process. The task is getting complete only when the admin invited a member from a workspace settings, and opened the task in #admins (or Concierge)

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6941751_1757605196937.Recording__1327.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021970281857397531336
• Upwork Job ID: 1970281857397531336
• Last Price Increase: 2025-09-23
• Automatic offers:
• nkdengineer | Contributor | 108877264

Issue Owner

Current Issue Owner: @VictoriaExpensify

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Invite your accountant" task is not complete after inviting member during onboarding process. The task is getting complete only when the admin invited a member from a workspace settings, and opened the task in #admins (or Concierge)

What is the root cause of that problem?

The isTaskAutoCompleted is false for the Invite your accountant task, even if we invited the member to the workspace.

App/src/libs/ReportUtils.ts

Lines 10425 to 10436 in f930771

	let isTaskAutoCompleted: boolean = task.autoCompleted;
	if (task.type === CONST.ONBOARDING_TASK_TYPE.VIEW_TOUR && onboarding?.selfTourViewed) {
	// If the user has already viewed the self tour, we mark the task as auto completed
	isTaskAutoCompleted = true;
	}
	const completedTaskReportAction = isTaskAutoCompleted
	? buildOptimisticTaskReportAction(currentTask.reportID, CONST.REPORT.ACTIONS.TYPE.TASK_COMPLETED, 'marked as complete', actorAccountID, 2)
	: null;
	if (task.type === CONST.ONBOARDING_TASK_TYPE.CREATE_WORKSPACE) {

App/src/libs/actions/Report.ts

Line 4270 in f930771

const onboardingData = prepareOnboardingOnyxData(

What changes do you think we should make in order to solve the problem?

1. Introduce a new parameter isInvitedAccountant and update the accountant task to auto-complete if isInvitedAccountant is true,

if (task.type === CONST.ONBOARDING_TASK_TYPE.INVITE_ACCOUNTANT && isInvitedAccountant) {
    isTaskAutoCompleted = true;
}

App/src/libs/ReportUtils.ts

Lines 10425 to 10436 in f930771

	let isTaskAutoCompleted: boolean = task.autoCompleted;
	if (task.type === CONST.ONBOARDING_TASK_TYPE.VIEW_TOUR && onboarding?.selfTourViewed) {
	// If the user has already viewed the self tour, we mark the task as auto completed
	isTaskAutoCompleted = true;
	}
	const completedTaskReportAction = isTaskAutoCompleted
	? buildOptimisticTaskReportAction(currentTask.reportID, CONST.REPORT.ACTIONS.TYPE.TASK_COMPLETED, 'marked as complete', actorAccountID, 2)
	: null;
	if (task.type === CONST.ONBOARDING_TASK_TYPE.CREATE_WORKSPACE) {

2. Pass isInvitedAccountant param as true to completeOnboardingReport here if we invite the user

const completeOnboarding = useCallback((isInvitedAccountant = false) => {
        completeOnboardingReport({
            engagementChoice: CONST.ONBOARDING_CHOICES.TRACK_WORKSPACE,
            onboardingMessage: onboardingMessages[CONST.ONBOARDING_CHOICES.TRACK_WORKSPACE],
            firstName: currentUserPersonalDetails.firstName,
            lastName: currentUserPersonalDetails.lastName,
            adminsChatReportID: onboardingAdminsChatReportID,
            onboardingPolicyID,
            isInvitedAccountant,
        });

App/src/pages/OnboardingWorkspaceInvite/BaseOnboardingWorkspaceInvite.tsx

Line 224 in f930771

const completeOnboarding = useCallback(() => {

const onboardingData = prepareOnboardingOnyxData(
        introSelected,
        engagementChoice,
        onboardingMessage,
        adminsChatReportID,
        onboardingPolicyID,
        userReportedIntegration,
        wasInvited,
        companySize,
        selectedInterestedFeatures,
        isInvitedAccountant,
    );

App/src/libs/actions/Report.ts

Line 4270 in f930771

const onboardingData = prepareOnboardingOnyxData(

completeOnboarding(true);

App/src/pages/OnboardingWorkspaceInvite/BaseOnboardingWorkspaceInvite.tsx

Line 279 in f930771

completeOnboarding();

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Update completeOnboarding unit test to verify the accountant task is auto-completed if isInvitedAccountant is true.

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@VictoriaExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[VictoriaExpensify]

Hmm I don't know that this is a bug - the system has no way of recognizing if the person you have invited is a member or accountant. @nlemma what happens if you use the "Invite your accountant now" hyperlink:

[nlemma]

@VictoriaExpensify if the admin invites a member after finishing onboarding the task gets completed. It is also mentioned in the actual results of the OP.

The task is getting complete only when the admin invited a member from a workspace settings, and opened the task in #admins (or Concierge)

[melvin-bot]

@VictoriaExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021970281857397531336