[Due for payment 2025-10-21] [$250] Onboarding - Missing "Add expense approvals " task after create a new workspace

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.8-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/folder/13176924/test-cases/41237573
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Windows 11 / Chrome, Chrome / Xiaomi Poco F5, macOS 14.5 / MacBook Air 2020, Android 13 / Xiaomi Poco F5, iOS 15.8.3 / iPhone 7 Plus
App Component: Other

Action Performed:

1. Create a new account on NewDot without an + alias
2. Select any option except "Manage my team's expenses" and enter your name
3. Skip test drive and finish the onboarding flow
4. Go to Workspaces and create a new workspace
5. Go to the Inbox and open the #admins room
6. Verify the task list

Expected Result:

The "Add expense approvals " task should be listed on the #admin room after create a new workspace.
Based on TC-4177:
Step 14. Verify the following task are displayed (Create a workspace-With green check mark, Set up categories, Set up tags, Add expense approvals, Invite your team)

Actual Result:

Missing "Add expense approvals " task on the #admin room after create a new workspace

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021967615478123067598
• Upwork Job ID: 1967615478123067598
• Last Price Increase: 2025-09-22
• Automatic offers:
• thelullabyy | Contributor | 108880921

Issue Owner

Current Issue Owner: @greg-schroeder

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mukhrr]

this should be BE issue from /api/OpenReport

[thelullabyy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Missing "Add expense approvals " task on the #admin room after create a new workspace

What is the root cause of that problem?

We don't declare that task here

What changes do you think we should make in order to solve the problem?

We should add the task:

            addExpenseApprovalsTask: {
                title: 'Add expense approvals',
                description: ({workspaceMoreFeaturesLink}) =>
                    `*Add expense approvals* to review your team's spend and keep it under control.\n` +
                    '\n' +
                    `Here's how to add expense approvals:\n` +
                    '\n' +
                    '1. Click *Settings*.\n' +
                    '2. Go to *Workspaces*.\n' +
                    '3. Select your workspace.\n' +
                    '4. Click *More features*.\n' +
                    '5. Enable *Workflows*.\n' +
                    '6. Navigate to *Workflows* in the workspace editor.\n' +
                    '7. Enable *Add approvals*.\n' +
                    `8. You'll be set as the expense approver. You can change this to any admin once you invite your team.\n` +
                    '\n' +
                    `[Take me to more features](${workspaceMoreFeaturesLink}).`,
            },

Then in here, add:

    const addExpenseApprovalsTask: OnboardingTask = {
        type: 'addExpenseApprovals',
        autoCompleted: false,
        title: () => translate(resolvedLocale, 'onboarding.tasks.addExpenseApprovalsTask.title'),
        description: ({workspaceMoreFeaturesLink}) => translate(resolvedLocale, 'onboarding.tasks.addExpenseApprovalsTask.description', {workspaceMoreFeaturesLink}),
    };

Then in here, add:

        tasks: [createWorkspaceTask, testDriveAdminTask, addAccountingIntegrationTask, connectCorporateCardTask, inviteTeamTask, setupCategoriesAndTags, setupCategoriesTask, setupTagsTask, addExpenseApprovalsTask],

We also need BE fix to make sure it works properly.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021967615478123067598

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[jjcoffee]

@thelullabyy's proposal LGTM!

🎀👀🎀 C+ reviewed