[Awaiting checklist completion] [$250] Web - Expense- Deleted unreported expense can be selected and added to report in offline mode

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.8-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: EGDE retest
#63858
https://github.com/Expensify/Expensify/issues/516768

Action Performed:

Precondition:

• Account has self DM

1. Go to staging.new.expensify.com
2. Go to workspace chat
3. Click + > Create report
4. Go to self DM
5. Track a manual expense in self DM
6. Go offline
7. Delete the track expense in Step 5
8. Go to workspace chat
9. On the empty report preview, click Add expense > Add unreported expense
10. Select the deleted track expense via checkbox.
11. Click Add to report

Expected Result:

In Step 10, the checkbox should not be clickable because the expense is deleted. (It was fixed here previously #64069)

Actual Result:

In Step 10, the checkbox is clickable when the expense is deleted. As a result, the deleted expense can be added to the report.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021967606170734877421
• Upwork Job ID: 1967606170734877421
• Last Price Increase: 2025-09-15

Issue Owner

Current Issue Owner: @jayeshmangwani

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Expense- Deleted unreported expense can be selected and added to report in offline mode

What is the root cause of that problem?

We are not passing the isDisabled prop to the TransactionItemRow component

App/src/pages/UnreportedExpenseListItem.tsx

Lines 70 to 82 in 11ff8e8

	<TransactionItemRow
	transactionItem={transactionItem}
	violations={violations?.[`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transactionItem.transactionID}`]}
	shouldUseNarrowLayout
	isSelected={isSelected}
	shouldShowTooltip={showTooltip}
	dateColumnSize={CONST.SEARCH.TABLE_COLUMN_SIZES.NORMAL}
	amountColumnSize={CONST.SEARCH.TABLE_COLUMN_SIZES.NORMAL}
	taxAmountColumnSize={CONST.SEARCH.TABLE_COLUMN_SIZES.NORMAL}
	onCheckboxPress={() => {
	onSelectRow(item);
	setIsSelected((val) => !val);
	}}

What changes do you think we should make in order to solve the problem?

We need to pass the isDisabled prop to the TransactionItemRow component

isDisabled={item.isDisabled ?? undefined}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

None

[twisterdotcom]

Hmm seems like we should just have @blimpich fix this right? Or @blimpich are you happy for us to open this up.

[Eskalifer1]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Expense- Deleted unreported expense can be selected and added to report in offline mode

What is the root cause of that problem?

Currently, we do not pass the isDisabled parameter for this component:

App/src/pages/UnreportedExpenseListItem.tsx

Lines 70 to 85 in 11ff8e8

	<TransactionItemRow
	transactionItem={transactionItem}
	violations={violations?.[`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transactionItem.transactionID}`]}
	shouldUseNarrowLayout
	isSelected={isSelected}
	shouldShowTooltip={showTooltip}
	dateColumnSize={CONST.SEARCH.TABLE_COLUMN_SIZES.NORMAL}
	amountColumnSize={CONST.SEARCH.TABLE_COLUMN_SIZES.NORMAL}
	taxAmountColumnSize={CONST.SEARCH.TABLE_COLUMN_SIZES.NORMAL}
	onCheckboxPress={() => {
	onSelectRow(item);
	setIsSelected((val) => !val);
	}}
	shouldShowCheckbox
	style={styles.p3}
	/>

As a result, it can be selected.

What changes do you think we should make in order to solve the problem?

We need to pass this parameter, but not just take it from item.isDisabled, but from props isDisabled. This is an important clarification, because in this case it corresponds to the approach throughout the application, and the item will be disabled if the entire section isDisabled:

Code to add:

isDisabled={!!isDisabled}

Here is where we get the isDisabled parameter:

App/src/components/SelectionList/BaseSelectionList.tsx

Line 645 in 11ff8e8

const isDisabled = !!section.isDisabled || item.isDisabled;

Thus, even if the element is not isDisabled, but the entire section is disabled, we will display the elements correctly.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Additionally, we can pass !isSelected, as we do here:

App/src/pages/UnreportedExpenseListItem.tsx

Line 58 in 11ff8e8

disabled={isDisabled && !isSelected}

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[twisterdotcom]

Okay, going to open it up.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021967606170734877421