[Due for payment 2025-10-07] [$250] Receipt required over CA$25.00 displayed briefly and changes to C$25.00

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.8-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @truph01
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

1. Create a new workspace with default currency CAD
2. Go to More features Page -> Enabled Rule feature
3. Submit an expense with the amount over 25
4. Observe the expense preview

Expected Result:

Error message displayed as "Receipt required over C$25.00"

Actual Result:

Receipt required over CA$25.00 displayed briefly and changes to C$25.00

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.1620.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021965859894693363932
• Upwork Job ID: 1965859894693363932
• Last Price Increase: 2025-09-17

Issue Owner

Current Issue Owner: @stitesExpensify

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Receipt required over CA$25.00 displayed briefly and changes to C$25.00

What is the root cause of that problem?

• The violation messages format the limit using Intl.NumberFormat, which for CAD in English locales returns “CA$.” But elsewhere (on the backend) we probably rely on our own currency mapping for CAD, which uses “C$.” Because of that mismatch, the UI first renders with “CA$” and then updates to “C$.”

App/src/libs/CurrencyUtils.ts

Lines 155 to 163 in 0691c43

	function convertAmountToDisplayString(amount = 0, currency: string = CONST.CURRENCY.USD): string {
	const convertedAmount = amount / 100.0;
	return format(IntlStore.getCurrentLocale(), convertedAmount, {
	style: 'currency',
	currency,
	minimumFractionDigits: CONST.MIN_TAX_RATE_DECIMAL_PLACES,
	maximumFractionDigits: CONST.MAX_TAX_RATE_DECIMAL_PLACES,
	});
	}

What changes do you think we should make in order to solve the problem?

• We should standardize how we show currency symbols so it’s always consistent with our app’s mapping. For CAD, that means always showing “C$” instead of mixing in “CA$.”
• To do this, add a helper that uses our mapped currency symbol but keeps the locale-aware number formatting:

function formatAmountWithMappedSymbol(amountInCents: number, currencyCode: string): string {
    const amountWithoutCurrency = CurrencyUtils.convertToDisplayStringWithoutCurrency(amountInCents, currencyCode);
    const currencySymbol = CurrencyUtils.getCurrencySymbol(currencyCode) ?? '';
    return `${currencySymbol}${amountWithoutCurrency}`;
}

• Then use this helper when setting formattedLimit for:

• Receipt-required violations →

  App/src/libs/Violations/ViolationsUtils.ts

  Line 388 in 0691c43

  formattedLimit: CurrencyUtils.convertAmountToDisplayString(policy.maxExpenseAmountNoReceipt, policy.outputCurrency),

• Over-limit and over-category-limit violations →

  App/src/libs/Violations/ViolationsUtils.ts

  Line 407 in 0691c43

  formattedLimit: CurrencyUtils.convertAmountToDisplayString(shouldCategoryShowOverLimitViolation ? categoryOverLimit : policy.maxExpenseAmount, policy.outputCurrency),

• over trip limit violation (not implemented yet) →
  

  App/src/libs/Violations/ViolationsUtils.ts

  Line 419 in 0691c43

  // formattedLimit: CurrencyUtils.convertAmountToDisplayString(updatedTransaction.amount, updatedTransaction.currency),

• OPTIONAL: We can create a new helper function in CurrencyUtils and also use it in components like PerDiemEReceipt and MoneyRequestConfirmationList for consistency and to keep the code DRY.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

• NA

What alternative solutions did you explore? (Optional)

• NA

Result

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When creating a workspace with CAD currency, enabling expense rules, and submitting an expense over $25, the receipt required violation message displays inconsistent currency symbols. The message briefly shows "Receipt required over CA$25.00" and then changes to "Receipt required over C$25.00". Users expect consistent display of "C$25.00" throughout the application.

What is the root cause of that problem?

The root cause is that currency formatting functions in CurrencyUtils.ts use JavaScript's Intl.NumberFormat API directly, which returns different currency symbols than what is defined in the application's currency list. For CAD currency:

• Intl.NumberFormat returns "CA$" as the currency symbol
• The application's currency list defines "C$" as the official symbol for CAD

App/src/libs/CurrencyUtils.ts

Lines 108 to 127 in 52b88c1

	function convertToDisplayString(amountInCents = 0, currency: string = CONST.CURRENCY.USD): string {
	const convertedAmount = convertToFrontendAmountAsInteger(amountInCents, currency);
	/**
	* Fallback currency to USD if it empty string or undefined
	*/
	let currencyWithFallback = currency;
	if (!currency) {
	currencyWithFallback = CONST.CURRENCY.USD;
	}
	return format(IntlStore.getCurrentLocale(), convertedAmount, {
	style: 'currency',
	currency: currencyWithFallback,
	// We are forcing the number of decimals because we override the default number of decimals in the backend for some currencies
	// See: https://github.com/Expensify/PHP-Libs/pull/834
	minimumFractionDigits: getCurrencyDecimals(currency),
	// For currencies that have decimal places > 2, floor to 2 instead as we don't support more than 2 decimal places.
	maximumFractionDigits: 2,
	});
	}

App/src/libs/CurrencyUtils.ts

Lines 155 to 163 in 52b88c1

	function convertAmountToDisplayString(amount = 0, currency: string = CONST.CURRENCY.USD): string {
	const convertedAmount = amount / 100.0;
	return format(IntlStore.getCurrentLocale(), convertedAmount, {
	style: 'currency',
	currency,
	minimumFractionDigits: CONST.MIN_TAX_RATE_DECIMAL_PLACES,
	maximumFractionDigits: CONST.MAX_TAX_RATE_DECIMAL_PLACES,
	});
	}

This inconsistency occurs because the Intl.NumberFormat API generates currency symbols based on locale standards, while Expensify maintains its own currency symbol definitions for consistency across the application.

What changes do you think we should make in order to solve the problem?

We should create a helper function that replaces Intl.NumberFormat generated symbols with the official symbols from our currency list. This ensures consistency across all currency formatting functions.

// Add this helper function to CurrencyUtils.ts
function replaceCurrencySymbol(formattedAmount: string, currency: string): string {
    const currencySymbol = getCurrencySymbol(currency);
    if (!currencySymbol) {
        return formattedAmount;
    }

    // Replace the Intl-generated symbol with our currency list symbol
    const intlSymbol = NumberFormatUtils.format(IntlStore.getPreferredLocale(), 1, {
        style: 'currency',
        currency,
    }).replace(/[\d\s.,]/g, '').trim();

    return formattedAmount.replace(intlSymbol, currencySymbol);
}

// Update existing functions to use the helper
function convertToDisplayString(amountInCents: number, currency: string): string {
    const convertedAmount = convertToFrontendAmount(amountInCents);
    const formattedAmount = NumberFormatUtils.format(IntlStore.getPreferredLocale(), convertedAmount, {
        style: 'currency',
        currency,
    });
    return replaceCurrencySymbol(formattedAmount, currency);
}

Apply the same pattern to convertAmountToDisplayString and convertToShortDisplayString functions.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

1. Verify that all three formatting functions (convertToDisplayString, convertAmountToDisplayString, convertToShortDisplayString) return the same currency symbol for any given currency:

test('should use consistent currency symbols across all formatting functions', () => {
    const testCurrencies = ['USD', 'CAD', 'EUR', 'GBP', 'AUD'];
    
    testCurrencies.forEach((currency) => {
        const amount = 2500; // $25.00
        const formatted1 = CurrencyUtils.convertToDisplayString(amount, currency);
        const formatted2 = CurrencyUtils.convertAmountToDisplayString(amount, currency);
        const formatted3 = CurrencyUtils.convertToShortDisplayString(amount, currency);
        
        const symbol1 = formatted1.replace(/[\d\s.,]/g, '').trim();
        const symbol2 = formatted2.replace(/[\d\s.,]/g, '').trim();
        const symbol3 = formatted3.replace(/[\d\s.,]/g, '').trim();
        
        expect(symbol1).toBe(symbol2);
        expect(symbol2).toBe(symbol3);
    });
});

2. Ensure that currency symbols from the currency list take precedence over Intl.NumberFormat symbols:

test('should use currency list symbols instead of Intl.NumberFormat symbols', () => {
    const testCases = [
        { currency: 'CAD', expectedSymbol: 'C$' },
        { currency: 'AUD', expectedSymbol: 'A$' },
    ];
    
    testCases.forEach(({ currency, expectedSymbol }) => {
        const formatted = CurrencyUtils.convertToDisplayString(2500, currency);
        expect(formatted).toMatch(new RegExp(`^${expectedSymbol.replace('$', '\\$')}`));
    });
});

[lorretheboy]

I have proposed a proposal here #69584 (comment) before, so I copy again back here

Proposal

Please re-state the problem that we are trying to solve in this issue.

Receipt required violation shows 25.00 briefly

What is the root cause of that problem?

Also, we have another issue that causes the unmatch between FE and BE is about the currency symbol. We should fix this as well otherwise the UI is still having a brief update

The FE is showing "AMD 25.25" while the backend returns "դր25.25" (using the Armenian Dram symbol)

App/src/libs/Violations/ViolationsUtils.ts

Line 388 in c70a6c7

formattedLimit: CurrencyUtils.convertAmountToDisplayString(policy.maxExpenseAmountNoReceipt, policy.outputCurrency),

What changes do you think we should make in order to solve the problem?

To fix this, we should update convertToDisplayString to accept 1 more param shouldUseLocalCurrencySymbol = false

So if it is enable, then we should get local currency symbol by getCurrencySymbol to use

    if (shouldUseLocalCurrencySymbol) {
        const currencySymbol = getCurrencySymbol(currencyWithFallback);

        if (currencySymbol) {
            const formattedNumber = format(IntlStore.getCurrentLocale(), convertedAmount, {
                style: 'decimal',
                minimumFractionDigits: getCurrencyDecimals(currency),
                maximumFractionDigits: 2,
            });
            return `${currencySymbol}${formattedNumber}`;
        }
    }

App/src/libs/CurrencyUtils.ts

Line 108 in e091028

function convertToDisplayString(amountInCents = 0, currency: string = CONST.CURRENCY.USD): string {

Or we can update directly to format function here to support local currency, however, I think since it's a general-purpose number formatting utility that's used throughout the codebase for various formatting needs (not just currency) so we can consider to only update in convertToDisplayString function

App/src/libs/NumberFormatUtils/index.ts

Line 10 in 462de3a

function format(locale: Locale | undefined, number: number, options?: Intl.NumberFormatOptions): string {

Or if we have any util function for this purpose in codebase, we can re-use it. However, i couldn't find it so I propose to update existing func. If we really have that function, we could use it

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021965859894693363932

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[melvin-bot]

@rushatgabhane Eep! 4 days overdue now. Issues have feelings too...