[Issue CLOSED for proposals] Remove the `RenameCardIsVirtual` Onyx migration once we are sure it stops running

[tgolen]

Coming from #67617 (comment)

This is a code cleanup task

1. Have an internal engineer check logs for [Migrate Onyx] Running RenameCardIsVirtual migration in the last 30 days
2. If there are no logs, then it's OK to remove the src/libs/migrations/RenameCardIsVirtual.ts Onyx migration

Issue Owner

Current Issue Owner: @tgolen

[tgolen]

@allgandalf @roryabraham @mountiny @shubham1206agra @SzymczakJ it looks like this migration is still happening daily. Does anyone know why? Ideally, with a migration, once it has run on an account, it shouldn't ever run again. When we've looked into other migrations, we've found that backend changes were never completed or were only partial fixes that didn't clean up whatever was being migrated.

I need someone to investigate why the migration is still happening, then submit a PR to fix it. Once the migration has stopped running for 30 days, then the migration can be removed from the frontend.

[shubham1206agra]

@tgolen Can you check if the BE was migrated?

[roryabraham]

Perhaps @grgia would have the best context?

• https://github.com/Expensify/Expensify/issues/382554
• Deprecate card.isVirtual references #39829

[roryabraham]

It looks like the back-end migration was completed on Sept 2nd, about 6 weeks ago. Though, looking at the Onyx migration it doesn't look like there's anything that would prevent it running every time the app opens, even if the back-end has been migrated.

[roryabraham]

Just spit-balling, but I wonder if one way to approach this would be to:

1. Add code that clears Onyx of everything except authentication info and keysToPreserve when we show the forced-upgrade screen.
2. Remove the front-end migration
3. Update the minimum app version to force an upgrade with fresh Onyx data.

[SzymczakJ]

Just FYI I'm currently not working for Expensify, if you want somebody from SWM to take care of it then you should contact @blazejkustra