[Due for payment 2025-09-23] [$250] Expense - Report header subtitle shows "From Chat Report" when submitting expenses offline

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.2-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/test-runs/TR-701/folder/13177049/41237813/881813231
Email or phone of affected tester (no customers): sdjdsijnodsisj@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Go offline.
3. Open 1:1 DM with non-existing user (random email).
4. Submit two expenses to the user.
5. Open the expense report.
6. Go online.

Expected Result:

Report header subtitle will show "From [user email]".

Actual Result:

Report header subtitle shows "From Chat Report" when submitting expenses to user offline and back online.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021965070454196826351
• Upwork Job ID: 1965070454196826351
• Last Price Increase: 2025-09-08

Issue Owner

Current Issue Owner: @bernhardoj

[melvin-bot]

Triggered auto assignment to @heyjennahay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - Report header subtitle shows "From Chat Report" when submitting expenses offline

What is the root cause of that problem?

• When offline, optimistic reports are created with the default name "Chat Report" (from CONST.REPORT.DEFAULT_REPORT_NAME)
• For non-existing users, personal details are not available, so getDisplayNameForParticipant returns empty string
• buildReportNameFromParticipantNames filters out participants with empty names, resulting in empty string here
• The system falls back to the stored report.reportName, which is still "Chat Report"
• When coming back online, the report name doesn't update because personal details are still missing

What changes do you think we should make in order to solve the problem?

Modify buildReportNameFromParticipantNames to handle missing personal details by falling back to login:

const buildReportNameFromParticipantNames = ({report, personalDetails: personalDetailsData}: {report: OnyxEntry<Report>; personalDetails?: Partial<PersonalDetailsList>}) =>
    Object.keys(report?.participants ?? {})
        .map(Number)
        .filter((id) => id !== currentUserAccountID)
        .slice(0, 5)
        .map((accountID) => {
            const personalDetail = personalDetailsData?.[accountID] ?? allPersonalDetails?.[accountID];
            const login = personalDetail?.login ?? getLoginByAccountID(accountID);
            const displayName = getDisplayNameForParticipant({
                accountID,
                shouldUseShortForm: true,
                personalDetailsData,
            });
            
            return {
                accountID,
                name: displayName ? displayName : formatPhoneNumber(login ?? ''),
            };
        })
        .filter((participant) => participant.name)
        .reduce((formattedNames, {name, accountID}, _, array) => {
            // If there is only one participant (if it is 0 or less the function will return empty string), return their full name
            if (array.length < 2) {
                const personalDetail = personalDetailsData?.[accountID] ?? allPersonalDetails?.[accountID];
                const login = personalDetail?.login ?? getLoginByAccountID(accountID);
                const fullDisplayName = getDisplayNameForParticipant({
                    accountID,
                    personalDetailsData,
                });
                
                return fullDisplayName ? fullDisplayName : formatPhoneNumber(login ?? '');
            }
            return formattedNames ? `${formattedNames}, ${name}` : name;
        }, '');

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We should add a test case to cover this case inside the buildReportNameFromParticipantNames suite here

it('falls back to login when personal details are missing for offline scenario', () => {
    const testAccountID = 999;
    const testLogin = 'testuser@example.com';
    
    const report: Report = {
        ...mockedChatReport,
        participants: {
            [currentUserAccountID]: {notificationPreference: CONST.REPORT.NOTIFICATION_PREFERENCE.ALWAYS},
            [testAccountID]: {notificationPreference: CONST.REPORT.NOTIFICATION_PREFERENCE.ALWAYS},
        },
    };

    // Simulate offline scenario where personal details are missing but login is available
    const personalDetails = {
        [currentUserAccountID]: {
            accountID: currentUserAccountID,
            displayName: 'CURRENT USER',
            firstName: 'CURRENT',
        },
        [testAccountID]: {
            accountID: testAccountID,
            login: testLogin,
            // No displayName or firstName - simulating missing personal details
        },
    };

    const result = buildReportNameFromParticipantNames({report, personalDetails});
    expect(result).toBe(testLogin);
});

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021965070454196826351

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The IOU report header parent navigation subtitle shows From Chat report instead of the parent report name.

What is the root cause of that problem?

We get the parent report name from the report attributes derived value.

App/src/libs/ReportUtils.ts

Lines 5102 to 5104 in e2fe31f

	if (canUseDerivedValue && derivedNameExists) {
	return attributes[report.reportID].reportName;
	}

When we go back online and the API is successful, there is a very brief moment where the optimistic personal detail is removed from Onyx first, but the report participants still contain the optimistic participant.

Because the optimistic personal detail data is empty, it falls back to the report reportName, which is Chat report. But the timing is unnoticeable and the report name in reportAttributes is immediately updated to the correct name when both optimistic personal detail and participant is removed. However, the header is not re-rendered because we get the report attributes from Onyx.connect.

App/src/libs/ReportUtils.ts

Lines 1115 to 1121 in e2fe31f

	let reportAttributesDerivedValue: ReportAttributesDerivedValue['reports'];
	Onyx.connect({
	key: ONYXKEYS.DERIVED.REPORT_ATTRIBUTES,
	callback: (value) => {
	reportAttributesDerivedValue = value?.reports ?? {};
	},
	});

What changes do you think we should make in order to solve the problem?

First, we need to accept a report attributes param in getParentNavigationSubtitle.

In AvatarWithDisplayName, pass reportAttributes.

const parentNavigationSubtitleData = getParentNavigationSubtitle(report, isParentReportArchived, reportAttributes);

then pass it down further to getReportName.

App/src/libs/ReportUtils.ts

Lines 5533 to 5534 in e2fe31f

	return {
	reportName: getReportName(parentReport),

reportName: getReportName(parentReport, undefined, undefined, undefined, undefined, reportAttributes),

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

[c3024]

Thank you for your proposals.

@bernhardoj 's RCA and suggested fix look good to me.

🎀 👀 🎀

[melvin-bot]

Triggered auto assignment to @srikarparsi, see https://stackoverflow.com/c/expensify/questions/7972 for more details.