Reports - When selecting sent or received IOU, "total spend" amount is displayed negative.

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.2-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: #69459
Email or phone of affected tester (no customers): ibellicotest+1736@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 / Android 12 / Chrome ( mWeb / Hybrid app)
App Component: Search

Action Performed:

Prerequisite: Have two accounts opened on two different devices or environments.

1. Open the Expensify app.
2. Log in as User A.
3. On another environment, as User B, create a manual expense and send it to chat with User A.
4. As User A, navigate to "Reports" > "Expenses"
5. Long tap and select the just received expense.
6. Note that the "Total Spend" amount on footer, is displayed as negative.
7. Navigate to "Inbox"
8. Tap on FAB and select "Create Expense"
9. Create a new manual expense and submit it to User C.
10. Navigate to "Reports" > "Expenses" again.
11. Long tap and select the expense that was just sent to User C.
12. Note that "Total Spend" amount on footer, is displayed as negative.

Expected Result:

When selecting a received IOU on "Reports", the "Total Spend" amount displayed, shouldn´t be negative.

Actual Result:

When selecting a sent or a received IOU on "Expenses" section on "Reports", the amount on the "Total Spend" field on footer, is always displayed as negative.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @nkuoch (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mohammadjafarinejad]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Reports - When selecting sent or received IOU, "total spend" amount is displayed negative.

What is the root cause of that problem?

• This bug came from Add total calculations when selecting rows #69459.
• In SearchPage.tsx, the code that calculates totals is subtracting each transaction amount instead of adding it.

App/src/pages/Search/SearchPage.tsx

Lines 673 to 681 in 5dcacfe

	const footerData = useMemo(() => {
	const shouldUseClientTotal = selectedTransactionsKeys.length > 0 && !areAllMatchingItemsSelected;
	const currency = metadata?.currency;
	const count = shouldUseClientTotal ? selectedTransactionsKeys.length : metadata?.count;
	const total = shouldUseClientTotal ? Object.values(selectedTransactions).reduce((acc, transaction) => acc - (transaction.convertedAmount ?? 0), 0) : metadata?.total;
	return {count, total, currency};
	}, [areAllMatchingItemsSelected, metadata?.count, metadata?.currency, metadata?.total, selectedTransactions, selectedTransactionsKeys.length]);

What changes do you think we should make in order to solve the problem?

• Update the reduce function to add transaction amounts instead of subtracting them:

reduce((acc, transaction) => acc + (transaction.convertedAmount ?? 0), 0)

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

• We can also use Math.abs.

[JS00001]

Closing and demoting, duplicate of: #68671