[Due for payment 2025-10-09] QBO - Categories page missing hyperlink for QuickBooks Online settings

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.2-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/test-runs/TR-701/folder/13176908/41237432/881812965
Email or phone of affected tester (no customers): biruknew45+2kiki92@gmail.com
Issue reported by: Applause Internal Team
Device used: Web, mweb, android
App Component: Workspace Settings

Action Performed:

Precondition -
Workspace is connected to QBO

1. Go to https://staging.new.expensify.com/
2. Go to the QBO-connected Workspace.
3. Go to Categories page

Expected Result:

The hyperlink “The categories below are imported from your QuickBooks Online settings” should be visible on the Categories page.

Actual Result:

The hyperlink “The categories below are imported from your QuickBooks Online settings” is not visible on the Categories page.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6936897_1757154598142.bandicam_2025-09-06_13-25-13-231.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @bfitzexpensify

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @Beamanator (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

QBO - Categories page missing hyperlink for QuickBooks Online settings

What is the root cause of that problem?

we are returning early here if customTagName is not provided

App/src/components/ImportedFromAccountingSoftware.tsx

Lines 51 to 53 in 34c2f92

	if (!customTagName) {
	return undefined;
	}

and we are not providing customTagName here

App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

Lines 444 to 449 in 34c2f92

	<ImportedFromAccountingSoftware
	policyID={policyId}
	currentConnectionName={currentConnectionName}
	connectedIntegration={connectedIntegration}
	translatedText={translate('workspace.categories.importedFromAccountingSoftware')}
	/>

What changes do you think we should make in order to solve the problem?

we should check translatedText and return early in this case only

if (!translatedText) {
    return undefined;
}

here

App/src/components/ImportedFromAccountingSoftware.tsx

Lines 51 to 53 in 34c2f92

	if (!customTagName) {
	return undefined;
	}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The hyperlink "The categories below are imported from your QuickBooks Online settings" is not visible on the Categories page for QBO-connected workspaces, even though it should appear when a workspace is connected to QuickBooks Online.

What is the root cause of that problem?

The root cause is in the ImportedFromAccountingSoftware component which has an incorrect conditional check that prevents it from rendering when customTagName is not provided.

The problematic code is this:

App/src/components/ImportedFromAccountingSoftware.tsx

Lines 51 to 53 in 34c2f92

	if (!customTagName) {
	return undefined;
	}

This condition causes the component to return undefined for Categories and Taxes pages (which don't pass customTagName), but it should only apply the tag-specific logic conditionally while still showing the basic "imported from accounting software" message.

What changes do you think we should make in order to solve the problem?

1. Remove the early return condition in ImportedFromAccountingSoftware component that prevents rendering when customTagName is not provided.

2. Make the tag-specific content conditional by only showing the "Employees see tags as [customTagName]" section when both isDisplayingTags and customTagName are provided.

- if (!customTagName) {
-     return undefined;
- }

And:

- {isDisplayingTags && (
+ {isDisplayingTags && customTagName && (
    <>
        <Text style={[styles.textNormal, styles.colorMuted]}>{translate('workspace.tags.employeesSeeTagsAs')}</Text>
        <Text style={[styles.textBold, styles.colorMuted]}>{customTagName}</Text>
        <Text style={[styles.textNormal, styles.colorMuted]}>.</Text>
    </>
)}

This ensures that:

• Categories and Taxes pages will show: "The categories/taxes below are imported from your [QuickBooks Online settings]."
• Tags page will show: "Tags are managed in your [QuickBooks Online settings]. Employees see tags as [CustomTagName]."

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

New tests can be added for ImportedFromAccountingSoftware component covering scenarios like:

• Without customTagName

• With customTagName + isDisplayingTags